From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC972CEBF61 for ; Mon, 17 Nov 2025 13:23:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 40ED310E359; Mon, 17 Nov 2025 13:23:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="QXt6OgYv"; dkim-atps=neutral Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5311910EA89 for ; Fri, 14 Nov 2025 14:35:12 +0000 (UTC) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-42b3b29153fso1212331f8f.3 for ; Fri, 14 Nov 2025 06:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763130911; x=1763735711; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dWXLhPsJovH76m+UWdSFM19WXCf+smwi4mOSlHBAWM0=; b=QXt6OgYvB0GrccRY4O/EVcLjkMbn+DlDWyNkAUdiOnNwqvKk92sOwFWTezHXn58Q9S mw1siUfJL0+hkSKLuRo3si3NdEbU14tElEK/Y4WAxVUwSsHAt0dpNxiQLhr71+eh8Wgs 7Epk38xAJNLQwkeGlqvJZs+ZfPC3TTfugHMmiSeJAzD9S5CPadte7p/kZ3E1QjHhjjd1 X6RQiGLmC+HFNJnemHOkeOkpaIZ3Umoj91TEf1AQgq1uernXrN9JmTuWSEOVWSMGMSop fVU9elwaWX7QI5HDzGTVOFQuajEfhrZyZ9MGcuYRAJG1bi1bwrLc1Vt+5+r02/7urLQl V8Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763130911; x=1763735711; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dWXLhPsJovH76m+UWdSFM19WXCf+smwi4mOSlHBAWM0=; b=DktEEXi2gChYOd522QJ1ZcOjuRrOo4dsCSukTyfF3qkLtDtn+74oGlENZdRRPAnIKd jIBaHqrfMtUeDxN9FTUo1njIWmNIVXD8NkPePettbCOriYiEiQwJyT5uJqarKtXinTQH eHHgDUR+aVFFO9355eLOOARmVCKgei2rq6ZYtX3Kp8VpIotXnTxe+Y5bgjjuQw9061AQ AuzIJdm1EPPvJA7Lvey5cWzes7wHf9bd8ppzXTLw1QWnX4UTv3CwqQWNCh79VQDa3S5w 4gtwYFZrShX7++90WyA/1bPkv9jmRow+LDZQ7JW8uYIuqBUuVjJHg53hfz6zDPx4OLLG rUjA== X-Forwarded-Encrypted: i=1; AJvYcCVnDfkGOaRzASkoytrb9sEByIijInxVTB5FkEUld5wBWkqEvYlTUCnBU1UilylIFfA7fJxAP1GTBuQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yz5UdHTPfue9pne1HMy3KVfBAhVxcKu3Do6kshb+QbPC9LQb4Mw gA3K6YCofA9Q7jym2RwLB32vJLUOz9uUGHQXQ1iD1IkWTQXVRUM2Fir6Aff7KPoii5U= X-Gm-Gg: ASbGnculOeQizlRzQfh7ti8j0d3Kw16KJMckCtjTP6LY5qMjS49P2PqHyepmlj4ul/f UYpuII6+cG6fjlCIxvriejV92dLxOtUV3FAd8qE6FD/EYNOvsoc4+3axO3hfC2esh70jXN0L8Rw R+80Ob9lxLZ8QmxJRy6HE14DfFXqsgUZShxvoT68aSzm+Tqw4SvJtcetSCzOISXt0pF2w/eJQRG XyH262/gvDXcta36GBJ22onkHxg6Q53896+z+bARQwZPU3fiedFggn9+JTMojgJdAGdIdAj/Vy6 XOXlzv1d7Ji0jvSKTt456WjPBZOzXcPwdarO+7zv2clsW00ar3mfXvFz1+j54xPpAnzgXINIVQu fxM19UJvz+khKob9r2IBk52JtuZInvggiyYaLyDDRW87KbcTYDY2UaoRKHEUifIQhIBuAplwcf5 uz X-Google-Smtp-Source: AGHT+IHw5DY+d3JMXj0ehkwCi00kh1fcOQgwNxL358oZwa3xTlItactqY9kSp562T/u4HnhssT9g/A== X-Received: by 2002:a05:6000:230b:b0:42b:40b5:e681 with SMTP id ffacd0b85a97d-42b593450f3mr3355692f8f.26.1763130910639; Fri, 14 Nov 2025 06:35:10 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b8a0sm10330771f8f.25.2025.11.14.06.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 06:35:09 -0800 (PST) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CCE895F820; Fri, 14 Nov 2025 14:35:08 +0000 (GMT) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: Simon Richter , Lucas De Marchi , Alex Deucher , amd-gfx@lists.freedesktop.org, Bjorn Helgaas , David Airlie , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , linux-pci@vger.kernel.org, Rodrigo Vivi , Simona Vetter , Tvrtko Ursulin , Christian =?utf-8?Q?K=C3=B6nig?= , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , =?utf-8?Q?Micha=C5=82?= Winiarski , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/11] PCI: Change pci_dev variable from 'bridge' to 'dev' In-Reply-To: <20251113162628.5946-4-ilpo.jarvinen@linux.intel.com> ("Ilpo =?utf-8?Q?J=C3=A4rvinen=22's?= message of "Thu, 13 Nov 2025 18:26:20 +0200") References: <20251113162628.5946-1-ilpo.jarvinen@linux.intel.com> <20251113162628.5946-4-ilpo.jarvinen@linux.intel.com> User-Agent: mu4e 1.12.14-dev2; emacs 30.1 Date: Fri, 14 Nov 2025 14:35:08 +0000 Message-ID: <87346gptr7.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 17 Nov 2025 13:23:35 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Ilpo J=C3=A4rvinen writes: > Upcoming fix to BAR resize will store also device BAR resource in the > saved list. Change the pci_dev variable in the loop from 'bridge' to > 'dev' as the former would be misleading with non-bridges in the list. > > This is in a separate change to reduce churn in the upcoming BAR resize > fix. > > While it appears that the logic in the loop doing pci_setup_bridge() is > altered as 'bridge' variable is no longer updated, a bridge should > never appear more than once in the saved list so the if check can only > match to the first entry. As such, the code with two distinct pci_dev > variables better represents the intention of the check compared with the > old code where bridge variable was reused for a different purpose. > > Signed-off-by: Ilpo J=C3=A4rvinen Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro