From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8EB5C3ABA2 for ; Mon, 16 Sep 2024 08:36:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5614A10E30A; Mon, 16 Sep 2024 08:36:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Xz4OHicY"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBB3E10E30C for ; Mon, 16 Sep 2024 08:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726475786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SZghuNl8RSxhnXryd0EQnOpNodf1ePXadDKLScPEidI=; b=Xz4OHicYetMR0XuOwvwxsaRFx2F4xM6ynnukJWYqbxj0pA0NKZreD4uiZEIcY33io8jpvp PR2a1vrmnhmNgK/cVnTTTUW8FEb4tWJso4Yww6CsdlRqy2plU5xi23L3f4RG2sCKjYP18X Yrk6VjTgSljWs7eS28zbBnY/vOsHEls= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-TM-EGwdTMT6jfKUU5uUCcQ-1; Mon, 16 Sep 2024 04:36:24 -0400 X-MC-Unique: TM-EGwdTMT6jfKUU5uUCcQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-374c9b0daf3so1051527f8f.1 for ; Mon, 16 Sep 2024 01:36:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726475784; x=1727080584; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SZghuNl8RSxhnXryd0EQnOpNodf1ePXadDKLScPEidI=; b=uJZ4vGrtEkQRCawZLdZNsJAkukjm2IMn9ZUPej0Qnnyy1cNX70f2+cOLQ/Lka1WUad rJ9R35yNANaI3uQbiyTr4oFdO5Hbz7m6B/cpeSJrB2g5fjTvh737X/31/AjVfi/kHvNR O0mlB2rsJvdKU/b/ZlWywtmotNK4oSpsFgroYdrOHxVnuXl81eU5YKzVJFHE2ODdcOHB 1719/nNUOoCiPWh9U/mxP+zeZCw3k9rvclbLRLq1hHeMPUlSms64ByaN5xcldySwGSTm jwKT1dY+1GbHQMe9ec+nxF1tYOuUEP+HhCO9y0HMFFToo0zMBmGd5TBrvdroHGvdtZsQ MtzA== X-Forwarded-Encrypted: i=1; AJvYcCXsg2LTBrp7IsRGv9XGXEwRUA8xQgGDVUjpjwpUrZJ0TzCuljM33BoqJaTf7pHCUgPcoRVJTYsNdiA=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzqY1jM/k96nZfivFyMFtbYwf7BKBePRgQal2ekk0WcWRbIK/gx AeHQgyaw+JPJ8MBYd+HWAtVZJsU3kipyFwsiNG1ws3PR3vGttv6myzUS8/VatOPEtLRZa09tlsF Yb3am7IYilMz6H23kHJ74AeoiHokPI6CrT0PwXHcV09eUOm0nfqHSESKO+i/V4VEyEw== X-Received: by 2002:adf:facb:0:b0:374:babf:ac4d with SMTP id ffacd0b85a97d-378d625360bmr4960087f8f.58.1726475783577; Mon, 16 Sep 2024 01:36:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHeUS2MF6BwNmrHrtyITHuRjTmMKPOYmdWcd0GIjcbKqPN/sItyo4uvsPMndSeuH50X7fkZOA== X-Received: by 2002:adf:facb:0:b0:374:babf:ac4d with SMTP id ffacd0b85a97d-378d625360bmr4960068f8f.58.1726475783006; Mon, 16 Sep 2024 01:36:23 -0700 (PDT) Received: from localhost (red-hat-inc.vlan560.asr1.mad1.gblx.net. [159.63.51.90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e72e49d5sm6620646f8f.17.2024.09.16.01.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 01:36:22 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , kernel test robot , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Julius Werner , Hugues Bruant , intel-gfx@lists.freedesktop.org, Brian Norris , dri-devel@lists.freedesktop.org, Borislav Petkov , chrome-platform@lists.linux.dev, Tzung-Bi Shih Subject: Re: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present In-Reply-To: References: <20240913213246.1549213-1-javierm@redhat.com> <202409151528.CIWZRPBq-lkp@intel.com> Date: Mon, 16 Sep 2024 10:36:21 +0200 Message-ID: <8734m0atbu.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Thomas Zimmermann writes: Hello Thomas and Tzung-Bi, > Hi > > Am 15.09.24 um 09:44 schrieb kernel test robot: >> Hi Javier, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on chrome-platform/for-next] >> [also build test ERROR on chrome-platform/for-firmware-next linus/master v6.11-rc7 next-20240913] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next >> patch link: https://lore.kernel.org/r/20240913213246.1549213-1-javierm%40redhat.com >> patch subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present >> config: riscv-randconfig-001-20240915 (https://download.01.org/0day-ci/archive/20240915/202409151528.CIWZRPBq-lkp@intel.com/config) >> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/202409151528.CIWZRPBq-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202409151528.CIWZRPBq-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >>>> ld.lld: error: undefined symbol: screen_info >> >>> referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27) >> >>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a >> >>> referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27) >> >>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a > > Not all platforms define screen_info. Maybe fix this by following Yes, after reading the build errors reported by the robot I remembered that we had similar issues with sysfb, for example commit 1260b9a7020 ("drivers/firmware: fix SYSFB depends to prevent build failures") fixed one of those. > Tzung-Bi's advice of removing the local variables and then guard the > test by CONFIG_SYSFB. If SYSFB has been defined, screen_info has to be > there. It's not a super pretty solution, though. > If possible I would prefer to avoid the ifdefery in the driver. I also believe that the local variables makes the code easier to read. But if you folks think that's better to drop them, I can do it in the next rev. Another option is to restrict the architectures where this driver could be build. As far as I understand it is mainly for x86 and ARM64 arches. These two have a screen_info defined so the driver will build correctly. I can include a preparatory patch that adds a "depends on x86 || ARM64". > Best regards > Thomas > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat