From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F77FE706E4 for ; Thu, 21 Sep 2023 08:00:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE95310E590; Thu, 21 Sep 2023 08:00:20 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8AE7C10E59B; Thu, 21 Sep 2023 08:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695283217; x=1726819217; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=4loMBAspTpubHwAc615FO7TZxrNZ2EsMN2Tx+B1Y+MQ=; b=X2XQJuxF4PJl1nnEjNPf97AXHUPYg+6C2GUppBsdBGiVcjbYxlcvNjNm 2gE0qeh5asSyVvQ3pLYSvwqkOOqZsVSPmYWJVY8X38u6kPYOCuh7qtoSM oNVmP1n2V114n0NhczEoAzzrrxbrnk66SFvSU4lb3fqewkNiSds4qyNAS oetiiB8zUyGNeqyNTCVVvFae9a/CqFF22Dey00G3Sk5hSZZrYJq5f784k cIyBBshUZKgZaAileaZDYL/x4HBy0iZ20+uzYN6yMZQsMgfa7Sw63qZGb ARSYyvr3qdoiVeD7XftLyQvEMXuEMhy0TgXk+aUn+JTgf8iT6KI6ruG1t w==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="466758882" X-IronPort-AV: E=Sophos;i="6.03,164,1694761200"; d="scan'208";a="466758882" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 01:00:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="862370664" X-IronPort-AV: E=Sophos;i="6.03,164,1694761200"; d="scan'208";a="862370664" Received: from idubinov-mobl1.ccr.corp.intel.com (HELO localhost) ([10.252.52.72]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 01:00:14 -0700 From: Jani Nikula To: Mitul Golani , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org In-Reply-To: <20230913060606.1105349-8-mitulkumar.ajitkumar.golani@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230913060606.1105349-1-mitulkumar.ajitkumar.golani@intel.com> <20230913060606.1105349-8-mitulkumar.ajitkumar.golani@intel.com> Date: Thu, 21 Sep 2023 11:00:12 +0300 Message-ID: <8734z8q7lf.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 13 Sep 2023, Mitul Golani wrote: > From: Swati Sharma > > DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show > to depict sink's precision. > Also, new debugfs entry is created to enforce fractional bpp. > If Force_DSC_Fractional_BPP_en is set then while iterating over > output bpp with fractional step size we will continue if output_bpp is > computed as integer. With this approach, we will be able to validate > DSC with fractional bpp. > > v2: > Add drm_modeset_unlock to new line(Suraj) > > Signed-off-by: Swati Sharma > Signed-off-by: Ankit Nautiyal > Signed-off-by: Mitul Golani > Reviewed-by: Suraj Kandpal > --- > .../drm/i915/display/intel_display_debugfs.c | 83 +++++++++++++++++++ > .../drm/i915/display/intel_display_types.h | 1 + > 2 files changed, 84 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > index f05b52381a83..776ab96def1f 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > @@ -1244,6 +1244,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data) > DP_DSC_YCbCr420_Native)), > str_yes_no(drm_dp_dsc_sink_supports_format(intel_dp->dsc_dpcd, > DP_DSC_YCbCr444))); > + seq_printf(m, "DSC_Sink_BPP_Precision: %d\n", > + drm_dp_dsc_sink_bpp_incr(intel_dp->dsc_dpcd)); > seq_printf(m, "Force_DSC_Enable: %s\n", > str_yes_no(intel_dp->force_dsc_en)); > if (!intel_dp_is_edp(intel_dp)) > @@ -1436,6 +1438,84 @@ static const struct file_operations i915_dsc_output_format_fops = { > .write = i915_dsc_output_format_write > }; > > +static int i915_dsc_fractional_bpp_show(struct seq_file *m, void *data) > +{ > + struct drm_connector *connector = m->private; > + struct drm_device *dev = connector->dev; > + struct drm_crtc *crtc; > + struct intel_dp *intel_dp; > + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector)); > + int ret; > + > + if (!encoder) > + return -ENODEV; > + > + ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex); > + if (ret) > + return ret; > + > + crtc = connector->state->crtc; > + if (connector->status != connector_status_connected || !crtc) { > + ret = -ENODEV; > + goto out; > + } > + > + intel_dp = intel_attached_dp(to_intel_connector(connector)); > + seq_printf(m, "Force_DSC_Fractional_BPP_Enable: %s\n", > + str_yes_no(intel_dp->force_dsc_fractional_bpp_en)); Why "Force_DSC_Fractional_BPP_Enable" in the output? Usually debugfs files, like sysfs files, for stuff like this should be attributes, one thing per file. Why print a long name for it, if the name of the debugfs file is the name of the attribute? And even if you print it for humans, why the underscores? > + > +out: > + drm_modeset_unlock(&dev->mode_config.connection_mutex); > + > + return ret; > +} > + > +static ssize_t i915_dsc_fractional_bpp_write(struct file *file, > + const char __user *ubuf, > + size_t len, loff_t *offp) > +{ > + struct drm_connector *connector = > + ((struct seq_file *)file->private_data)->private; I know this is copy-pasted from elsewhere, but really it's nicer to avoid the cast, and copy-paste from the places that get this right: struct seq_file *m = file->private_data; struct drm_connector *connector = m->private; > + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector)); > + struct drm_i915_private *i915 = to_i915(encoder->base.dev); > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > + bool dsc_fractional_bpp_enable = false; > + int ret; > + > + if (len == 0) > + return 0; kstrtobool_from_user() has this covered. > + > + drm_dbg(&i915->drm, > + "Copied %zu bytes from user to force fractional bpp for DSC\n", len); That's useless. > + > + ret = kstrtobool_from_user(ubuf, len, &dsc_fractional_bpp_enable); > + if (ret < 0) > + return ret; > + > + drm_dbg(&i915->drm, "Got %s for DSC Fractional BPP Enable\n", > + (dsc_fractional_bpp_enable) ? "true" : "false"); Is this useful? > + intel_dp->force_dsc_fractional_bpp_en = dsc_fractional_bpp_enable; > + > + *offp += len; > + > + return len; > +} > + > +static int i915_dsc_fractional_bpp_open(struct inode *inode, > + struct file *file) > +{ > + return single_open(file, i915_dsc_fractional_bpp_show, inode->i_private); > +} > + > +static const struct file_operations i915_dsc_fractional_bpp_fops = { > + .owner = THIS_MODULE, > + .open = i915_dsc_fractional_bpp_open, > + .read = seq_read, > + .llseek = seq_lseek, > + .release = single_release, > + .write = i915_dsc_fractional_bpp_write > +}; > + > /* > * Returns the Current CRTC's bpc. > * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc > @@ -1513,6 +1593,9 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector) > > debugfs_create_file("i915_dsc_output_format", 0644, root, > connector, &i915_dsc_output_format_fops); > + > + debugfs_create_file("i915_dsc_fractional_bpp", 0644, root, > + connector, &i915_dsc_fractional_bpp_fops); > } > > if (connector->connector_type == DRM_MODE_CONNECTOR_DSI || > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index 69bcabec4a29..27b31cb4c7b4 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1797,6 +1797,7 @@ struct intel_dp { > /* Display stream compression testing */ > bool force_dsc_en; > int force_dsc_output_format; > + bool force_dsc_fractional_bpp_en; > int force_dsc_bpc; > > bool hobl_failed; -- Jani Nikula, Intel