From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B71BAC636D4 for ; Tue, 7 Feb 2023 16:29:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BB13C10E54F; Tue, 7 Feb 2023 16:29:26 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9ED0910E54F; Tue, 7 Feb 2023 16:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675787364; x=1707323364; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=k6DEVP/noOg9lgpyGaFLkK7QNE64/4xhAb4mROcQD6k=; b=GnEIu1M/XoEdXItjBMMifDl9HHBfEN+aVB2ROqykbv0WTUy+gLrfwoSN DQg/Mp8HIl3Cqitc6Qp2mYMQT0wtJe2KO2VwhguZILgWfmI7ZfU+AUZFU H6nkini+9EzVhxJb983VIUvnIQaCONR5DcOsu0atFCcf+eWQvDTrnxHea LIhVJS9mBkB1IHiGUzAwv2aGSmzLZI+y5Lj6wq+V/Jbotvru2vFldxl61 4ZKRn+D78cnXh7kCDCvZtZe52Tn38+TB/4tQfoSQKSzohnMxzjPLR7nW2 FvIY41KF9TCFMglBlouySeAWiVuqHSwwugdP7n7Z9QnuFJwHSVCZzRM3R g==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="309196923" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="309196923" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 08:29:23 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="668840496" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="668840496" Received: from aapotti-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.149.175]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 08:29:23 -0800 Date: Tue, 07 Feb 2023 08:12:25 -0800 Message-ID: <87357ho3o6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matthew Auld In-Reply-To: References: <20230203155309.1042297-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Enable PL1 power limit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 07 Feb 2023 01:32:44 -0800, Matthew Auld wrote: > > On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit wrote: > > > > Previous documentation suggested that PL1 power limit is always > > enabled. However we now find this not to be the case on some > > platforms (such as ATSM). Therefore enable PL1 power limit during hwmon > > initialization. > > For some reason it looks like this change is impacting the atsm in CI: > https://intel-gfx-ci.01.org/tree/drm-tip/bat-atsm-1.html Hmm, the change was meant for ATSM. Anyway let me try to get hold of an ATSM and see if I can figure out what might be going on with these seemingly unrelated failures and if I can repro them locally. Thanks! > > > > > Bspec: 51864 > > > > v2: Add Bspec reference (Gwan-gyeong) > > v3: Add Fixes tag > > > > Fixes: 99f55efb79114 ("drm/i915/hwmon: Power PL1 limit and TDP setting") > > Signed-off-by: Ashutosh Dixit > > Reviewed-by: Gwan-gyeong Mun > > --- > > drivers/gpu/drm/i915/i915_hwmon.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c > > index 1225bc432f0d5..4683a5b96eff1 100644 > > --- a/drivers/gpu/drm/i915/i915_hwmon.c > > +++ b/drivers/gpu/drm/i915/i915_hwmon.c > > @@ -687,6 +687,11 @@ hwm_get_preregistration_info(struct drm_i915_private *i915) > > for_each_gt(gt, i915, i) > > hwm_energy(&hwmon->ddat_gt[i], &energy); > > } > > + > > + /* Enable PL1 power limit */ > > + if (i915_mmio_reg_valid(hwmon->rg.pkg_rapl_limit)) > > + hwm_locked_with_pm_intel_uncore_rmw(ddat, hwmon->rg.pkg_rapl_limit, > > + PKG_PWR_LIM_1_EN, PKG_PWR_LIM_1_EN); > > } > > > > void i915_hwmon_register(struct drm_i915_private *i915) > > -- > > 2.38.0 > >