From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate
Date: Mon, 24 Oct 2022 11:29:41 +0300 [thread overview]
Message-ID: <8735bdfwui.fsf@intel.com> (raw)
In-Reply-To: <167818fb-6eb5-7836-16a1-620853821734@intel.com>
On Mon, 24 Oct 2022, Andrzej Hajda <andrzej.hajda@intel.com> wrote:
> Hi,
>
> Thx for review.
>
> On 21.10.2022 20:31, Andi Shyti wrote:
>> Hi Andrzej,
>>
>> On Wed, Oct 19, 2022 at 04:38:17PM +0200, Andrzej Hajda wrote:
>>> This patch replaces all occurences of the form
>>> intel_uncore_write(reg, intel_uncore_read(reg) OP val)
>>> with intel_uncore_rmw.
>>>
>>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>>
>> There are some lines that go over 80 characters... do you mind if I fix them
>> before pushing it?
>
> No problem, I guess you know that for some time the 'hard' limit has
> been raised to 100 chars/line [1], and this is for aesthetic reasons :)
> If you do, please follow advice from Ville to break the line after the
> 2nd argument - to keep 'clear' and 'set' args on the same line, if possible.
Please don't get into the habit of changing stuff while pushing. Please
prefer pushing stuff that was sent to the list and the CI crunched
through as-is.
Changing the commit message is fine. Doing some glaring
comment/whitespace fixes is acceptable. But going through entire patches
and fixing issues while pushing, not so much.
And in this case in particular, please don't go out of your way to limit
to 80 characters.
BR,
Jani.
>
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
>
> Regards
> Andrzej
>
>>
>> Andi
>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-10-24 8:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 14:38 [Intel-gfx] [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate Andrzej Hajda
2022-10-19 14:38 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gt: " Andrzej Hajda
2022-10-19 14:48 ` Ville Syrjälä
2022-10-21 18:32 ` Andi Shyti
2022-10-19 14:46 ` [Intel-gfx] [PATCH v2 1/2] drm/i915: " Ville Syrjälä
2022-10-19 16:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] " Patchwork
2022-10-19 16:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-19 16:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-10-21 18:31 ` [Intel-gfx] [PATCH v2 1/2] " Andi Shyti
2022-10-24 7:29 ` Andrzej Hajda
2022-10-24 8:29 ` Jani Nikula [this message]
2022-10-24 9:42 ` Andi Shyti
2022-10-24 10:00 ` Jani Nikula
2022-10-24 18:37 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735bdfwui.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox