From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 856D8ECAAA1 for ; Tue, 6 Sep 2022 23:20:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0F4710E00B; Tue, 6 Sep 2022 23:20:55 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83CA710E00B for ; Tue, 6 Sep 2022 23:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662506450; x=1694042450; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=MISYfOWCOPOv8/80Bgep+rU7hcnbDUX/Nx3YKGMGKbY=; b=Eb4ZFARTrpEzgHW1G/afJJW25B0TqJiySSCDE1vnrPcfDsYR4/FSvUEC uTN/QxTeikkpo/r7Dz4VktgWSAOcRtO+Mdd8Fm00+mkk33rHxCIhx+owH RgpIMyzId6vdBz0zXTbLdAB4xSAISAnHmS5xMPo4hHRpKjwSxTU1Ev+sF R2HCiMjzcHdutzOV0wLlkU5xRzbTPXJKfyW6vc9IFNHsWAj8dcRTc79Es Nbu0S/FPR1KDr8VDSnJRGiUd9mLYDPrQ4LVD7WoV94gQljnGIecurkHfH x73gyJmwTbbwn4eNHZNrgwR3e7C9em8co57zfxDPZEkIneSTHv92e5Wu8 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="283731010" X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208";a="283731010" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 16:20:49 -0700 X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208";a="942657445" Received: from msiewny-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.160.129]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 16:20:48 -0700 Date: Tue, 06 Sep 2022 16:20:47 -0700 Message-ID: <8735d4rsxc.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: <20220906203349.177989-1-rodrigo.vivi@intel.com> References: <20220906203349.177989-1-rodrigo.vivi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915: Let's avoid even early init if SLPC is used. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 06 Sep 2022 13:33:49 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > void intel_rps_init_early(struct intel_rps *rps) > { > + if (rps_wants_slpc(rps)) > + return; > + So what happens if we "want" SLPC but finally could not enable it (switch slpc to "in use") and have to fall back to host turbo? If that's a valid possibility then we can't do the above. =46rom drivers/gpu/drm/i915/gt/uc/intel_uc.h * - Not supported: not available in HW and/or firmware not defined. * - Supported: available in HW and firmware defined. * - Wanted: supported + enabled in modparam. * - In use: wanted + firmware found on the system and successfully fetched. Thanks. -- Ashutosh