From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25DD8C00140 for ; Fri, 12 Aug 2022 06:49:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82606A72B7; Fri, 12 Aug 2022 06:48:55 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id D849EA6E1D for ; Fri, 12 Aug 2022 06:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660286912; x=1691822912; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=55+TNw56a0/H6gDQzXSM7LYK0+5AcfRptBJ1Tzi2F98=; b=NRjriFrfX+ipOUdo/u4LnngOG93PTtL5+LDHDL61uzOk8Z7Znf1U1w4O qNnqWPeVTR1E7OGUOyM0K8+7MkEXbmaBJJtAvYgnQ810BwU+dTO1gGSmp A64IioDCJ7VHF5ooAUR+KNeYs6O33cIUPmyME64Yb+r8c0fkkEDnVtT3Z EUbArFI/Ec6Bk0iT9iSQ1zsJlS/xVriRpIJl9ymcvSyEl9FpJRtdxq9R3 Xr0EGAd2OoXF2HMJWgX6H4noVtb2vLsQbXjC1c5Gyw3pzx89bsD2FzVn6 keyZuc185/kQIMyj22wZCYrmZcbQTgtI7HEi3m7txQKvfv6cG+JivynzL A==; X-IronPort-AV: E=McAfee;i="6400,9594,10436"; a="271309297" X-IronPort-AV: E=Sophos;i="5.93,231,1654585200"; d="scan'208";a="271309297" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 23:48:31 -0700 X-IronPort-AV: E=Sophos;i="5.93,231,1654585200"; d="scan'208";a="581982235" Received: from ebrazil-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.37.174]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 23:48:29 -0700 From: Jani Nikula To: "Murthy, Arun R" , "intel-gfx@lists.freedesktop.org" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Fri, 12 Aug 2022 09:48:27 +0300 Message-ID: <8735e2t0sk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to display.funcs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "De Marchi, Lucas" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 12 Aug 2022, "Murthy, Arun R" wrote: >> -----Original Message----- >> From: Intel-gfx On Behalf Of Jani >> Nikula >> Sent: Thursday, August 11, 2022 8:37 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani ; De Marchi, Lucas >> >> Subject: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to >> display.funcs >> >> Move display related members under drm_i915_private display sub-struct. >> >> Rename struct i915_clock_gating_funcs to intel_clock_gating_funcs while at >> it. >> >> Signed-off-by: Jani Nikula >> --- >> .../gpu/drm/i915/display/intel_display_core.h | 4 ++ >> drivers/gpu/drm/i915/i915_drv.h | 4 -- >> drivers/gpu/drm/i915/intel_pm.c | 58 +++++++++---------- >> 3 files changed, 33 insertions(+), 33 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h >> b/drivers/gpu/drm/i915/display/intel_display_core.h >> index ff76bd4079e4..98c6ccdc9100 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_core.h >> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h >> @@ -10,6 +10,7 @@ >> >> struct intel_atomic_state; >> struct intel_cdclk_funcs; >> +struct intel_clock_gating_funcs; >> struct intel_crtc; >> struct intel_crtc_state; >> struct intel_dpll_funcs; >> @@ -44,6 +45,9 @@ struct intel_display { >> >> /* irq display functions */ >> const struct intel_hotplug_funcs *hotplug; >> + >> + /* pm private clock gating functions */ >> + const struct intel_clock_gating_funcs *clock_gating; > Likewise having struct intel_display and all display related structs inside this, can this stuct be moved to intel_pm? > This is more related to a pm! I'm undecided whether it's eventually better to group the functions together, or spread the functions by, uh, functionality. But I'm pretty sure I want to first group them like this, see how the *other* named and anonymous sub-structs of intel_display shape up, and spread them around if that feels like the right thing to do. BR, Jani. > > Thanks and Regards, > Arun R Murthy > -------------------- -- Jani Nikula, Intel Open Source Graphics Center