From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE9BDC433F5 for ; Thu, 12 May 2022 18:49:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FEEB10E9CA; Thu, 12 May 2022 18:49:15 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED5B410E524 for ; Thu, 12 May 2022 18:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652381354; x=1683917354; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=elGRl1xr/LXnvzxcM6czz+DrX0QtFJcJb0FZHo4aBRE=; b=h7596mD4WAialI5BQ2ex3v1yJJj1dTH21gQFsKdvAYVLqNxhssms7Bo3 KlD7c2UmKXb9itW0Gy9WE+yxD0H6GUu68t8ecb9sOIxZBA4iVDGNcwejE /EhyzNGGIDcBlly1IlQz3yRZFtsluLSv8vnFFArYYhdaqXwZjxwrUaFNr pEbv1xgF+gVPw2ZrwPGm7fmONrpqX/+eTdoGbZtqy2tTrMOiu76SK49lL 7qHPEUia2x7r0Wp8YF1023+juQFcrJUFTvP+vdE08a+bJVvL569DOw5c6 2uAkaDUaMwEEX3GyFtykw7bF95cJ1K+opyzpPxqf0/B6Zv1OzcGCxKV/K Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10345"; a="257653001" X-IronPort-AV: E=Sophos;i="5.91,220,1647327600"; d="scan'208";a="257653001" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2022 11:49:13 -0700 X-IronPort-AV: E=Sophos;i="5.91,220,1647327600"; d="scan'208";a="624531510" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.113.81]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2022 11:49:12 -0700 Date: Thu, 12 May 2022 11:49:12 -0700 Message-ID: <8735he7fiv.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Tvrtko Ursulin In-Reply-To: <116e0ec0-86d8-d352-97f6-f15d9e1aef3c@linux.intel.com> References: <878rr774ct.wl-ashutosh.dixit@intel.com> <116e0ec0-86d8-d352-97f6-f15d9e1aef3c@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v5 0/7] drm/i915: Media freq factor and per-gt enhancements/fixes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 12 May 2022 00:59:11 -0700, Tvrtko Ursulin wrote: Hi Tvrtko, > On 12/05/2022 05:38, Dixit, Ashutosh wrote: > > On Wed, 11 May 2022 19:32:13 -0700, Ashutosh Dixit wrote: > >> > >> Some recent Intel dGfx platforms allow media IP to work at a different > >> frequency from the base GT. This patch series exposes sysfs controls for > >> this functionality in the new per-gt sysfs. Some enhancements and fixes to > >> previous per-gt functionality are also included to complete the new > >> functionality: > >> * Patches 1 and 2 implement basic sysfs controls for media freq > >> * Patch 3 extends previous pcode functions for multiple gt's > >> * Patch 4 inits pcode on different gt's > >> * Patch 5 adds a couple of pcode helpers > >> * Patch 6 uses the new pcode functions to retrieve media RP0/RPn freq > >> * Patch 7 fixes memory leaks in the previous per-gt sysfs implementation > >> and some code refactoring > > > > In this v5 I have dropped the last two patches of the v4 series, these > > ones: > > > > [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs > > [PATCH 8/8] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs > > > > Because these need more work based on the review comments. If this series > > is merged I will submit these patches as a separate series, otherwise I > > will re-add them to this series and resubmit (due to dependence between > > this series and those patches). > > > > Apart from this, I believe I have addressed all previous review comments on > > the patches in this series. > > > > Thanks for reviewing, > > Acked-by: Tvrtko Ursulin > > At some point we should starting documenting our sysfs in > Documentation/ABI. For instance the freq ratio this patch adds really > does need some user facing docs to know how to use it. Would you sign up > to document the bits this series adds as follow up? Yes, sure. Looks like none of the previous i915 sysfs (even the per-device one) is in Documentation/ABI so we'll need to figure out how we are doing to organize the files, e.g. just one big Documentation/ABI/testing/sysfs-driver-intel-i915 file or multiple files organized somehow. So let's do this as follow up. Thanks. -- Ashutosh