From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E053C433F5 for ; Tue, 9 Nov 2021 07:23:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1270A61056 for ; Tue, 9 Nov 2021 07:23:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1270A61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 846FD6E02D; Tue, 9 Nov 2021 07:23:03 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFF2D6E02D for ; Tue, 9 Nov 2021 07:23:02 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="213125534" X-IronPort-AV: E=Sophos;i="5.87,219,1631602800"; d="scan'208";a="213125534" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 23:23:02 -0800 X-IronPort-AV: E=Sophos;i="5.87,219,1631602800"; d="scan'208";a="503392456" Received: from stkachen-mobl3.ger.corp.intel.com (HELO localhost) ([10.251.216.106]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 23:23:00 -0800 From: Jani Nikula To: William Tseng , intel-gfx@lists.freedesktop.org In-Reply-To: <20211109065013.12717-1-william.tseng@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211109065013.12717-1-william.tseng@intel.com> Date: Tue, 09 Nov 2021 09:22:57 +0200 Message-ID: <8735o57pym.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsi: transmit brightness command in HS state X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: William Tseng , Cooper Chiou Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 09 Nov 2021, William Tseng wrote: > In Video Mode, if DSI transcoder is set to transmit packets > in LP Escape mode, screen flickering would be obseved when > brightness commands are continuously and quickly transmitted > to a panel. > > The problem may be resolved by changing the mode to transmit > packets from Low Power to HS. > > Cc: Ville Syrjala > Cc: Jani Nikula > Cc: Vandita Kulkarni > Cc: Lee Shawn C > Cc: Cooper Chiou > Signed-off-by: William Tseng > --- > drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c b/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c > index f61ed82e8867..a71ef1eb598c 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c > @@ -81,6 +81,7 @@ static void dcs_set_backlight(const struct drm_connector_state *conn_state, u32 > > for_each_dsi_port(port, intel_dsi->dcs_backlight_ports) { > dsi_device = intel_dsi->dsi_hosts[port]->device; > + dsi_device->mode_flags &= ~MIPI_DSI_MODE_LPM; Frankly I forget how this is intended to be used, but feels like you should maybe restore the flags afterwards. BR, Jani. > mipi_dsi_dcs_write(dsi_device, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, > &data, len); > } -- Jani Nikula, Intel Open Source Graphics Center