From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9E1C433ED for ; Mon, 3 May 2021 17:33:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13EFE610A6 for ; Mon, 3 May 2021 17:33:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13EFE610A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D3376E110; Mon, 3 May 2021 17:33:19 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB53B6E110 for ; Mon, 3 May 2021 17:33:18 +0000 (UTC) IronPort-SDR: bi8VcdtJaXBmtIaImJzOi2vnqvrdW8yCVsao8RxCKOIYXgyiiAOcrrEbWolunhQvT/ox0J6aQ7 h/IkD/G9C7jA== X-IronPort-AV: E=McAfee;i="6200,9189,9973"; a="178004857" X-IronPort-AV: E=Sophos;i="5.82,270,1613462400"; d="scan'208";a="178004857" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2021 10:33:17 -0700 IronPort-SDR: xVCQTnRoUGTBKVKnj87p4cSM6yfklvMKG7QOEsxPK41of6rdOQd7erKdaq1acFYIWWmFge5Op5 Z3yE/sGEY3Ug== X-IronPort-AV: E=Sophos;i="5.82,270,1613462400"; d="scan'208";a="432845314" Received: from tbashir-mobl.ger.corp.intel.com (HELO localhost) ([10.252.51.126]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2021 10:33:15 -0700 From: Jani Nikula To: Ankit Nautiyal , intel-gfx@lists.freedesktop.org In-Reply-To: <20210429084242.14353-1-ankit.k.nautiyal@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210429084242.14353-1-ankit.k.nautiyal@intel.com> Date: Mon, 03 May 2021 20:33:13 +0300 Message-ID: <8735v3204m.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use correct downstream caps for check Src-Ctl mode for PCON X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 29 Apr 2021, Ankit Nautiyal wrote: > Fix the typo in DPCD caps used for checking SRC CTL mode of > HDMI2.1 PCON > > Fixes: 04b6603d13be (drm/i915/display: Configure HDMI2.1 Pcon for FRL > only if Src-Ctl mode is available) Correct format for Fixes: is this: Fixes: 04b6603d13be ("drm/i915/display: Configure HDMI2.1 Pcon for FRL only if Src-Ctl mode is available") You'll get it with 'dim fixes ', along with some suggested Cc's. BR, Jani. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index dfa7da928ae5..b3e82aa8b4f8 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2112,7 +2112,7 @@ void intel_dp_check_frl_training(struct intel_dp *intel_dp) > * -PCON supports SRC_CTL_MODE (VESA DP2.0-HDMI2.1 PCON Spec Draft-1 Sec-7) > * -sink is HDMI2.1 > */ > - if (!(intel_dp->dpcd[2] & DP_PCON_SOURCE_CTL_MODE) || > + if (!(intel_dp->downstream_ports[2] & DP_PCON_SOURCE_CTL_MODE) || > !intel_dp_is_hdmi_2_1_sink(intel_dp) || > intel_dp->frl.is_trained) > return; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx