From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5920DC433E7 for ; Mon, 12 Oct 2020 09:09:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E56712076D for ; Mon, 12 Oct 2020 09:09:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E56712076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 074F56E0CE; Mon, 12 Oct 2020 09:09:26 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0B1B6E0CE for ; Mon, 12 Oct 2020 09:09:23 +0000 (UTC) IronPort-SDR: w1st96hWHN2cZWiXHol2WilZbBSf+HvCUEqK/mwx7wXDwPH0YBOp9PbkB48Ng0v1BPjFHFIfRe GgeuDxyNtkIw== X-IronPort-AV: E=McAfee;i="6000,8403,9771"; a="227356780" X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="227356780" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 02:09:22 -0700 IronPort-SDR: w4aYr32z32iliPcvV9yPrwM0htx7dAEO0A9vyBsyUHqk/PGyxNBsDcoCgYclNAm0J9dRsqkrqS kaDA9WLFxIbA== X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="463034226" Received: from chunt1x-mobl.ger.corp.intel.com (HELO localhost) ([10.252.18.170]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 02:09:20 -0700 From: Jani Nikula To: "20200828061941.17051-2-jani.nikula\@intel.com" <20200828061941.17051-2-jani.nikula@intel.com>, "intel-gfx\@lists.freedesktop.org" , "Shankar\, Uma" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Mon, 12 Oct 2020 12:09:17 +0300 Message-ID: <87362jdd4y.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 12 Oct 2020, "Lee, Shawn C" wrote: > On Fri, Aug 28, 2020 at 06:19AM, Shankar Uma wrote: >>> -----Original Message----- >>> From: Jani Nikula >>> Sent: Friday, August 28, 2020 11:50 AM >>> To: intel-gfx@lists.freedesktop.org >>> Cc: Nikula, Jani ; Shankar, Uma >>> >>> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if >>> available >>> >>> If a panel's EDID is broken, there may be an override EDID set in the ACPI >>> OpRegion mailbox #5. Use it if available. >> >>Looks Good to me. >>Reviewed-by: Uma Shankar >> >>> Cc: Uma Shankar >>> Signed-off-by: Jani Nikula >>> --- >>> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c >>> b/drivers/gpu/drm/i915/display/intel_dp.c >>> index c57ac83bf563..d1307be196a2 100644 >>> --- a/drivers/gpu/drm/i915/display/intel_dp.c >>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >>> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct intel_dp >>> *intel_dp, >>> goto out_vdd_off; >>> } >>> >>> +/* Set up override EDID, if any, from ACPI OpRegion */ >>> +intel_opregion_edid_override(intel_connector); >>> + > > Customer report DUT still get EDID from eDP panel instead of mailbox #5. > After some investigations, this change can retrieve EDID from mailbox #5 properly. > But driver still used panel's EDID to enable eDP display. This is because of drm_get_edid() > was executed after intel_opregion_edid_override(). drm_get_edid() return panel's EDID > and overwrite mailbox #5's. In recent kernels, drm_get_edid() respects EDID override, and calling drm_get_edid() will return the override EDID from mailbox #5 instead of retrieving the actual EDID. Check the kernel version they're using and the drm_get_edid() implementation. BR, Jani. > > We try to move drm_get_edid() before intel_opregion_edid_override(). > The test result is positive, mailbox #5 EDID will substitute for panel's. > It seems we may need some additional change for this patch. Thanks! > > Best regards, > Shawn > >>> mutex_lock(&dev->mode_config.mutex); >>> edid = drm_get_edid(connector, &intel_dp->aux.ddc); >>> if (edid) { >>> -- >>> 2.20.1 -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx