From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/selftests: fix NULL vs IS_ERR()
 check in mock_context_barrier()
Date: Thu, 21 Mar 2019 10:58:40 +0200
Message-ID: <8736ng1u4f.fsf@gaia.fi.intel.com>
References: <20190321083335.GA31210@kadam>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4001D89EBB
 for <intel-gfx@lists.freedesktop.org>; Thu, 21 Mar 2019 08:59:28 +0000 (UTC)
In-Reply-To: <20190321083335.GA31210@kadam>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dan Carpenter <dan.carpenter@oracle.com>, Jani Nikula <jani.nikula@linux.intel.com>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld <matthew.auld@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

RGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPiB3cml0ZXM6Cgo+IFRoZSBt
b2NrX2NvbnRleHQoKSBmdW5jdGlvbiByZXR1cm5zIE5VTEwgb24gZXJyb3IsIGl0IGRvZXNuJ3Qg
cmV0dXJuCj4gZXJyb3IgcG9pbnRlcnMuCj4KPiBGaXhlczogODVmZGRmMGIwMDI3ICgiZHJtL2k5
MTU6IEludHJvZHVjZSBhIGNvbnRleHQgYmFycmllciBjYWxsYmFjayIpCj4gU2lnbmVkLW9mZi1i
eTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+IC0tLQo+ICAuLi4v
Z3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9jb250ZXh0LmMgfCAgNCArLQo+ICBkcml2
ZXJzL3N0YWdpbmcvZXJvZnMvdW56aXBfdmxlLmMgICAgICAgICAgICAgfCA3MCArKysrKysrKysr
LS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgMzYgZGVsZXRp
b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5
MTVfZ2VtX2NvbnRleHQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dl
bV9jb250ZXh0LmMKPiBpbmRleCA0Mzk5ZWY5ZWJmMTUuLmExNzJkYmQ5Y2I5ZSAxMDA2NDQKPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1fY29udGV4dC5jCj4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2NvbnRleHQuYwo+
IEBAIC0xNjIwLDggKzE2MjAsOCBAQCBzdGF0aWMgaW50IG1vY2tfY29udGV4dF9iYXJyaWVyKHZv
aWQgKmFyZykKPiAgCW11dGV4X2xvY2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAKPiAg
CWN0eCA9IG1vY2tfY29udGV4dChpOTE1LCAibW9jayIpOwo+IC0JaWYgKElTX0VSUihjdHgpKSB7
Cj4gLQkJZXJyID0gUFRSX0VSUihjdHgpOwo+ICsJaWYgKCFjdHgpIHsKPiArCQllcnIgPSAtRU5P
TUVNOwo+ICAJCWdvdG8gdW5sb2NrOwo+ICAJfQoKWXVwLgoKVGhlIHJlc3Qgb2YgdGhlIGRpZmYg
aXMgdW5yZWxhdGVkIHRobywgcGxlYXNlIHJlc2VuZC4KCi1NaWthCgo+ICAKPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9zdGFnaW5nL2Vyb2ZzL3VuemlwX3ZsZS5jIGIvZHJpdmVycy9zdGFnaW5nL2Vy
b2ZzL3VuemlwX3ZsZS5jCj4gaW5kZXggYzdiM2IyMTEyM2MxLi5hNzExYmY2MWY2MGMgMTAwNjQ0
Cj4gLS0tIGEvZHJpdmVycy9zdGFnaW5nL2Vyb2ZzL3VuemlwX3ZsZS5jCj4gKysrIGIvZHJpdmVy
cy9zdGFnaW5nL2Vyb2ZzL3VuemlwX3ZsZS5jCj4gQEAgLTg0NCwxMSArODQ0LDkgQEAgc3RhdGlj
IHZvaWQgel9lcm9mc192bGVfdW56aXBfa2lja29mZih2b2lkICpwdHIsIGludCBiaW9zKQo+ICBz
dGF0aWMgaW5saW5lIHZvaWQgel9lcm9mc192bGVfcmVhZF9lbmRpbyhzdHJ1Y3QgYmlvICpiaW8p
Cj4gIHsKPiAgCWNvbnN0IGJsa19zdGF0dXNfdCBlcnIgPSBiaW8tPmJpX3N0YXR1czsKPiArCXN0
cnVjdCBlcm9mc19zYl9pbmZvICpzYmkgPSBOVUxMOwo+ICAJdW5zaWduZWQgaW50IGk7Cj4gIAlz
dHJ1Y3QgYmlvX3ZlYyAqYnZlYzsKPiAtI2lmZGVmIEVST0ZTX0ZTX0hBU19NQU5BR0VEX0NBQ0hF
Cj4gLQlzdHJ1Y3QgYWRkcmVzc19zcGFjZSAqbWMgPSBOVUxMOwo+IC0jZW5kaWYKPiAgCXN0cnVj
dCBidmVjX2l0ZXJfYWxsIGl0ZXJfYWxsOwo+ICAKPiAgCWJpb19mb3JfZWFjaF9zZWdtZW50X2Fs
bChidmVjLCBiaW8sIGksIGl0ZXJfYWxsKSB7Cj4gQEAgLTg1OCwyMCArODU2LDEyIEBAIHN0YXRp
YyBpbmxpbmUgdm9pZCB6X2Vyb2ZzX3ZsZV9yZWFkX2VuZGlvKHN0cnVjdCBiaW8gKmJpbykKPiAg
CQlEQkdfQlVHT04oUGFnZVVwdG9kYXRlKHBhZ2UpKTsKPiAgCQlEQkdfQlVHT04oIXBhZ2UtPm1h
cHBpbmcpOwo+ICAKPiAtI2lmZGVmIEVST0ZTX0ZTX0hBU19NQU5BR0VEX0NBQ0hFCj4gLQkJaWYg
KHVubGlrZWx5KCFtYyAmJiAhel9lcm9mc19pc19zdGFnaW5ncGFnZShwYWdlKSkpIHsKPiAtCQkJ
c3RydWN0IGlub2RlICpjb25zdCBpbm9kZSA9IHBhZ2UtPm1hcHBpbmctPmhvc3Q7Cj4gLQkJCXN0
cnVjdCBzdXBlcl9ibG9jayAqY29uc3Qgc2IgPSBpbm9kZS0+aV9zYjsKPiAtCj4gLQkJCW1jID0g
TU5HRF9NQVBQSU5HKEVST0ZTX1NCKHNiKSk7Cj4gLQkJfQo+ICsJCWlmICh1bmxpa2VseSghc2Jp
ICYmICF6X2Vyb2ZzX2lzX3N0YWdpbmdwYWdlKHBhZ2UpKSkKPiArCQkJc2JpID0gRVJPRlNfU0Io
cGFnZS0+bWFwcGluZy0+aG9zdC0+aV9zYik7Cj4gIAo+IC0JCS8qCj4gLQkJICogSWYgbWMgaGFz
IG5vdCBnb3R0ZW4sIGl0IGVxdWFscyBOVUxMLAo+IC0JCSAqIGhvd2V2ZXIsIHBhZ2UtPm1hcHBp
bmcgbmV2ZXIgYmUgTlVMTCBpZiB3b3JraW5nIHByb3Blcmx5Lgo+IC0JCSAqLwo+IC0JCWNhY2hl
bW5nZCA9IChwYWdlLT5tYXBwaW5nID09IG1jKTsKPiAtI2VuZGlmCj4gKwkJLyogc2JpIHNob3Vs
ZCBhbHJlYWR5IGJlIGdvdHRlbiBpZiB0aGUgcGFnZSBpcyBtYW5hZ2VkICovCj4gKwkJaWYgKHNi
aSkKPiArCQkJY2FjaGVtbmdkID0gZXJvZnNfcGFnZV9pc19tYW5hZ2VkKHNiaSwgcGFnZSk7Cj4g
IAo+ICAJCWlmICh1bmxpa2VseShlcnIpKQo+ICAJCQlTZXRQYWdlRXJyb3IocGFnZSk7Cj4gQEAg
LTk3Miw2ICs5NjIsNyBAQCBzdGF0aWMgaW50IHpfZXJvZnNfdmxlX3VuemlwKHN0cnVjdCBzdXBl
cl9ibG9jayAqc2IsCj4gIAlvdmVybGFwcGVkID0gZmFsc2U7Cj4gIAljb21wcmVzc2VkX3BhZ2Vz
ID0gZ3JwLT5jb21wcmVzc2VkX3BhZ2VzOwo+ICAKPiArCWVyciA9IDA7Cj4gIAlmb3IgKGkgPSAw
OyBpIDwgY2x1c3RlcnBhZ2VzOyArK2kpIHsKPiAgCQl1bnNpZ25lZCBpbnQgcGFnZW5yOwo+ICAK
PiBAQCAtOTgxLDI2ICs5NzIsMzcgQEAgc3RhdGljIGludCB6X2Vyb2ZzX3ZsZV91bnppcChzdHJ1
Y3Qgc3VwZXJfYmxvY2sgKnNiLAo+ICAJCURCR19CVUdPTighcGFnZSk7Cj4gIAkJREJHX0JVR09O
KCFwYWdlLT5tYXBwaW5nKTsKPiAgCj4gLQkJaWYgKHpfZXJvZnNfaXNfc3RhZ2luZ3BhZ2UocGFn
ZSkpCj4gLQkJCWNvbnRpbnVlOwo+IC0jaWZkZWYgRVJPRlNfRlNfSEFTX01BTkFHRURfQ0FDSEUK
PiAtCQlpZiAocGFnZS0+bWFwcGluZyA9PSBNTkdEX01BUFBJTkcoc2JpKSkgewo+IC0JCQlEQkdf
QlVHT04oIVBhZ2VVcHRvZGF0ZShwYWdlKSk7Cj4gLQkJCWNvbnRpbnVlOwo+IC0JCX0KPiAtI2Vu
ZGlmCj4gKwkJaWYgKCF6X2Vyb2ZzX2lzX3N0YWdpbmdwYWdlKHBhZ2UpKSB7Cj4gKwkJCWlmIChl
cm9mc19wYWdlX2lzX21hbmFnZWQoc2JpLCBwYWdlKSkgewo+ICsJCQkJaWYgKHVubGlrZWx5KCFQ
YWdlVXB0b2RhdGUocGFnZSkpKQo+ICsJCQkJCWVyciA9IC1FSU87Cj4gKwkJCQljb250aW51ZTsK
PiArCQkJfQo+ICsKPiArCQkJLyoKPiArCQkJICogb25seSBpZiBub24taGVhZCBwYWdlIGNhbiBi
ZSBzZWxlY3RlZAo+ICsJCQkgKiBmb3IgaW5wbGFjZSBkZWNvbXByZXNzaW9uCj4gKwkJCSAqLwo+
ICsJCQlwYWdlbnIgPSB6X2Vyb2ZzX29ubGluZXBhZ2VfaW5kZXgocGFnZSk7Cj4gIAo+IC0JCS8q
IG9ubHkgbm9uLWhlYWQgcGFnZSBjb3VsZCBiZSByZXVzZWQgYXMgYSBjb21wcmVzc2VkIHBhZ2Ug
Ki8KPiAtCQlwYWdlbnIgPSB6X2Vyb2ZzX29ubGluZXBhZ2VfaW5kZXgocGFnZSk7Cj4gKwkJCURC
R19CVUdPTihwYWdlbnIgPj0gbnJfcGFnZXMpOwo+ICsJCQlEQkdfQlVHT04ocGFnZXNbcGFnZW5y
XSk7Cj4gKwkJCSsrc3BhcnNlbWVtX3BhZ2VzOwo+ICsJCQlwYWdlc1twYWdlbnJdID0gcGFnZTsK
PiAgCj4gLQkJREJHX0JVR09OKHBhZ2VuciA+PSBucl9wYWdlcyk7Cj4gLQkJREJHX0JVR09OKHBh
Z2VzW3BhZ2Vucl0pOwo+IC0JCSsrc3BhcnNlbWVtX3BhZ2VzOwo+IC0JCXBhZ2VzW3BhZ2Vucl0g
PSBwYWdlOwo+ICsJCQlvdmVybGFwcGVkID0gdHJ1ZTsKPiArCQl9Cj4gIAo+IC0JCW92ZXJsYXBw
ZWQgPSB0cnVlOwo+ICsJCS8qIFBHX2Vycm9yIG5lZWRzIGNoZWNraW5nIGZvciBpbnBsYWNlZCBh
bmQgc3RhZ2luZyBwYWdlcyAqLwo+ICsJCWlmICh1bmxpa2VseShQYWdlRXJyb3IocGFnZSkpKSB7
Cj4gKwkJCURCR19CVUdPTihQYWdlVXB0b2RhdGUocGFnZSkpOwo+ICsJCQllcnIgPSAtRUlPOwo+
ICsJCX0KPiAgCX0KPiAgCj4gKwlpZiAodW5saWtlbHkoZXJyKSkKPiArCQlnb3RvIG91dDsKPiAr
Cj4gIAlsbGVuID0gKG5yX3BhZ2VzIDw8IFBBR0VfU0hJRlQpIC0gd29yay0+cGFnZW9mczsKPiAg
Cj4gIAlpZiAoel9lcm9mc192bGVfd29ya2dycF9mbXQoZ3JwKSA9PSBaX0VST0ZTX1ZMRV9XT1JL
R1JQX0ZNVF9QTEFJTikgewo+IEBAIC0xMDQ0LDEwICsxMDQ2LDkgQEAgc3RhdGljIGludCB6X2Vy
b2ZzX3ZsZV91bnppcChzdHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLAo+ICAJZm9yIChpID0gMDsgaSA8
IGNsdXN0ZXJwYWdlczsgKytpKSB7Cj4gIAkJcGFnZSA9IGNvbXByZXNzZWRfcGFnZXNbaV07Cj4g
IAo+IC0jaWZkZWYgRVJPRlNfRlNfSEFTX01BTkFHRURfQ0FDSEUKPiAtCQlpZiAocGFnZS0+bWFw
cGluZyA9PSBNTkdEX01BUFBJTkcoc2JpKSkKPiArCQlpZiAoZXJvZnNfcGFnZV9pc19tYW5hZ2Vk
KHNiaSwgcGFnZSkpCj4gIAkJCWNvbnRpbnVlOwo+IC0jZW5kaWYKPiArCj4gIAkJLyogcmVjeWNs
ZSBhbGwgaW5kaXZpZHVhbCBzdGFnaW5nIHBhZ2VzICovCj4gIAkJKHZvaWQpel9lcm9mc19nYXRo
ZXJfaWZfc3RhZ2luZ3BhZ2UocGFnZV9wb29sLCBwYWdlKTsKPiAgCj4gQEAgLTExOTgsNiArMTE5
OSw3IEBAIHBpY2t1cF9wYWdlX2Zvcl9zdWJtaXNzaW9uKHN0cnVjdCB6X2Vyb2ZzX3ZsZV93b3Jr
Z3JvdXAgKmdycCwKPiAgCWlmIChwYWdlLT5tYXBwaW5nID09IG1jKSB7Cj4gIAkJV1JJVEVfT05D
RShncnAtPmNvbXByZXNzZWRfcGFnZXNbbnJdLCBwYWdlKTsKPiAgCj4gKwkJQ2xlYXJQYWdlRXJy
b3IocGFnZSk7Cj4gIAkJaWYgKCFQYWdlUHJpdmF0ZShwYWdlKSkgewo+ICAJCQkvKgo+ICAJCQkg
KiBpbXBvc3NpYmxlIHRvIGJlICFQYWdlUHJpdmF0ZShwYWdlKSBmb3IKPiAtLSAKPiAyLjE3LjEK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4