From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse() Date: Fri, 07 Sep 2018 15:39:24 +0300 Message-ID: <8736ul4h37.fsf@intel.com> References: <20180907062135.30054-1-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7068D6E8F3 for ; Fri, 7 Sep 2018 12:39:09 +0000 (UTC) In-Reply-To: <20180907062135.30054-1-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Jan-Marek Glogowski , Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwNiBTZXAgMjAxOCwgRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k aXlhbkBpbnRlbC5jb20+IHdyb3RlOgo+IENvbW1lbnQgY2xhaW1zIGxpbmsgbmVlZHMgdG8gYmUg cmV0cmFpbmVkIGJlY2F1c2UgdGhlIGNvbm5lY3RlZCBzaW5rIHJhaXNlZAo+IGEgbG9uZyBwdWxz ZSB0byBpbmRpY2F0ZSBsaW5rIGxvc3MuIElmIHRoZSBzaW5rIGRpZCBzbywKPiBpbnRlbF9kcF9o b3RwbHVnKCkgd291bGQgaGF2ZSBoYW5kbGVkIGxpbmsgcmV0cmFpbmluZy4gTG9va2luZyBhdCB0 aGUKPiBsb2dzIGluIEJ1Z3ppbGxhIHJlZmVyZW5jZWQgaW4gY29tbWl0ICczY2Y3MWJjOTkwNGQg KCJkcm0vaTkxNTogUmUtYXBwbHkKPiBQZXJmb3JtIGxpbmsgcXVhbGl0eSBjaGVjaywgdW5jb25k aXRpb25hbGx5IGR1cmluZyBsb25nIHB1bHNlIiIpJywgdGhlCj4gaXNzdWUgaXMgdGhhdCB0aGUg c2luayBkb2VzIG5vdCB0cmlnZ2VyIGFuIGludGVycnVwdC4gV2Ugd2FudCB0aGUKPiAtPmRldGVj dCgpIGZyb20gdXNlciBzcGFjZSB0byBjaGVjayBsaW5rIHN0YXR1cyBhbmQgcmV0cmFpbi4gVmls bGUncwo+IHJldmlldyBmb3IgdGhlIG9yaWdpbmFsIHBhdGNoIGFsc28gaW5kaWNhdGVzIHRoZSBz YW1lIHJvb3QgY2F1c2UuCj4KPiBJIGhhdmUgYWxzbyByZW5hbWVkIGxvbmdfcHVsc2UoKSB0byBm dWxsX2RldGVjdCgpLgoKU2luY2UgaW50ZWxfZHBfZGV0ZWN0KCkgZG9lc24ndCBhY3R1YWxseSBk byAqYW55dGhpbmcqIGV4Y2VwdCBza2lwCmRldGVjdCBzb21ldGltZXMsIEkgdGhpbmsgImZ1bGwg ZGV0ZWN0IiBpcyBhIG1pc25vbWVyLgoKQXJndWFibHkgeW91IGNvdWxkIG1lcmdlIGludGVsX2Rw X2xvbmdfcHVsc2UoKSBpbnRvIGl0cyBvbmx5IGNhbGxlciwKaW50ZWxfZHBfZGV0ZWN0KCksIGFu ZCBkbyBhbiBlYXJseSByZXR1cm4gb24gc2tpcHBpbmcgZGV0ZWN0LiBZb3UgaGF2ZQp0byBsb29r IGF0IHRoZSBmdW5jdGlvbnMsIGFuZCB3b25kZXIgaWYgdGhlIGN1cnJlbnQgc3BsaXQgaXMgdGhl IHJpZ2h0Cm9uZS4KClBsZWFzZSBsZXQgb3RoZXJzIGNoaW1lIGluIHRvbyBiZWZvcmUgbWFraW5n IGNoYW5nZXMuCgpCUiwKSmFuaS4KCgo+Cj4gQ2M6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5j b20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFJv ZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBDYzogSmFuLU1hcmVrIEdsb2dv d3NraSA8Z2xvZ293QGZiaWhvbWUuZGU+Cj4gUmVmZXJlbmNlczogM2NmNzFiYzk5MDRkICgiZHJt L2k5MTU6IFJlLWFwcGx5ICJQZXJmb3JtIGxpbmsgcXVhbGl0eSBjaGVjaywgdW5jb25kaXRpb25h bGx5IGR1cmluZyBsb25nIHB1bHNlIiIpCj4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5k aXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMgfCAxNyArKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYwo+IGluZGV4IDQzNmMyMmRlMzNiNi4uYmVmZGFhMDc2ZDhjIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jCj4gQEAgLTUwMTIsNyArNTAxMiw3IEBAIGludGVsX2RwX3Vuc2V0X2Vk aWQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgfQo+ICAKPiAgc3RhdGljIGludAo+IC1p bnRlbF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAr aW50ZWxfZHBfZnVsbF9kZXRlY3Qoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ ICAJCSAgICBzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eCkKPiAgewo+ICAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2Uu ZGV2KTsKPiBAQCAtNTA3NCwxNiArNTA3NCw4IEBAIGludGVsX2RwX2xvbmdfcHVsc2Uoc3RydWN0 IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCWdvdG8gb3V0Owo+ICAJfSBlbHNlIHsK PiAgCQkvKgo+IC0JCSAqIElmIGRpc3BsYXkgaXMgbm93IGNvbm5lY3RlZCBjaGVjayBsaW5rcyBz dGF0dXMsCj4gLQkJICogdGhlcmUgaGFzIGJlZW4ga25vd24gaXNzdWVzIG9mIGxpbmsgbG9zcyB0 cmlnZ2VyaW5nCj4gLQkJICogbG9uZyBwdWxzZS4KPiAtCQkgKgo+IC0JCSAqIFNvbWUgc2lua3Mg KGVnLiBBU1VTIFBCMjg3USkgc2VlbSB0byBwZXJmb3JtIHNvbWUKPiAtCQkgKiB3ZWlyZCBIUEQg cGluZyBwb25nIGR1cmluZyBtb2Rlc2V0cy4gU28gd2UgY2FuIGFwcGFyZW50bHkKPiAtCQkgKiBl bmQgdXAgd2l0aCBIUEQgZ29pbmcgbG93IGR1cmluZyBhIG1vZGVzZXQsIGFuZCB0aGVuCj4gLQkJ ICogZ29pbmcgYmFjayB1cCBzb29uIGFmdGVyLiBBbmQgb25jZSB0aGF0IGhhcHBlbnMgd2UgbXVz dAo+IC0JCSAqIHJldHJhaW4gdGhlIGxpbmsgdG8gZ2V0IGEgcGljdHVyZS4gVGhhdCdzIGluIGNh c2Ugbm8KPiAtCQkgKiB1c2Vyc3BhY2UgY29tcG9uZW50IHJlYWN0ZWQgdG8gaW50ZXJtaXR0ZW50 IEhQRCBkaXAuCj4gKwkJICogQ2hlY2sgbGluayBzdGF0dXMgaW4gY2FzZSB0aGUgbGluayB3ZW50 IG91dCBvZgo+ICsJCSAqIHN5bmNocm9uaXphdGlvbiBhbmQgdGhlIHNpbmsgZGlkIG5vdCB0ZWxs IHVzLgo+ICAJCSAqLwo+ICAJCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyID0gJmRwX3Rv X2RpZ19wb3J0KGludGVsX2RwKS0+YmFzZTsKPiAgCj4gQEAgLTUxNDksNyArNTE0MSw4IEBAIGlu dGVsX2RwX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCQkJcmV0 dXJuIHJldDsKPiAgCQl9Cj4gIAo+IC0JCXN0YXR1cyA9IGludGVsX2RwX2xvbmdfcHVsc2UoaW50 ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3RvciwgY3R4KTsKPiArCQlzdGF0dXMgPSBpbnRlbF9kcF9m dWxsX2RldGVjdChpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yLAo+ICsJCQkJCSAgICAgIGN0 eCk7Cj4gIAl9Cj4gIAo+ICAJaW50ZWxfZHAtPmRldGVjdF9kb25lID0gZmFsc2U7CgotLSAKSmFu aSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK