From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 9/9] drm/i915: Split intel_enable_ddi() into DP and HDMI variants Date: Fri, 13 Oct 2017 17:20:47 +0300 Message-ID: <87376nku2o.fsf@intel.com> References: <20171010121207.570-1-ville.syrjala@linux.intel.com> <20171010121207.570-10-ville.syrjala@linux.intel.com> <87h8v5o3f4.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6196D6E066 for ; Fri, 13 Oct 2017 14:21:08 +0000 (UTC) In-Reply-To: <87h8v5o3f4.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMSBPY3QgMjAxNywgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVs LmNvbT4gd3JvdGU6Cj4gT24gVHVlLCAxMCBPY3QgMjAxNywgVmlsbGUgU3lyamFsYSA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Pgo+PiBVbnRhbmdsZSBpbnRlbF9lbmFi bGVfZGRpKCkgYnkgc3BsaXR0aW5nIGl0IGludG8gRFAgYW5kIEhETUkgc3BlY2lmaWMKPj4gdmFy aWFudHMuCj4+Cj4+IHYyOiBLZWVwIHVzaW5nIGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KCkg Zm9yIG5vdwo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RkaS5jIHwgODYgKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQo+PiAg MSBmaWxlIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyksIDM3IGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+PiBpbmRleCA0OWNmOGQ5ZDJiYzEuLjE4YmYwNmM3ZTQz ZiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPj4gQEAgLTIzNjksNDUgKzIzNjks NTcgQEAgdm9pZCBpbnRlbF9kZGlfZmRpX3Bvc3RfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2Rl ciAqZW5jb2RlciwKPj4gIAlJOTE1X1dSSVRFKEZESV9SWF9DVEwoUElQRV9BKSwgdmFsKTsKPj4g IH0KPj4gIAo+PiAtc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RkaShzdHJ1Y3QgaW50ZWxfZW5j b2RlciAqaW50ZWxfZW5jb2RlciwKPj4gLQkJCSAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKnBpcGVfY29uZmlnLAo+PiArc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RkaV9kcChz dHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPj4gKwkJCQljb25zdCBzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPj4gKwkJCQljb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rv cl9zdGF0ZSAqY29ubl9zdGF0ZSkKPj4gK3sKPj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPj4gKwlzdHJ1Y3QgaW50ZWxf ZHAgKmludGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKCZlbmNvZGVyLT5iYXNlKTsKPj4gKwllbnVt IHBvcnQgcG9ydCA9IGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KGVuY29kZXIpOwo+PiArCj4+ ICsJaWYgKHBvcnQgPT0gUE9SVF9BICYmIElOVEVMX0dFTihkZXZfcHJpdikgPCA5KQo+PiArCQlp bnRlbF9kcF9zdG9wX2xpbmtfdHJhaW4oaW50ZWxfZHApOwoKSSBub3RlIHRoYXQgdGhpcyB3YXMg b25seSBydW4gb24gdHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQIHByZXZpb3VzbHkuIEkKc3VwcG9z ZSB0aGUgY29uZGl0aW9uIGRvZXMgZWZmZWN0aXZlbHkgaW1wbHkgZWRwLCBzbyB0aGlzIGlzIHBy b2JhYmx5CmZpbmUuIEl0J3MganVzdCB0aGF0IHNvbWV0aW1lcyBJIHdvbmRlciBhYm91dCB0aGUg YW1vdW50IG9mIGJhY2tncm91bmQKa25vd2xlZGdlIGxpa2UgdGhpcyB0aGF0IHdlIGltcG9zZSBv biB0aGUgcmVhZGVyLgoKPj4gKwo+PiArCWludGVsX2VkcF9iYWNrbGlnaHRfb24oY3J0Y19zdGF0 ZSwgY29ubl9zdGF0ZSk7Cj4+ICsJaW50ZWxfcHNyX2VuYWJsZShpbnRlbF9kcCwgY3J0Y19zdGF0 ZSk7Cj4KPiBUaGlzIGlzIGJyb2tlbiB3aXRob3V0IGVkcCBjaGVjay4KCkFuZCBmaW5lIG5vdyB3 aXRoIDRkOTBmMmQ1MDdhYiAoImRybS9pOTE1OiBTdGFydCB0cmFja2luZyBQU1Igc3RhdGUgaW4K Y3J0YyBzdGF0ZSIpIG1lcmdlZC4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgoKCj4KPiBCUiwgSmFuaS4KPgo+Cj4+ICsJaW50ZWxfZWRwX2RycnNfZW5h YmxlKGludGVsX2RwLCBjcnRjX3N0YXRlKTsKPj4gKwo+PiArCWlmIChjcnRjX3N0YXRlLT5oYXNf YXVkaW8pCj4+ICsJCWludGVsX2F1ZGlvX2NvZGVjX2VuYWJsZShlbmNvZGVyLCBjcnRjX3N0YXRl LCBjb25uX3N0YXRlKTsKPj4gK30KPj4gKwo+PiArc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2Rk aV9oZG1pKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+PiArCQkJCSAgY29uc3Qgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4+ICsJCQkJICBjb25zdCBzdHJ1Y3Qg ZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSkKPj4gK3sKPj4gKwlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPj4gKwlz dHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmZW5j b2Rlci0+YmFzZSk7Cj4+ICsJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kZGlfZ2V0X2VuY29kZXJf cG9ydChlbmNvZGVyKTsKPj4gKwo+PiArCWludGVsX2hkbWlfaGFuZGxlX3Npbmtfc2NyYW1ibGlu ZyhlbmNvZGVyLAo+PiArCQkJCQkgIGNvbm5fc3RhdGUtPmNvbm5lY3RvciwKPj4gKwkJCQkJICBj cnRjX3N0YXRlLT5oZG1pX2hpZ2hfdG1kc19jbG9ja19yYXRpbywKPj4gKwkJCQkJICBjcnRjX3N0 YXRlLT5oZG1pX3NjcmFtYmxpbmcpOwo+PiArCj4+ICsJLyogSW4gSERNSS9EVkkgbW9kZSwgdGhl IHBvcnQgd2lkdGgsIGFuZCBzd2luZy9lbXBoYXNpcyB2YWx1ZXMKPj4gKwkgKiBhcmUgaWdub3Jl ZCBzbyBub3RoaW5nIHNwZWNpYWwgbmVlZHMgdG8gYmUgZG9uZSBiZXNpZGVzCj4+ICsJICogZW5h YmxpbmcgdGhlIHBvcnQuCj4+ICsJICovCj4+ICsJSTkxNV9XUklURShERElfQlVGX0NUTChwb3J0 KSwKPj4gKwkJICAgZGlnX3BvcnQtPnNhdmVkX3BvcnRfYml0cyB8IERESV9CVUZfQ1RMX0VOQUJM RSk7Cj4+ICsKPj4gKwlpZiAoY3J0Y19zdGF0ZS0+aGFzX2F1ZGlvKQo+PiArCQlpbnRlbF9hdWRp b19jb2RlY19lbmFibGUoZW5jb2RlciwgY3J0Y19zdGF0ZSwgY29ubl9zdGF0ZSk7Cj4+ICt9Cj4+ ICsKPj4gK3N0YXRpYyB2b2lkIGludGVsX2VuYWJsZV9kZGkoc3RydWN0IGludGVsX2VuY29kZXIg KmVuY29kZXIsCj4+ICsJCQkgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRj X3N0YXRlLAo+PiAgCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29u bl9zdGF0ZSkKPj4gIHsKPj4gLQlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIgPSAmaW50ZWxf ZW5jb2Rlci0+YmFzZTsKPj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0 b19pOTE1KGVuY29kZXItPmRldik7Cj4+IC0JZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kZGlfZ2V0 X2VuY29kZXJfcG9ydChpbnRlbF9lbmNvZGVyKTsKPj4gLQlpbnQgdHlwZSA9IGludGVsX2VuY29k ZXItPnR5cGU7Cj4+IC0KPj4gLQlpZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRfSERNSSkgewo+PiAt CQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9Cj4+IC0JCQllbmNf dG9fZGlnX3BvcnQoZW5jb2Rlcik7Cj4+IC0JCWJvb2wgY2xvY2tfcmF0aW8gPSBwaXBlX2NvbmZp Zy0+aGRtaV9oaWdoX3RtZHNfY2xvY2tfcmF0aW87Cj4+IC0JCWJvb2wgc2NyYW1ibGluZyA9IHBp cGVfY29uZmlnLT5oZG1pX3NjcmFtYmxpbmc7Cj4+IC0KPj4gLQkJaW50ZWxfaGRtaV9oYW5kbGVf c2lua19zY3JhbWJsaW5nKGludGVsX2VuY29kZXIsCj4+IC0JCQkJCQkgIGNvbm5fc3RhdGUtPmNv bm5lY3RvciwKPj4gLQkJCQkJCSAgY2xvY2tfcmF0aW8sIHNjcmFtYmxpbmcpOwo+PiAtCj4+IC0J CS8qIEluIEhETUkvRFZJIG1vZGUsIHRoZSBwb3J0IHdpZHRoLCBhbmQgc3dpbmcvZW1waGFzaXMg dmFsdWVzCj4+IC0JCSAqIGFyZSBpZ25vcmVkIHNvIG5vdGhpbmcgc3BlY2lhbCBuZWVkcyB0byBi ZSBkb25lIGJlc2lkZXMKPj4gLQkJICogZW5hYmxpbmcgdGhlIHBvcnQuCj4+IC0JCSAqLwo+PiAt CQlJOTE1X1dSSVRFKERESV9CVUZfQ1RMKHBvcnQpLAo+PiAtCQkJICAgaW50ZWxfZGlnX3BvcnQt PnNhdmVkX3BvcnRfYml0cyB8Cj4+IC0JCQkgICBERElfQlVGX0NUTF9FTkFCTEUpOwo+PiAtCX0g ZWxzZSBpZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQKSB7Cj4+IC0JCXN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoZW5jb2Rlcik7Cj4+IC0KPj4gLQkJaWYgKHBv cnQgPT0gUE9SVF9BICYmIElOVEVMX0dFTihkZXZfcHJpdikgPCA5KQo+PiAtCQkJaW50ZWxfZHBf c3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPj4gLQo+PiAtCQlpbnRlbF9lZHBfYmFja2xpZ2h0 X29uKHBpcGVfY29uZmlnLCBjb25uX3N0YXRlKTsKPj4gLQkJaW50ZWxfcHNyX2VuYWJsZShpbnRl bF9kcCwgcGlwZV9jb25maWcpOwo+PiAtCQlpbnRlbF9lZHBfZHJyc19lbmFibGUoaW50ZWxfZHAs IHBpcGVfY29uZmlnKTsKPj4gLQl9Cj4+IC0KPj4gLQlpZiAocGlwZV9jb25maWctPmhhc19hdWRp bykKPj4gLQkJaW50ZWxfYXVkaW9fY29kZWNfZW5hYmxlKGludGVsX2VuY29kZXIsIHBpcGVfY29u ZmlnLCBjb25uX3N0YXRlKTsKPj4gKwlpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShjcnRjX3N0YXRl LCBJTlRFTF9PVVRQVVRfSERNSSkpCj4+ICsJCWludGVsX2VuYWJsZV9kZGlfaGRtaShlbmNvZGVy LCBjcnRjX3N0YXRlLCBjb25uX3N0YXRlKTsKPj4gKwllbHNlCj4+ICsJCWludGVsX2VuYWJsZV9k ZGlfZHAoZW5jb2RlciwgY3J0Y19zdGF0ZSwgY29ubl9zdGF0ZSk7Cj4+ICB9Cj4+ICAKPj4gIHN0 YXRpYyB2b2lkIGludGVsX2Rpc2FibGVfZGRpX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv ZGVyLAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK