From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Stop ring before doing readiness check
Date: Wed, 13 Sep 2017 17:15:44 +0300 [thread overview]
Message-ID: <87377q3crz.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <150531168675.4880.15241718063068478347@mail.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2017-09-13 15:01:17)
>> Evidence indicates that even if the hardware happily
>> tells us to proceed with reset, it really isn't ready.
>> Resetting a freely running batchbuffer after we have
>> got ack for readiness, still can cause a system hang.
>
> Hmm, so we see it on early gen and late gen. I suggest we do it
> universally (except gen2 which is lacking the mechanism). It's unlikely
> that the requirement disappeared just for a couple of gen, more likely
> that we simply haven't triggered the pathological behaviour.
>
Agreed that we should do a blanket approach. I was in a hurry
to post a proposed fix as I heard the prime_* are not yet
blacklisted on shards. So lets hope this helps.
> Other than,
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> for the find.
Ta.
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-13 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 14:01 [PATCH] drm/i915: Stop ring before doing readiness check Mika Kuoppala
2017-09-13 14:08 ` Chris Wilson
2017-09-13 14:13 ` Ville Syrjälä
2017-09-13 14:15 ` Mika Kuoppala [this message]
2017-09-13 14:20 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-14 0:07 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-09-14 10:33 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87377q3crz.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox