From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 2/2] drm/i915: Check num_pipes before initializing or calling display hooks Date: Thu, 22 Dec 2016 12:48:01 +0200 Message-ID: <8737hgme8u.fsf@intel.com> References: <1482142746-21663-1-git-send-email-elaine.wang@intel.com> <1482142746-21663-2-git-send-email-elaine.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2F7F6F205 for ; Thu, 22 Dec 2016 10:48:04 +0000 (UTC) In-Reply-To: <1482142746-21663-2-git-send-email-elaine.wang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Wang Elaine , intel-gfx@lists.freedesktop.orgelaine.wang@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxOSBEZWMgMjAxNiwgV2FuZyBFbGFpbmUgPGVsYWluZS53YW5nQGludGVsLmNvbT4g d3JvdGU6Cj4gRnJvbTogRWxhaW5lIFdhbmcgPGVsYWluZS53YW5nQGludGVsLmNvbT4KPgo+IHdo ZW4gbnVtX3BpcGVzIGlzIHplcm8sIGl0IGluZGljYXRlcyBkaXNwbGF5IGRvZXNuJ3QgZXhpc3Qs IHNvIHRoZXJlCj4gaXMgbm8gbmVlZCB0byBpbml0aWFsaXplIGRpc3BsYXkgaG9va3MuIEFuZCB0 byBhdm9pZCBjYWxsaW5nIHRoZXNlCj4gdW5pbml0aWFsaXplZCBkaXNwbGF5IGhvb2tzLCByZXNw ZWN0IG51bV9waXBlcyBhdCB0aGUgYmVnaW5uaW5nIG9mCj4gaW50ZWxfbW9kZXNldF9pbml0X2h3 IGFuZCBpbnRlbF9pbml0X2Nsb2NrX2dhdGluZy4KPgo+IGludGVsX2luaXRfcG0oKSBjYWxscyBG QkMgaW5pdCBmdW5jdGlvbiBhbmQgdGhlbiBpbml0aWFsaXplcwo+IHdhdGVyIG1hcmsgaG9va3Mu IEJvdGggYXJlbid0IG5lZWRlZCB3aGVuIGRpc3BsYXkgZG9lc24ndCBleGlzdC4gQWRkCj4gY2hl Y2tpbmcgbnVtX3BpcGVzIGF0IHRoZSBiZWdpbm5pbmcgb2YgaW50ZWxfaW5pdF9wbSgpLgo+Cj4g djI6IE1vdmUgb25lIGNoZWNrIGZyb20gY2FsbGVyIHRvIGNhbGxlZSBmb3IgY29uc2lzdGVuY3ku Cj4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IEpv b25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBF bGFpbmUgV2FuZyA8ZWxhaW5lLndhbmdAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAgNiArKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcG0uYyAgICAgIHwgMTAgKysrKysrKysrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDE1 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiBpbmRleCA5Y2M1ZGJmLi5lMDc5ZWE3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNjAzMCw2ICsxNjAzMCw5IEBAIHN0YXRpYyB2b2lkIGlu dGVsX2F0b21pY19zdGF0ZV9mcmVlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAg ICovCj4gIHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5X2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiAgewo+ICsJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5udW1fcGlw ZXMgPT0gMCkKPiArCQlyZXR1cm47Cj4gKwo+ICAJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5n ZW4gPj0gOSkgewo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9waXBlX2NvbmZpZyA9IGhhc3dl bGxfZ2V0X3BpcGVfY29uZmlnOwo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9pbml0aWFsX3Bs YW5lX2NvbmZpZyA9Cj4gQEAgLTE2NDEyLDYgKzE2NDE1LDkgQEAgdm9pZCBpbnRlbF9tb2Rlc2V0 X2luaXRfaHcoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICAKPiArCWlmIChJTlRFTF9JTkZP KGRldl9wcml2KS0+bnVtX3BpcGVzID09IDApCj4gKwkJcmV0dXJuOwo+ICsKPiAgCWludGVsX3Vw ZGF0ZV9jZGNsayhkZXZfcHJpdik7Cj4gIAo+ICAJZGV2X3ByaXYtPmF0b21pY19jZGNsa19mcmVx ID0gZGV2X3ByaXYtPmNkY2xrX2ZyZXE7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXgg ZDA4MzRiMy4uNjQzOGFkYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC03NjE5 LDcgKzc2MTksOCBAQCBzdGF0aWMgdm9pZCBpODMwX2luaXRfY2xvY2tfZ2F0aW5nKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIHZvaWQgaW50ZWxfaW5pdF9jbG9ja19n YXRpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQlkZXZfcHJp di0+ZGlzcGxheS5pbml0X2Nsb2NrX2dhdGluZyhkZXZfcHJpdik7Cj4gKwlpZiAoSU5URUxfSU5G TyhkZXZfcHJpdiktPm51bV9waXBlcykKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0X2Nsb2Nr X2dhdGluZyhkZXZfcHJpdik7Cj4gIH0KPiAgCj4gIHZvaWQgaW50ZWxfc3VzcGVuZF9odyhzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gQEAgLTc2NDQsNiArNzY0NSwxMCBAQCBz dGF0aWMgdm9pZCBub3BfaW5pdF9jbG9ja19nYXRpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICAgKi8KPiAgdm9pZCBpbnRlbF9pbml0X2Nsb2NrX2dhdGluZ19ob29rcyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiArCj4gKwlpZiAoSU5URUxf SU5GTyhkZXZfcHJpdiktPm51bV9waXBlcyA9PSAwKQo+ICsJCXJldHVybjsKPiArCgpMb29rcyBs aWtlIHRoaXMgd291bGQgYmUgbmVhdGVyIGJ5IGRvaW5nCgoJaWYgKElOVEVMX0lORk8oZGV2X3By aXYpLT5udW1fcGlwZXMgPT0gMCkKCQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0X2Nsb2NrX2dhdGlu ZyA9IG5vcF9pbml0X2Nsb2NrX2dhdGluZzsKCWVsc2UgaWYgKElTX1NLWUxBS0UoZGV2X3ByaXYp KQoJCS4uLgoKYW5kIHlvdSBjYW4gbGVhdmUgb3V0IHRoZSBjaGVjayBpbiBpbnRlbF9pbml0X2Ns b2NrX2dhdGluZygpLgoKV2UgcmVhbGx5IHdhbnQgdG8gbWluaW1pemUgdGhlIGFtb3VudCBvZiB0 aGVzZSBjaGVja3Mgc3ByaW5rbGVkIGFyb3VuZC4KCkJSLApKYW5pLgoKCgo+ICAJCWRldl9wcml2 LT5kaXNwbGF5LmluaXRfY2xvY2tfZ2F0aW5nID0gc2t5bGFrZV9pbml0X2Nsb2NrX2dhdGluZzsK PiAgCWVsc2UgaWYgKElTX0tBQllMQUtFKGRldl9wcml2KSkKPiBAQCAtNzY4NSw2ICs3NjkwLDkg QEAgdm9pZCBpbnRlbF9pbml0X2Nsb2NrX2dhdGluZ19ob29rcyhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gIC8qIFNldCB1cCBjaGlwIHNwZWNpZmljIHBvd2VyIG1hbmFnZW1l bnQtcmVsYXRlZCBmdW5jdGlvbnMgKi8KPiAgdm9pZCBpbnRlbF9pbml0X3BtKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICsJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYp LT5udW1fcGlwZXMgPT0gMCkKPiArCQlyZXR1cm47Cj4gKwo+ICAJaW50ZWxfZmJjX2luaXQoZGV2 X3ByaXYpOwo+ICAKPiAgCS8qIEZvciBjeHNyICovCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9w ZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=