From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD
Date: Thu, 13 Oct 2016 12:38:29 +0300 [thread overview]
Message-ID: <8737k01td6.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20161012112246.19176-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> '\n' is supposed to be at the end of the line, not in the middle.
>
> Fixes: cdb324bde570 ("drm/i915: Show bounds of active request in the ring...")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Oopsie.
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 2df4bc2af0bb..673750fc0d5b 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -368,7 +368,7 @@ static void error_print_engine(struct drm_i915_error_state_buf *m,
> {
> err_printf(m, "%s command stream:\n", engine_str(ee->engine_id));
> err_printf(m, " START: 0x%08x\n", ee->start);
> - err_printf(m, " HEAD: 0x%08x\n [0x%08x]", ee->head, ee->rq_head);
> + err_printf(m, " HEAD: 0x%08x [0x%08x]\n", ee->head, ee->rq_head);
> err_printf(m, " TAIL: 0x%08x [0x%08x, 0x%08x]\n",
> ee->tail, ee->rq_post, ee->rq_tail);
> err_printf(m, " CTL: 0x%08x\n", ee->ctl);
> --
> 2.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-10-13 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 11:22 [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD Chris Wilson
2016-10-12 13:03 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-12 13:11 ` Saarinen, Jani
2016-10-13 9:38 ` Mika Kuoppala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737k01td6.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox