From: Jani Nikula <jani.nikula@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Deny wrapping an userptr into a framebuffer
Date: Tue, 13 Oct 2015 17:08:11 +0300 [thread overview]
Message-ID: <8737xe50ac.fsf@intel.com> (raw)
In-Reply-To: <561D0E72.9060507@linux.intel.com>
On Tue, 13 Oct 2015, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 13/10/15 14:22, Chris Wilson wrote:
>> Pinning a userptr onto the hardware raises interesting questions about
>> the lifetime of such a surface as the framebuffer extends that life
>> beyond the client's address space. That is the hardware will need to
>> keep scanning out from the backing storage even after the client wants
>> to remap its address space. As the hardware pins the backing storage,
>> the userptr becomes invalid and this raises a WARN when the clients
>> tries to unmap its address space. The situation can be even more
>> complicated when the buffer is passed between processes, between a
>> client and display server, where the lifetime and hardware access is
>> even more confusing. Deny it.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Pushed to drm-intel-fixes, thanks for the patch and review.
BR,
Jani.
>
> Regards,
>
> Tvrtko
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-10-13 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 13:22 [PATCH] drm/i915: Deny wrapping an userptr into a framebuffer Chris Wilson
2015-10-13 14:00 ` [Intel-gfx] " Tvrtko Ursulin
2015-10-13 14:04 ` Tvrtko Ursulin
2015-10-13 14:08 ` Jani Nikula [this message]
2015-10-13 15:29 ` Daniel Vetter
2015-10-22 23:23 ` [Intel-gfx] " Kristian Høgsberg
2015-10-23 8:04 ` Daniel Vetter
2015-10-23 9:28 ` [Intel-gfx] " Chris Wilson
2015-10-23 19:20 ` Kristian Høgsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737xe50ac.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox