* [PATCH] drm/i915/dp: make link rate printing prettier
@ 2015-05-18 13:01 Jani Nikula
2015-05-18 13:10 ` Damien Lespiau
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2015-05-18 13:01 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Turn
[drm:intel_dp_print_rates] source rates: 162000,270000,540000,
[drm:intel_dp_print_rates] sink rates: 162000,270000,
[drm:intel_dp_print_rates] common rates: 162000,270000,
into
[drm:intel_dp_print_rates] source rates: 162000, 270000, 540000
[drm:intel_dp_print_rates] sink rates: 162000, 270000
[drm:intel_dp_print_rates] common rates: 162000, 270000
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index f99cca80867c..6e9f14ef2d2d 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1269,7 +1269,7 @@ static void snprintf_int_array(char *str, size_t len,
str[0] = '\0';
for (i = 0; i < nelem; i++) {
- int r = snprintf(str, len, "%d,", array[i]);
+ int r = snprintf(str, len, "%s%d", i ? ", " : "", array[i]);
if (r >= len)
return;
str += r;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/dp: make link rate printing prettier
2015-05-18 13:01 [PATCH] drm/i915/dp: make link rate printing prettier Jani Nikula
@ 2015-05-18 13:10 ` Damien Lespiau
2015-05-19 9:52 ` David Weinehall
2015-05-19 15:30 ` shuang.he
2 siblings, 0 replies; 5+ messages in thread
From: Damien Lespiau @ 2015-05-18 13:10 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, May 18, 2015 at 04:01:45PM +0300, Jani Nikula wrote:
> Turn
>
> [drm:intel_dp_print_rates] source rates: 162000,270000,540000,
> [drm:intel_dp_print_rates] sink rates: 162000,270000,
> [drm:intel_dp_print_rates] common rates: 162000,270000,
>
> into
>
> [drm:intel_dp_print_rates] source rates: 162000, 270000, 540000
> [drm:intel_dp_print_rates] sink rates: 162000, 270000
> [drm:intel_dp_print_rates] common rates: 162000, 270000
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index f99cca80867c..6e9f14ef2d2d 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1269,7 +1269,7 @@ static void snprintf_int_array(char *str, size_t len,
> str[0] = '\0';
>
> for (i = 0; i < nelem; i++) {
> - int r = snprintf(str, len, "%d,", array[i]);
> + int r = snprintf(str, len, "%s%d", i ? ", " : "", array[i]);
> if (r >= len)
> return;
> str += r;
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/dp: make link rate printing prettier
2015-05-18 13:01 [PATCH] drm/i915/dp: make link rate printing prettier Jani Nikula
2015-05-18 13:10 ` Damien Lespiau
@ 2015-05-19 9:52 ` David Weinehall
2015-05-20 6:56 ` Jani Nikula
2015-05-19 15:30 ` shuang.he
2 siblings, 1 reply; 5+ messages in thread
From: David Weinehall @ 2015-05-19 9:52 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, May 18, 2015 at 04:01:45PM +0300, Jani Nikula wrote:
> Turn
>
> [drm:intel_dp_print_rates] source rates: 162000,270000,540000,
> [drm:intel_dp_print_rates] sink rates: 162000,270000,
> [drm:intel_dp_print_rates] common rates: 162000,270000,
>
> into
>
> [drm:intel_dp_print_rates] source rates: 162000, 270000, 540000
> [drm:intel_dp_print_rates] sink rates: 162000, 270000
> [drm:intel_dp_print_rates] common rates: 162000, 270000
Wouldn't aligning the sink rates with the other two rates look nicer
(either by right-aligning the entire text, or by just right-aligning
the colon?
Admittedly this is just bikeshedding, but...
Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/dp: make link rate printing prettier
2015-05-19 9:52 ` David Weinehall
@ 2015-05-20 6:56 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2015-05-20 6:56 UTC (permalink / raw)
To: David Weinehall; +Cc: intel-gfx
On Tue, 19 May 2015, David Weinehall <david.weinehall@linux.intel.com> wrote:
> On Mon, May 18, 2015 at 04:01:45PM +0300, Jani Nikula wrote:
>> Turn
>>
>> [drm:intel_dp_print_rates] source rates: 162000,270000,540000,
>> [drm:intel_dp_print_rates] sink rates: 162000,270000,
>> [drm:intel_dp_print_rates] common rates: 162000,270000,
>>
>> into
>>
>> [drm:intel_dp_print_rates] source rates: 162000, 270000, 540000
>> [drm:intel_dp_print_rates] sink rates: 162000, 270000
>> [drm:intel_dp_print_rates] common rates: 162000, 270000
>
> Wouldn't aligning the sink rates with the other two rates look nicer
> (either by right-aligning the entire text, or by just right-aligning
> the colon?
>
> Admittedly this is just bikeshedding, but...
And clearly a separate patch, which is most welcome! ;)
BR,
Jani.
>
>
> Kind regards, David
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/dp: make link rate printing prettier
2015-05-18 13:01 [PATCH] drm/i915/dp: make link rate printing prettier Jani Nikula
2015-05-18 13:10 ` Damien Lespiau
2015-05-19 9:52 ` David Weinehall
@ 2015-05-19 15:30 ` shuang.he
2 siblings, 0 replies; 5+ messages in thread
From: shuang.he @ 2015-05-19 15:30 UTC (permalink / raw)
To: shuang.he, lei.a.liu, intel-gfx, jani.nikula
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6427
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 234/234 234/234
ILK 262/262 262/262
SNB -1 282/282 281/282
IVB 300/300 300/300
BYT 254/254 254/254
BDW -1 275/275 274/275
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
SNB igt@pm_rpm@dpms-mode-unset-non-lpsp DMESG_WARN(6)PASS(1) DMESG_WARN(1)
(dmesg patch applied)WARNING:at_drivers/gpu/drm/i915/intel_uncore.c:#assert_device_not_suspended[i915]()@WARNING:.* at .* assert_device_not_suspended+0x
*BDW igt@gem_flink@basic PASS(1) DMESG_WARN(1)
(dmesg patch applied)WARNING:at_drivers/gpu/drm/i915/intel_display.c:#assert_plane[i915]()@WARNING:.* at .* assert_plane
assertion_failure@assertion failure
WARNING:at_drivers/gpu/drm/drm_irq.c:#drm_wait_one_vblank[drm]()@WARNING:.* at .* drm_wait_one_vblank+0x
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-20 6:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 13:01 [PATCH] drm/i915/dp: make link rate printing prettier Jani Nikula
2015-05-18 13:10 ` Damien Lespiau
2015-05-19 9:52 ` David Weinehall
2015-05-20 6:56 ` Jani Nikula
2015-05-19 15:30 ` shuang.he
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox