From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dave Gordon <david.s.gordon@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Silence compiler warning in dvo
Date: Wed, 29 Apr 2015 14:51:48 +0300 [thread overview]
Message-ID: <87383jp2y3.fsf@intel.com> (raw)
In-Reply-To: <553E8DC7.6020901@intel.com>
On Mon, 27 Apr 2015, Dave Gordon <david.s.gordon@intel.com> wrote:
> On 27/04/15 16:32, Chris Wilson wrote:
>> drivers/gpu/drm/i915/intel_dvo.c: In function ‘intel_dvo_init’:
>> drivers/gpu/drm/i915/intel_dvo.c:531:8: warning: array subscript is above array bounds [-Warray-bounds]
>
> I found this one too, so:
>
> Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to drm-intel-next-queued, thanks for the patch and review.
BR,
Jani.
>> ---
>> drivers/gpu/drm/i915/intel_dvo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
>> index 7c9f85285aea..ece5bd754f85 100644
>> --- a/drivers/gpu/drm/i915/intel_dvo.c
>> +++ b/drivers/gpu/drm/i915/intel_dvo.c
>> @@ -496,7 +496,7 @@ void intel_dvo_init(struct drm_device *dev)
>> int gpio;
>> bool dvoinit;
>> enum pipe pipe;
>> - uint32_t dpll[2];
>> + uint32_t dpll[I915_MAX_PIPES];
>>
>> /* Allow the I2C driver info to specify the GPIO to be used in
>> * special cases, but otherwise default to what's defined
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-29 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 15:32 [PATCH] drm/i915: Silence compiler warning in dvo Chris Wilson
2015-04-27 19:28 ` Dave Gordon
2015-04-29 11:51 ` Jani Nikula [this message]
2015-04-28 10:42 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87383jp2y3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox