From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Prevent use-after-free in invalidate_range_start callback Date: Thu, 05 Feb 2015 16:39:03 +0200 Message-ID: <87386kxw1k.fsf@intel.com> References: <1422974897-4420-1-git-send-email-michal.winiarski@intel.com> <20150203150817.GB5784@nuc-i3427.alporthouse.com> <20150203161033.GR14009@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id D71806E232 for ; Thu, 5 Feb 2015 06:41:12 -0800 (PST) In-Reply-To: <20150203161033.GR14009@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Chris Wilson , =?utf-8?Q?Micha=C5=82?= Winiarski , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwMyBGZWIgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUdWUsIEZlYiAwMywgMjAxNSBhdCAwMzowODoxN1BNICswMDAwLCBDaHJpcyBXaWxz b24gd3JvdGU6Cj4+IE9uIFR1ZSwgRmViIDAzLCAyMDE1IGF0IDAzOjQ4OjE3UE0gKzAxMDAsIE1p Y2hhxYIgV2luaWFyc2tpIHdyb3RlOgo+PiA+IEl0J3MgcG9zc2libGUgZm9yIGludmFsaWRhdGVf cmFuZ2Vfc3RhcnQgbW11IG5vdGlmaWVyIGNhbGxiYWNrIHRvIHJhY2UKPj4gPiBhZ2FpbnN0IHVz ZXJwdHIgb2JqZWN0IHJlbGVhc2UuIElmIHRoZSBnZW0gb2JqZWN0IHdhcyByZWxlYXNlZCBwcmlv ciB0bwo+PiA+IG9idGFpbmluZyB0aGUgc3BpbmxvY2sgaW4gaW52YWxpZGF0ZV9yYW5nZV9zdGFy dCB3ZSdyZSBoaXR0aW5nIG51bGwKPj4gPiBwb2ludGVyIGRlcmVmZXJlbmNlLgo+PiA+IAo+PiA+ IFRlc3RjYXNlOiBpZ3QvZ2VtX3VzZXJwdHJfYmxpdHMvc3RyZXNzLW1tLWludmFsaWRhdGUtY2xv c2UqCj4+ID4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiA+ IFNpZ25lZC1vZmYtYnk6IE1pY2hhxYIgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVs LmNvbT4KPj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+Cj4gU2luY2UgaXQgYmxvd3MgdXAgaW4gdGhlIHJlYWwgd29ybGQgYWxyZWFkeSBhbHNv Cj4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+Cj4gYW5kIGZvciBKYW5pLiBBbmQgSmFu aSBjYW4gYWRkIHRoZSBjb21tZW50IHdoaWxlIGFwcGx5aW5nLCBJIGxpa2UgaXQgLQo+IGV4cGxh aW5pbmcgdGhhdCBraW5kIG9mIHdlYWsgcmVmIHN0dWZmIGlzIGFsd2F5cyBnb29kLgoKUHVzaGVk IHRvIGRybS1pbnRlbC1uZXh0LWZpeGVzIChhbmQgdGhlcmVmb3JlIGhlYWRlZCBmb3IgMy4yMCkg d2l0aApDaHJpcycgY29tbWVudCBhZGRlZC4KCkJSLApKYW5pLgoKCj4gLURhbmllbAo+Cj4+IAo+ PiBUaG91Z2ggSSB3b3VsZCBwZXJzb25hbGx5IHJlbW92ZSB0aGUgZXh0cmEgbmV3bGluZSBhbmQg YWRkIGFuIGV4dHJhIGNvbW1lbnQgaW5zdGVhZDoKPj4gCj4+ID4gLS0tCj4+ID4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX3VzZXJwdHIuYyB8IDEzICsrKysrKysrKysrLS0KPj4gPiAg MSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+ID4gCj4+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3VzZXJwdHIuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3VzZXJwdHIuYwo+PiA+IGluZGV4IGQxODIw NTguLjY0Yjg4MDIgMTAwNjQ0Cj4+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fdXNlcnB0ci5jCj4+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdXNl cnB0ci5jCj4+ID4gQEAgLTExMyw3ICsxMTMsMTAgQEAgcmVzdGFydDoKPj4gPiAgCQkJY29udGlu dWU7Cj4+ID4gIAo+PiA+ICAJCW9iaiA9IG1vLT5vYmo7Cj4+ID4gLQkJZHJtX2dlbV9vYmplY3Rf cmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+PiA+ICsJCWlmICgha3JlZl9nZXRfdW5sZXNzX3plcm8o Jm9iai0+YmFzZS5yZWZjb3VudCkpCj4+ID4gKwkJCWNvbnRpbnVlOwo+PiA+ICsKPj4gPiAgCQlz cGluX3VubG9jaygmbW4tPmxvY2spOwo+PiA+ICAKPj4gPiAgCQljYW5jZWxfdXNlcnB0cihvYmop Owo+PiA+IEBAIC0xNDksNyArMTUyLDEzIEBAIHN0YXRpYyB2b2lkIGk5MTVfZ2VtX3VzZXJwdHJf bW5faW52YWxpZGF0ZV9yYW5nZV9zdGFydChzdHJ1Y3QgbW11X25vdGlmaWVyICpfbW4sCj4+ID4g IAkJCWl0ID0gaW50ZXJ2YWxfdHJlZV9pdGVyX2ZpcnN0KCZtbi0+b2JqZWN0cywgc3RhcnQsIGVu ZCk7Cj4+ID4gIAkJaWYgKGl0ICE9IE5VTEwpIHsKPj4gPiAgCQkJb2JqID0gY29udGFpbmVyX29m KGl0LCBzdHJ1Y3QgaTkxNV9tbXVfb2JqZWN0LCBpdCktPm9iajsKPj4gPiAtCQkJZHJtX2dlbV9v YmplY3RfcmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+PiAJCQkvKiBUaGUgbW11X29iamVjdCBpcyBy ZWxlYXNlZCBsYXRlIHdoZW4KPj4gCQkJICogZGVzdHJveWluZyB0aGUgR0VNIG9iamVjdCBzbyBp dCBpcyBlbnRpcmVseQo+PiAJCQkgKiBwb3NzaWJsZSB0byBnYWluIGEgcmVmZXJlbmNlIG9uIGFu IG9iamVjdAo+PiAJCQkgKiBpbiB0aGUgcHJvY2VzcyBvZiBiZWluZyBmcmVlZCBzaW5jZSBvdXIK Pj4gCQkJICogc2VyaWFsaXNhdGlvbiBpcyB2aWEgdGhlIHNwaW5sb2NrIGFuZCBub3QgdGhlCj4+ IAkJCSAqIHN0cnVjdF9tdXRleCAtIGFuZCBjb25zZXF1ZW50bHkgdXNlIGl0Cj4+IAkJCSAqIGFm dGVyIGl0IGlzIGZyZWVkIGFuZCB0aGVuIGRvdWJsZSBmcmVlIGl0Lgo+PiAJCQkgKi8KPj4gPiAr CQkJaWYgKCFrcmVmX2dldF91bmxlc3NfemVybygmb2JqLT5iYXNlLnJlZmNvdW50KSkgewo+PiA+ ICsJCQkJc3Bpbl91bmxvY2soJm1uLT5sb2NrKTsKPj4gPiArCQkJCXNlcmlhbCA9IDA7Cj4+ID4g KwkJCQljb250aW51ZTsKPj4gPiArCQkJfQo+PiA+ICsKPj4gPiAgCQkJc2VyaWFsID0gbW4tPnNl cmlhbDsKPj4gPiAgCQl9Cj4+ID4gIAkJc3Bpbl91bmxvY2soJm1uLT5sb2NrKTsKPj4gLUNocmlz Cj4+IAo+PiAtLSAKPj4gQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRyZQo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo+Cj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRl bCBDb3Jwb3JhdGlvbgo+ICs0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK