From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 06/14] drm/i915: Replace big nested if
	block	with early return
Date: Tue, 19 Aug 2014 10:24:04 +0300
Message-ID: <8738cthrhn.fsf@intel.com>
References: <1408389369-22898-1-git-send-email-ville.syrjala@linux.intel.com>
 <1408389369-22898-7-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 09FC86E174
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Aug 2014 00:32:59 -0700 (PDT)
In-Reply-To: <1408389369-22898-7-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAxOCBBdWcgMjAxNCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6
Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K
Pgo+IExvb2tzIG5pY2VyLgoKU2lkZSBub3RlLCBJIGtpbmQgb2YgbGlrZSBhZGRpbmcgIk5vIGZ1
bmN0aW9uYWwgY2hhbmdlcy4iIGluIHRoZSBjb21taXQKbWVzc2FnZXMgb2YgcGF0Y2hlcyB0aGF0
IGRvIG5vdCBpbnRlbmQgdG8gZG8gZnVuY3Rpb25hbCBjaGFuZ2VzLiBJIGZpbmQKaXQgaGVscGZ1
bC4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKCj4K
PiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50
ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNDAgKysr
KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg
MjAgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw
LmMKPiBpbmRleCAxOWE4MThmLi5lNmI0ZDRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j
Cj4gQEAgLTEyMzIsMzggKzEyMzIsMzggQEAgc3RhdGljIHZvaWQgZWRwX3BhbmVsX3ZkZF9vZmZf
c3luYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2Rldmlj
ZSAqZGV2ID0gaW50ZWxfZHBfdG9fZGV2KGludGVsX2RwKTsKPiAgCXN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwlzdHJ1Y3QgaW50ZWxfZGln
aXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9Cj4gKwkJZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHAp
Owo+ICsJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIgPSAmaW50ZWxfZGlnX3Bv
cnQtPmJhc2U7Cj4gKwllbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIHBvd2VyX2RvbWFp
bjsKPiAgCXUzMiBwcDsKPiAgCXUzMiBwcF9zdGF0X3JlZywgcHBfY3RybF9yZWc7Cj4gIAo+ICAJ
V0FSTl9PTighZHJtX21vZGVzZXRfaXNfbG9ja2VkKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rp
b25fbXV0ZXgpKTsKPiAgCj4gLQlpZiAoIWludGVsX2RwLT53YW50X3BhbmVsX3ZkZCAmJiBlZHBf
aGF2ZV9wYW5lbF92ZGQoaW50ZWxfZHApKSB7Cj4gLQkJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9y
dCAqaW50ZWxfZGlnX3BvcnQgPQo+IC0JCQkJCQlkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4g
LQkJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIgPSAmaW50ZWxfZGlnX3BvcnQt
PmJhc2U7Cj4gLQkJZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbiBwb3dlcl9kb21haW47
Cj4gKwlpZiAoaW50ZWxfZHAtPndhbnRfcGFuZWxfdmRkIHx8ICFlZHBfaGF2ZV9wYW5lbF92ZGQo
aW50ZWxfZHApKQo+ICsJCXJldHVybjsKPiAgCj4gLQkJRFJNX0RFQlVHX0tNUygiVHVybmluZyBl
RFAgVkREIG9mZlxuIik7Cj4gKwlEUk1fREVCVUdfS01TKCJUdXJuaW5nIGVEUCBWREQgb2ZmXG4i
KTsKPiAgCj4gLQkJcHAgPSBpcm9ubGFrZV9nZXRfcHBfY29udHJvbChpbnRlbF9kcCk7Cj4gLQkJ
cHAgJj0gfkVEUF9GT1JDRV9WREQ7Cj4gKwlwcCA9IGlyb25sYWtlX2dldF9wcF9jb250cm9sKGlu
dGVsX2RwKTsKPiArCXBwICY9IH5FRFBfRk9SQ0VfVkREOwo+ICAKPiAtCQlwcF9jdHJsX3JlZyA9
IF9wcF9jdHJsX3JlZyhpbnRlbF9kcCk7Cj4gLQkJcHBfc3RhdF9yZWcgPSBfcHBfc3RhdF9yZWco
aW50ZWxfZHApOwo+ICsJcHBfY3RybF9yZWcgPSBfcHBfY3RybF9yZWcoaW50ZWxfZHApOwo+ICsJ
cHBfc3RhdF9yZWcgPSBfcHBfc3RhdF9yZWcoaW50ZWxfZHApOwo+ICAKPiAtCQlJOTE1X1dSSVRF
KHBwX2N0cmxfcmVnLCBwcCk7Cj4gLQkJUE9TVElOR19SRUFEKHBwX2N0cmxfcmVnKTsKPiArCUk5
MTVfV1JJVEUocHBfY3RybF9yZWcsIHBwKTsKPiArCVBPU1RJTkdfUkVBRChwcF9jdHJsX3JlZyk7
Cj4gIAo+IC0JCS8qIE1ha2Ugc3VyZSBzZXF1ZW5jZXIgaXMgaWRsZSBiZWZvcmUgYWxsb3dpbmcg
c3Vic2VxdWVudCBhY3Rpdml0eSAqLwo+IC0JCURSTV9ERUJVR19LTVMoIlBQX1NUQVRVUzogMHgl
MDh4IFBQX0NPTlRST0w6IDB4JTA4eFxuIiwKPiAtCQlJOTE1X1JFQUQocHBfc3RhdF9yZWcpLCBJ
OTE1X1JFQUQocHBfY3RybF9yZWcpKTsKPiArCS8qIE1ha2Ugc3VyZSBzZXF1ZW5jZXIgaXMgaWRs
ZSBiZWZvcmUgYWxsb3dpbmcgc3Vic2VxdWVudCBhY3Rpdml0eSAqLwo+ICsJRFJNX0RFQlVHX0tN
UygiUFBfU1RBVFVTOiAweCUwOHggUFBfQ09OVFJPTDogMHglMDh4XG4iLAo+ICsJSTkxNV9SRUFE
KHBwX3N0YXRfcmVnKSwgSTkxNV9SRUFEKHBwX2N0cmxfcmVnKSk7Cj4gIAo+IC0JCWlmICgocHAg
JiBQT1dFUl9UQVJHRVRfT04pID09IDApCj4gLQkJCWludGVsX2RwLT5sYXN0X3Bvd2VyX2N5Y2xl
ID0gamlmZmllczsKPiArCWlmICgocHAgJiBQT1dFUl9UQVJHRVRfT04pID09IDApCj4gKwkJaW50
ZWxfZHAtPmxhc3RfcG93ZXJfY3ljbGUgPSBqaWZmaWVzOwo+ICAKPiAtCQlwb3dlcl9kb21haW4g
PSBpbnRlbF9kaXNwbGF5X3BvcnRfcG93ZXJfZG9tYWluKGludGVsX2VuY29kZXIpOwo+IC0JCWlu
dGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBwb3dlcl9kb21haW4pOwo+IC0JfQo+ICsJ
cG93ZXJfZG9tYWluID0gaW50ZWxfZGlzcGxheV9wb3J0X3Bvd2VyX2RvbWFpbihpbnRlbF9lbmNv
ZGVyKTsKPiArCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBwb3dlcl9kb21haW4p
Owo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBlZHBfcGFuZWxfdmRkX3dvcmsoc3RydWN0IHdvcmtf
c3RydWN0ICpfX3dvcmspCj4gLS0gCj4gMS44LjUuNQo+Cj4gX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3Bl
biBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pbnRlbC1nZngK