From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Increase OpRegion timeout Date: Fri, 31 Jan 2014 13:42:26 +0200 Message-ID: <8738k44btp.fsf@intel.com> References: <1391160676-26766-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F869471B2 for ; Fri, 31 Jan 2014 03:39:06 -0800 (PST) In-Reply-To: <1391160676-26766-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Fri, 31 Jan 2014, Daniel Vetter wrote: > I have a machine here which hits this (a g33): > > [ 13.368536] excessive driver sleep timeout (DSPL) 1024 > > Apparently people love pot numbers, and one second isn't that > unreasonable (for a bios writer at least) I guess. Reviewed-by: Jani Nikula > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_opregion.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > index 3da259e280ba..3c7e38c7ed87 100644 > --- a/drivers/gpu/drm/i915/intel_opregion.c > +++ b/drivers/gpu/drm/i915/intel_opregion.c > @@ -261,10 +261,10 @@ static int swsci(struct drm_device *dev, u32 function, u32 parm, u32 *parm_out) > /* The spec says 2ms should be the default, but it's too small > * for some machines. */ > dslp = 50; > - } else if (dslp > 500) { > + } else if (dslp > 1500) { > /* Hey bios, trust must be earned. */ > WARN_ONCE(1, "excessive driver sleep timeout (DSPL) %u\n", dslp); > - dslp = 500; > + dslp = 1500; > } > > /* The spec tells us to do this, but we are the only user... */ > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center