From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F17FAC77B60 for ; Wed, 26 Apr 2023 21:52:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4852D10EA29; Wed, 26 Apr 2023 21:52:31 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3112C10E344; Wed, 26 Apr 2023 21:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682545948; x=1714081948; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=iKvfVHVFkHcZ5Hts7OeweHxnmgFMZkVjL5f8CvfDXcU=; b=ML6l9LMOYknGO/ywjiMRqw6kqhewp4LE8V0+YS2O9LIrf53xTWtWaXIM Z5YAdNYweZNXl3vGLIDkK1kLQpgTRsEZVvGz5S9eibuQJ2LNc4/+OrFFB 5hSXv1zPFXDRkUAlndR9FKtWEpNyf7AxFXHR8UlxRVZjqy4IygKEVxv6J NJXMkgZ6H5mWOHSKxj4zVitGbtVNulWEafGT9rqOUSo/hU9MIUKp5JXVl WPT0AVxF6E5UyKXit503J9JBI4yUvEbSbqfJcmCdK8IBLlSgQ0i9tOIpi kc3r6KuLzM6vtajRUnxEzVPiE9Fkr7If+muaZE+hUWg1ijRyQ4k9FJEGo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="327569348" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208";a="327569348" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 14:51:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="726724214" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208";a="726724214" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.242.96]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 14:51:48 -0700 Date: Wed, 26 Apr 2023 14:51:48 -0700 Message-ID: <874jp29urv.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: John.C.Harrison@Intel.com In-Reply-To: <20230425201926.99086-2-John.C.Harrison@Intel.com> References: <20230425201926.99086-1-John.C.Harrison@Intel.com> <20230425201926.99086-2-John.C.Harrison@Intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/intel_decode: Decode Gen12 ring/batch instructions correctly X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: IGT-Dev@Lists.FreeDesktop.Org, Intel-GFX@Lists.FreeDesktop.Org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 25 Apr 2023 13:19:25 -0700, John.C.Harrison@Intel.com wrote: > > @@ -3623,7 +3624,17 @@ decode_3d_965(struct intel_decode *ctx) > return len; > > case 0x7a00: > - if (IS_GEN6(devid) || IS_GEN7(devid)) { > + if (IS_GEN12(devid)) { > + if (len != 6) > + fprintf(out, "Bad count in PIPE_CONTROL\n"); > + instr_out(ctx, 0, "PIPE_CONTROL\n"); > + instr_out(ctx, 1, "flags\n"); > + instr_out(ctx, 2, "write address low\n"); > + instr_out(ctx, 3, "write address high\n"); > + instr_out(ctx, 4, "write data low\n"); > + instr_out(ctx, 5, "write data high\n"); > + return len; Is there a reference for this? I can review but have no idea what's going on here. The rest of the patch looks good. Thanks. > + } else if (IS_GEN6(devid) || IS_GEN7(devid)) { > if (len != 4 && len != 5) > fprintf(out, "Bad count in PIPE_CONTROL\n"); > > -- > 2.39.1 >