From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32CE4C54EBE for ; Fri, 13 Jan 2023 03:15:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D38D10E97E; Fri, 13 Jan 2023 03:15:53 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2335510E976; Fri, 13 Jan 2023 03:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673579751; x=1705115751; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=fauIMh1a8JxyObHiZM/vhMROykVGBJBayl+TQG0REmc=; b=btgSmZ5QVGWf43pL0q5Go/l4W31aVE77o1Dy2K8mtOG8vnS1y4F9eCnN 3U4nA/tLKJYPT2nA5kZZvW8MsmPnKoUaBPSeAXQC+L45LFsyMN6rrKphw 67mX8BYNnhKE9u+ayS8XISHkveGUCAaEUjv1a9tq7s10+czK4Nb6oiKGT Qelx8sBMxOaiVKx1kSbp3sbxSvu9BnSf4RIUh1C01Ysf9HBdf604m+vDu A2r+0NmkThwX50mm6Oh0jPDoB3RhQIBOAnjcNvzXzukofga0+046Zmvxg K08NdEhKNmD+h6hbsLgPtEkm0AkmwhqhUvVMAlSwnx9kL/OeAO+M9Pe55 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="303600484" X-IronPort-AV: E=Sophos;i="5.97,212,1669104000"; d="scan'208";a="303600484" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 19:15:50 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="765865858" X-IronPort-AV: E=Sophos;i="5.97,212,1669104000"; d="scan'208";a="765865858" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.45.230]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 19:15:50 -0800 Date: Thu, 12 Jan 2023 19:15:45 -0800 Message-ID: <874jsvazvi.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20230113022752.3151066-1-vinay.belgaumkar@intel.com> References: <20230113022752.3151066-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Andi Shyti , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 12 Jan 2023 18:27:52 -0800, Vinay Belgaumkar wrote: > > Reading current root sysfs entries gives a min/max of all > GTs. Updating this so we return default (GT0) values when root > level sysfs entries are accessed, instead of min/max for the card. > Tests that are not multi GT capable will read incorrect sysfs > values without this change on multi-GT platforms like MTL. > > Fixes: a8a4f0467d70 ("drm/i915: Fix CFI violations in gt_sysfs") We seem to be proposing to change the previous sysfs ABI with this patch? But even then it doesn't seem correct to use gt0 values for device level sysfs. Actually I received the following comment about using max freq across gt's for device level freq's (gt_act_freq_mhz etc.) from one of our users: ----- On Sun, 06 Nov 2022 08:54:04 -0800, Lawson, Lowren H wrote: Why show maximum? Wouldn=A2t average be more accurate to the user experienc= e? As a user, I expect the =A1card=A2 frequency to be relatively accurate to t= he entire card. If I see 1.6GHz, but the card is behaving as if it=A2s running= a 1.0 & 1.6GHz on the different compute tiles, I=A2m going to see a massive decrease in compute workload performance while at =A1maximum=A2 frequency. ----- So I am not sure why max/min were previously chosen. Why not the average? Thanks. -- Ashutosh