Re: [PATCH 4/4] warn

Chris Wilson
2017-10-24T15:01:53Z

Quoting Mika Kuoppala (2017-10-24 15:46:27)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > ---
> > drivers/gpu/drm/i915/i915_irq.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> > index f8205841868b..e4bd20ce031d 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -1391,6 +1391,9 @@ gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift)
> > if (READ_ONCE(engine->execlists.active)) {
> > __set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted);
> > tasklet = true;
> > + } else if (WARN_ON(!engine->i915->gt.awake)) {
>
> READ_ONCE

Sure. Too bad this patch is just a figment of your imagination.

Pushed the rest, hopefully ending the plague of random deaths.
Thanks for the review,
-Chris