From: Jani Nikula <jani.nikula@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Ville Syrjala <ville.syrjala@intel.com>
Subject: Re: [PATCH v2 4/5] drm/i915: Wrap access to module params into macro
Date: Thu, 14 Sep 2017 16:10:22 +0300 [thread overview]
Message-ID: <874ls5ify9.fsf@nikula.org> (raw)
In-Reply-To: <20170914115413.2620-5-michal.wajdeczko@intel.com>
On Thu, 14 Sep 2017, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> @@ -1031,9 +1031,9 @@ static void i915_driver_cleanup_mmio(struct drm_i915_private *dev_priv)
>
> static void intel_sanitize_options(struct drm_i915_private *dev_priv)
> {
> - i915.enable_execlists =
> + i915_param(enable_execlists) =
I disapprove using a function-like macro expansion as an lvalue. If you
want to use a getter macro, also provide a setter, and use them
separately.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-14 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 11:54 [PATCH v2 0/5] drm/i915: Rename global i915 to i915_params Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 1/5] drm/i915: Rename lvds_use_ssc modparam to panel_use_ssc Michal Wajdeczko
2017-09-14 12:25 ` Ville Syrjälä
2017-09-14 11:54 ` [PATCH v2 2/5] drm/i915: Introduce custom variant of module_param_named macro Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 3/5] drm/i915: Extend private i915_param_named macro with description Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 4/5] drm/i915: Wrap access to module params into macro Michal Wajdeczko
2017-09-14 13:10 ` Jani Nikula [this message]
2017-09-14 14:03 ` Michal Wajdeczko
2017-09-14 11:54 ` [PATCH v2 5/5] drm/i915: Rename global i915 to i915_params Michal Wajdeczko
2017-09-14 12:13 ` ✓ Fi.CI.BAT: success for drm/i915: Rename global i915 to i915_params (rev2) Patchwork
2017-09-14 13:21 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ls5ify9.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox