intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
@ 2016-11-08 17:21 Paulo Zanoni
  2016-11-08 18:15 ` ✓ Fi.CI.BAT: success for " Patchwork
  2016-11-09  1:13 ` [PATCH] " Matt Roper
  0 siblings, 2 replies; 6+ messages in thread
From: Paulo Zanoni @ 2016-11-08 17:21 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, Paulo Zanoni

One of the memsets was added by 5a920b85f2c6 ("drm/i915/gen9: fix DDB
partitioning for multi-screen cases"), and the other was added by
01c72d6c17 ("drm/i915/gen9: fix DDB partitioning for multi-screen
cases"). I'm confused and I'll let the maintainers find out what went
wrong here.

Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 88e28c9..cc9e0c0 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3411,10 +3411,6 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *cstate,
 	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
 	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
 
-	/* Clear the partitioning for disabled planes. */
-	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
-	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
-
 	if (WARN_ON(!state))
 		return 0;
 
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
  2016-11-08 17:21 [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb() Paulo Zanoni
@ 2016-11-08 18:15 ` Patchwork
  2016-11-09  1:13 ` [PATCH] " Matt Roper
  1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2016-11-08 18:15 UTC (permalink / raw)
  To: Paulo Zanoni; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
URL   : https://patchwork.freedesktop.org/series/14984/
State : success

== Summary ==

Series 14984v1 drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
https://patchwork.freedesktop.org/api/1.0/series/14984/revisions/1/mbox/

Test drv_module_reload_basic:
                dmesg-warn -> PASS       (fi-skl-6770hq)

fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

9435ffb9ffbfecfa5a429a46af96b1b3fda41d6c drm-intel-nightly: 2016y-11m-08d-13h-53m-48s UTC integration manifest
af272ef drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2936/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
  2016-11-08 17:21 [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb() Paulo Zanoni
  2016-11-08 18:15 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2016-11-09  1:13 ` Matt Roper
  2016-11-09  9:27   ` Jani Nikula
  1 sibling, 1 reply; 6+ messages in thread
From: Matt Roper @ 2016-11-09  1:13 UTC (permalink / raw)
  To: Paulo Zanoni; +Cc: Jani Nikula, intel-gfx

On Tue, Nov 08, 2016 at 03:21:22PM -0200, Paulo Zanoni wrote:
> One of the memsets was added by 5a920b85f2c6 ("drm/i915/gen9: fix DDB
> partitioning for multi-screen cases"), and the other was added by
> 01c72d6c17 ("drm/i915/gen9: fix DDB partitioning for multi-screen
> cases"). I'm confused and I'll let the maintainers find out what went
> wrong here.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I think this is just an artifact of having the patch in both -next and
-fixes.  The context probably changed later in -next causing a conflict
when the two were merged, and then the merge resolution accidentally
duplicated this hunk.  The merge commit ac4139ed7 is where we wound up
with the two copies:

        diff --cc drivers/gpu/drm/i915/intel_pm.c
        index db24f89,cc9e0c0..88e28c9
        --- a/drivers/gpu/drm/i915/intel_pm.c
        +++ b/drivers/gpu/drm/i915/intel_pm.c
        @@@ -3361,11 -3404,13 +3404,17 @@@ skl_allocate_pipe_ddb(struct intel_crtc
                unsigned int total_data_rate;
                int num_active;
                int id, i;
        +       unsigned plane_data_rate[I915_MAX_PLANES] = {};
        +       unsigned plane_y_data_rate[I915_MAX_PLANES] = {};
        + 
        +       /* Clear the partitioning for disabled planes. */
        +       memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
        +       memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
          
         +      /* Clear the partitioning for disabled planes. */
         +      memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
         +      memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
         +
                if (WARN_ON(!state))
                        return 0;
          
Dropping one looks good to me.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 88e28c9..cc9e0c0 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3411,10 +3411,6 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *cstate,
>  	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>  	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>  
> -	/* Clear the partitioning for disabled planes. */
> -	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
> -	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
> -
>  	if (WARN_ON(!state))
>  		return 0;
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
  2016-11-09  1:13 ` [PATCH] " Matt Roper
@ 2016-11-09  9:27   ` Jani Nikula
  2016-11-09 17:38     ` Matt Roper
  0 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2016-11-09  9:27 UTC (permalink / raw)
  To: Matt Roper, Paulo Zanoni; +Cc: Vetter, Daniel, intel-gfx

On Wed, 09 Nov 2016, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Tue, Nov 08, 2016 at 03:21:22PM -0200, Paulo Zanoni wrote:
>> One of the memsets was added by 5a920b85f2c6 ("drm/i915/gen9: fix DDB
>> partitioning for multi-screen cases"), and the other was added by
>> 01c72d6c17 ("drm/i915/gen9: fix DDB partitioning for multi-screen
>> cases"). I'm confused and I'll let the maintainers find out what went
>> wrong here.
>> 
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> I think this is just an artifact of having the patch in both -next and
> -fixes.  The context probably changed later in -next causing a conflict
> when the two were merged, and then the merge resolution accidentally
> duplicated this hunk.  The merge commit ac4139ed7 is where we wound up
> with the two copies:

I don't have that merge commit. Is that a nightly rebuild?

I don't think we even have this issue in anywhere other than
nightly. There isn't a branch we could apply this fix to.

BR,
Jani.


>
>         diff --cc drivers/gpu/drm/i915/intel_pm.c
>         index db24f89,cc9e0c0..88e28c9
>         --- a/drivers/gpu/drm/i915/intel_pm.c
>         +++ b/drivers/gpu/drm/i915/intel_pm.c
>         @@@ -3361,11 -3404,13 +3404,17 @@@ skl_allocate_pipe_ddb(struct intel_crtc
>                 unsigned int total_data_rate;
>                 int num_active;
>                 int id, i;
>         +       unsigned plane_data_rate[I915_MAX_PLANES] = {};
>         +       unsigned plane_y_data_rate[I915_MAX_PLANES] = {};
>         + 
>         +       /* Clear the partitioning for disabled planes. */
>         +       memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>         +       memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>           
>          +      /* Clear the partitioning for disabled planes. */
>          +      memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>          +      memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>          +
>                 if (WARN_ON(!state))
>                         return 0;
>           
> Dropping one looks good to me.
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>> ---
>>  drivers/gpu/drm/i915/intel_pm.c | 4 ----
>>  1 file changed, 4 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 88e28c9..cc9e0c0 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -3411,10 +3411,6 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *cstate,
>>  	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>>  	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>>  
>> -	/* Clear the partitioning for disabled planes. */
>> -	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>> -	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>> -
>>  	if (WARN_ON(!state))
>>  		return 0;
>>  
>> -- 
>> 2.7.4
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
  2016-11-09  9:27   ` Jani Nikula
@ 2016-11-09 17:38     ` Matt Roper
  2016-11-10 10:03       ` Jani Nikula
  0 siblings, 1 reply; 6+ messages in thread
From: Matt Roper @ 2016-11-09 17:38 UTC (permalink / raw)
  To: Jani Nikula; +Cc: Vetter, Daniel, intel-gfx, Paulo Zanoni

On Wed, Nov 09, 2016 at 11:27:37AM +0200, Jani Nikula wrote:
> On Wed, 09 Nov 2016, Matt Roper <matthew.d.roper@intel.com> wrote:
> > On Tue, Nov 08, 2016 at 03:21:22PM -0200, Paulo Zanoni wrote:
> >> One of the memsets was added by 5a920b85f2c6 ("drm/i915/gen9: fix DDB
> >> partitioning for multi-screen cases"), and the other was added by
> >> 01c72d6c17 ("drm/i915/gen9: fix DDB partitioning for multi-screen
> >> cases"). I'm confused and I'll let the maintainers find out what went
> >> wrong here.
> >> 
> >> Cc: Jani Nikula <jani.nikula@intel.com>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > I think this is just an artifact of having the patch in both -next and
> > -fixes.  The context probably changed later in -next causing a conflict
> > when the two were merged, and then the merge resolution accidentally
> > duplicated this hunk.  The merge commit ac4139ed7 is where we wound up
> > with the two copies:
> 
> I don't have that merge commit. Is that a nightly rebuild?

Yeah, it's part of a nightly rebuild.  Looks like
82282577545 is the equivalent now.

> I don't think we even have this issue in anywhere other than
> nightly. There isn't a branch we could apply this fix to.

Yeah, the patch can't apply anywhere directly, but I thought we could
make rerere forget its resolution of intel_pm.c for that merge and then
fix it by hand so that future merges behave correctly?


Matt


> 
> BR,
> Jani.
> 
> 
> >
> >         diff --cc drivers/gpu/drm/i915/intel_pm.c
> >         index db24f89,cc9e0c0..88e28c9
> >         --- a/drivers/gpu/drm/i915/intel_pm.c
> >         +++ b/drivers/gpu/drm/i915/intel_pm.c
> >         @@@ -3361,11 -3404,13 +3404,17 @@@ skl_allocate_pipe_ddb(struct intel_crtc
> >                 unsigned int total_data_rate;
> >                 int num_active;
> >                 int id, i;
> >         +       unsigned plane_data_rate[I915_MAX_PLANES] = {};
> >         +       unsigned plane_y_data_rate[I915_MAX_PLANES] = {};
> >         + 
> >         +       /* Clear the partitioning for disabled planes. */
> >         +       memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
> >         +       memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
> >           
> >          +      /* Clear the partitioning for disabled planes. */
> >          +      memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
> >          +      memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
> >          +
> >                 if (WARN_ON(!state))
> >                         return 0;
> >           
> > Dropping one looks good to me.
> >
> > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> >
> >> ---
> >>  drivers/gpu/drm/i915/intel_pm.c | 4 ----
> >>  1 file changed, 4 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> >> index 88e28c9..cc9e0c0 100644
> >> --- a/drivers/gpu/drm/i915/intel_pm.c
> >> +++ b/drivers/gpu/drm/i915/intel_pm.c
> >> @@ -3411,10 +3411,6 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *cstate,
> >>  	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
> >>  	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
> >>  
> >> -	/* Clear the partitioning for disabled planes. */
> >> -	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
> >> -	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
> >> -
> >>  	if (WARN_ON(!state))
> >>  		return 0;
> >>  
> >> -- 
> >> 2.7.4
> >> 
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb()
  2016-11-09 17:38     ` Matt Roper
@ 2016-11-10 10:03       ` Jani Nikula
  0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2016-11-10 10:03 UTC (permalink / raw)
  To: Matt Roper; +Cc: Vetter, Daniel, intel-gfx, Paulo Zanoni

On Wed, 09 Nov 2016, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Wed, Nov 09, 2016 at 11:27:37AM +0200, Jani Nikula wrote:
>> On Wed, 09 Nov 2016, Matt Roper <matthew.d.roper@intel.com> wrote:
>> > On Tue, Nov 08, 2016 at 03:21:22PM -0200, Paulo Zanoni wrote:
>> >> One of the memsets was added by 5a920b85f2c6 ("drm/i915/gen9: fix DDB
>> >> partitioning for multi-screen cases"), and the other was added by
>> >> 01c72d6c17 ("drm/i915/gen9: fix DDB partitioning for multi-screen
>> >> cases"). I'm confused and I'll let the maintainers find out what went
>> >> wrong here.
>> >> 
>> >> Cc: Jani Nikula <jani.nikula@intel.com>
>> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> >
>> > I think this is just an artifact of having the patch in both -next and
>> > -fixes.  The context probably changed later in -next causing a conflict
>> > when the two were merged, and then the merge resolution accidentally
>> > duplicated this hunk.  The merge commit ac4139ed7 is where we wound up
>> > with the two copies:
>> 
>> I don't have that merge commit. Is that a nightly rebuild?
>
> Yeah, it's part of a nightly rebuild.  Looks like
> 82282577545 is the equivalent now.
>
>> I don't think we even have this issue in anywhere other than
>> nightly. There isn't a branch we could apply this fix to.
>
> Yeah, the patch can't apply anywhere directly, but I thought we could
> make rerere forget its resolution of intel_pm.c for that merge and then
> fix it by hand so that future merges behave correctly?

Only if it was a manual fixup that went wrong. For silent conflicts, we
need to add a fixup patch for the merge.

BR,
Jani.


>
>
> Matt
>
>
>> 
>> BR,
>> Jani.
>> 
>> 
>> >
>> >         diff --cc drivers/gpu/drm/i915/intel_pm.c
>> >         index db24f89,cc9e0c0..88e28c9
>> >         --- a/drivers/gpu/drm/i915/intel_pm.c
>> >         +++ b/drivers/gpu/drm/i915/intel_pm.c
>> >         @@@ -3361,11 -3404,13 +3404,17 @@@ skl_allocate_pipe_ddb(struct intel_crtc
>> >                 unsigned int total_data_rate;
>> >                 int num_active;
>> >                 int id, i;
>> >         +       unsigned plane_data_rate[I915_MAX_PLANES] = {};
>> >         +       unsigned plane_y_data_rate[I915_MAX_PLANES] = {};
>> >         + 
>> >         +       /* Clear the partitioning for disabled planes. */
>> >         +       memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>> >         +       memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>> >           
>> >          +      /* Clear the partitioning for disabled planes. */
>> >          +      memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>> >          +      memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>> >          +
>> >                 if (WARN_ON(!state))
>> >                         return 0;
>> >           
>> > Dropping one looks good to me.
>> >
>> > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>> >
>> >> ---
>> >>  drivers/gpu/drm/i915/intel_pm.c | 4 ----
>> >>  1 file changed, 4 deletions(-)
>> >> 
>> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> >> index 88e28c9..cc9e0c0 100644
>> >> --- a/drivers/gpu/drm/i915/intel_pm.c
>> >> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> >> @@ -3411,10 +3411,6 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *cstate,
>> >>  	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>> >>  	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>> >>  
>> >> -	/* Clear the partitioning for disabled planes. */
>> >> -	memset(ddb->plane[pipe], 0, sizeof(ddb->plane[pipe]));
>> >> -	memset(ddb->y_plane[pipe], 0, sizeof(ddb->y_plane[pipe]));
>> >> -
>> >>  	if (WARN_ON(!state))
>> >>  		return 0;
>> >>  
>> >> -- 
>> >> 2.7.4
>> >> 
>> >> _______________________________________________
>> >> Intel-gfx mailing list
>> >> Intel-gfx@lists.freedesktop.org
>> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> 
>> -- 
>> Jani Nikula, Intel Open Source Technology Center

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-11-10 10:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-08 17:21 [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb() Paulo Zanoni
2016-11-08 18:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-09  1:13 ` [PATCH] " Matt Roper
2016-11-09  9:27   ` Jani Nikula
2016-11-09 17:38     ` Matt Roper
2016-11-10 10:03       ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).