From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb() Date: Thu, 10 Nov 2016 12:03:27 +0200 Message-ID: <874m3ffy8g.fsf@intel.com> References: <1478625682-8955-1-git-send-email-paulo.r.zanoni@intel.com> <20161109011315.GF6536@intel.com> <87eg2lgfzq.fsf@intel.com> <20161109173825.GL6536@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 582B86E7A6 for ; Thu, 10 Nov 2016 10:03:30 +0000 (UTC) In-Reply-To: <20161109173825.GL6536@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: "Vetter, Daniel" , intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAwOSBOb3YgMjAxNiwgTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNv bT4gd3JvdGU6Cj4gT24gV2VkLCBOb3YgMDksIDIwMTYgYXQgMTE6Mjc6MzdBTSArMDIwMCwgSmFu aSBOaWt1bGEgd3JvdGU6Cj4+IE9uIFdlZCwgMDkgTm92IDIwMTYsIE1hdHQgUm9wZXIgPG1hdHRo ZXcuZC5yb3BlckBpbnRlbC5jb20+IHdyb3RlOgo+PiA+IE9uIFR1ZSwgTm92IDA4LCAyMDE2IGF0 IDAzOjIxOjIyUE0gLTAyMDAsIFBhdWxvIFphbm9uaSB3cm90ZToKPj4gPj4gT25lIG9mIHRoZSBt ZW1zZXRzIHdhcyBhZGRlZCBieSA1YTkyMGI4NWYyYzYgKCJkcm0vaTkxNS9nZW45OiBmaXggRERC Cj4+ID4+IHBhcnRpdGlvbmluZyBmb3IgbXVsdGktc2NyZWVuIGNhc2VzIiksIGFuZCB0aGUgb3Ro ZXIgd2FzIGFkZGVkIGJ5Cj4+ID4+IDAxYzcyZDZjMTcgKCJkcm0vaTkxNS9nZW45OiBmaXggRERC IHBhcnRpdGlvbmluZyBmb3IgbXVsdGktc2NyZWVuCj4+ID4+IGNhc2VzIikuIEknbSBjb25mdXNl ZCBhbmQgSSdsbCBsZXQgdGhlIG1haW50YWluZXJzIGZpbmQgb3V0IHdoYXQgd2VudAo+PiA+PiB3 cm9uZyBoZXJlLgo+PiA+PiAKPj4gPj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRl bC5jb20+Cj4+ID4+IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlA aW50ZWwuY29tPgo+PiA+Cj4+ID4gSSB0aGluayB0aGlzIGlzIGp1c3QgYW4gYXJ0aWZhY3Qgb2Yg aGF2aW5nIHRoZSBwYXRjaCBpbiBib3RoIC1uZXh0IGFuZAo+PiA+IC1maXhlcy4gIFRoZSBjb250 ZXh0IHByb2JhYmx5IGNoYW5nZWQgbGF0ZXIgaW4gLW5leHQgY2F1c2luZyBhIGNvbmZsaWN0Cj4+ ID4gd2hlbiB0aGUgdHdvIHdlcmUgbWVyZ2VkLCBhbmQgdGhlbiB0aGUgbWVyZ2UgcmVzb2x1dGlv biBhY2NpZGVudGFsbHkKPj4gPiBkdXBsaWNhdGVkIHRoaXMgaHVuay4gIFRoZSBtZXJnZSBjb21t aXQgYWM0MTM5ZWQ3IGlzIHdoZXJlIHdlIHdvdW5kIHVwCj4+ID4gd2l0aCB0aGUgdHdvIGNvcGll czoKPj4gCj4+IEkgZG9uJ3QgaGF2ZSB0aGF0IG1lcmdlIGNvbW1pdC4gSXMgdGhhdCBhIG5pZ2h0 bHkgcmVidWlsZD8KPgo+IFllYWgsIGl0J3MgcGFydCBvZiBhIG5pZ2h0bHkgcmVidWlsZC4gIExv b2tzIGxpa2UKPiA4MjI4MjU3NzU0NSBpcyB0aGUgZXF1aXZhbGVudCBub3cuCj4KPj4gSSBkb24n dCB0aGluayB3ZSBldmVuIGhhdmUgdGhpcyBpc3N1ZSBpbiBhbnl3aGVyZSBvdGhlciB0aGFuCj4+ IG5pZ2h0bHkuIFRoZXJlIGlzbid0IGEgYnJhbmNoIHdlIGNvdWxkIGFwcGx5IHRoaXMgZml4IHRv Lgo+Cj4gWWVhaCwgdGhlIHBhdGNoIGNhbid0IGFwcGx5IGFueXdoZXJlIGRpcmVjdGx5LCBidXQg SSB0aG91Z2h0IHdlIGNvdWxkCj4gbWFrZSByZXJlcmUgZm9yZ2V0IGl0cyByZXNvbHV0aW9uIG9m IGludGVsX3BtLmMgZm9yIHRoYXQgbWVyZ2UgYW5kIHRoZW4KPiBmaXggaXQgYnkgaGFuZCBzbyB0 aGF0IGZ1dHVyZSBtZXJnZXMgYmVoYXZlIGNvcnJlY3RseT8KCk9ubHkgaWYgaXQgd2FzIGEgbWFu dWFsIGZpeHVwIHRoYXQgd2VudCB3cm9uZy4gRm9yIHNpbGVudCBjb25mbGljdHMsIHdlCm5lZWQg dG8gYWRkIGEgZml4dXAgcGF0Y2ggZm9yIHRoZSBtZXJnZS4KCkJSLApKYW5pLgoKCj4KPgo+IE1h dHQKPgo+Cj4+IAo+PiBCUiwKPj4gSmFuaS4KPj4gCj4+IAo+PiA+Cj4+ID4gICAgICAgICBkaWZm IC0tY2MgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiA+ICAgICAgICAgaW5kZXgg ZGIyNGY4OSxjYzllMGMwLi44OGUyOGM5Cj4+ID4gICAgICAgICAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wbS5jCj4+ID4gICAgICAgICArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wbS5jCj4+ID4gICAgICAgICBAQEAgLTMzNjEsMTEgLTM0MDQsMTMgKzM0MDQsMTcg QEBAIHNrbF9hbGxvY2F0ZV9waXBlX2RkYihzdHJ1Y3QgaW50ZWxfY3J0Ywo+PiA+ICAgICAgICAg ICAgICAgICB1bnNpZ25lZCBpbnQgdG90YWxfZGF0YV9yYXRlOwo+PiA+ICAgICAgICAgICAgICAg ICBpbnQgbnVtX2FjdGl2ZTsKPj4gPiAgICAgICAgICAgICAgICAgaW50IGlkLCBpOwo+PiA+ICAg ICAgICAgKyAgICAgICB1bnNpZ25lZCBwbGFuZV9kYXRhX3JhdGVbSTkxNV9NQVhfUExBTkVTXSA9 IHt9Owo+PiA+ICAgICAgICAgKyAgICAgICB1bnNpZ25lZCBwbGFuZV95X2RhdGFfcmF0ZVtJOTE1 X01BWF9QTEFORVNdID0ge307Cj4+ID4gICAgICAgICArIAo+PiA+ICAgICAgICAgKyAgICAgICAv KiBDbGVhciB0aGUgcGFydGl0aW9uaW5nIGZvciBkaXNhYmxlZCBwbGFuZXMuICovCj4+ID4gICAg ICAgICArICAgICAgIG1lbXNldChkZGItPnBsYW5lW3BpcGVdLCAwLCBzaXplb2YoZGRiLT5wbGFu ZVtwaXBlXSkpOwo+PiA+ICAgICAgICAgKyAgICAgICBtZW1zZXQoZGRiLT55X3BsYW5lW3BpcGVd LCAwLCBzaXplb2YoZGRiLT55X3BsYW5lW3BpcGVdKSk7Cj4+ID4gICAgICAgICAgIAo+PiA+ICAg ICAgICAgICsgICAgICAvKiBDbGVhciB0aGUgcGFydGl0aW9uaW5nIGZvciBkaXNhYmxlZCBwbGFu ZXMuICovCj4+ID4gICAgICAgICAgKyAgICAgIG1lbXNldChkZGItPnBsYW5lW3BpcGVdLCAwLCBz aXplb2YoZGRiLT5wbGFuZVtwaXBlXSkpOwo+PiA+ICAgICAgICAgICsgICAgICBtZW1zZXQoZGRi LT55X3BsYW5lW3BpcGVdLCAwLCBzaXplb2YoZGRiLT55X3BsYW5lW3BpcGVdKSk7Cj4+ID4gICAg ICAgICAgKwo+PiA+ICAgICAgICAgICAgICAgICBpZiAoV0FSTl9PTighc3RhdGUpKQo+PiA+ICAg ICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAwOwo+PiA+ICAgICAgICAgICAKPj4gPiBEcm9w cGluZyBvbmUgbG9va3MgZ29vZCB0byBtZS4KPj4gPgo+PiA+IFJldmlld2VkLWJ5OiBNYXR0IFJv cGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+PiA+Cj4+ID4+IC0tLQo+PiA+PiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDQgLS0tLQo+PiA+PiAgMSBmaWxlIGNoYW5n ZWQsIDQgZGVsZXRpb25zKC0pCj4+ID4+IAo+PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4g Pj4gaW5kZXggODhlMjhjOS4uY2M5ZTBjMCAxMDA2NDQKPj4gPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jCj4+ID4+IEBAIC0zNDExLDEwICszNDExLDYgQEAgc2tsX2FsbG9jYXRlX3BpcGVfZGRi KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4+ID4+ICAJbWVtc2V0KGRkYi0+cGxh bmVbcGlwZV0sIDAsIHNpemVvZihkZGItPnBsYW5lW3BpcGVdKSk7Cj4+ID4+ICAJbWVtc2V0KGRk Yi0+eV9wbGFuZVtwaXBlXSwgMCwgc2l6ZW9mKGRkYi0+eV9wbGFuZVtwaXBlXSkpOwo+PiA+PiAg Cj4+ID4+IC0JLyogQ2xlYXIgdGhlIHBhcnRpdGlvbmluZyBmb3IgZGlzYWJsZWQgcGxhbmVzLiAq Lwo+PiA+PiAtCW1lbXNldChkZGItPnBsYW5lW3BpcGVdLCAwLCBzaXplb2YoZGRiLT5wbGFuZVtw aXBlXSkpOwo+PiA+PiAtCW1lbXNldChkZGItPnlfcGxhbmVbcGlwZV0sIDAsIHNpemVvZihkZGIt PnlfcGxhbmVbcGlwZV0pKTsKPj4gPj4gLQo+PiA+PiAgCWlmIChXQVJOX09OKCFzdGF0ZSkpCj4+ ID4+ICAJCXJldHVybiAwOwo+PiA+PiAgCj4+ID4+IC0tIAo+PiA+PiAyLjcuNAo+PiA+PiAKPj4g Pj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gPj4g SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiA+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4+ID4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cj4+IAo+PiAtLSAKPj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRl Y2hub2xvZ3kgQ2VudGVyCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hu b2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=