From: Jani Nikula <jani.nikula@intel.com>
To: Jim Bride <jim.bride@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/i915: make intel_dp_compute_bpp static
Date: Fri, 16 Sep 2016 10:45:18 +0300 [thread overview]
Message-ID: <874m5gp9td.fsf@intel.com> (raw)
In-Reply-To: <20160915143551.GA11219@shiv>
On Thu, 15 Sep 2016, Jim Bride <jim.bride@linux.intel.com> wrote:
> On Thu, Sep 15, 2016 at 04:28:52PM +0300, Jani Nikula wrote:
>> Fix sparse warning:
>>
>> drivers/gpu/drm/i915/intel_dp.c:1527:5: warning: symbol
>> 'intel_dp_compute_bpp' was not declared. Should it be static?
>>
>> Fixes: f9bb705e65f6 ("drm/i915: Update bits per component for display info")
>> Cc: Mika Kahola <mika.kahola@intel.com>
>> Cc: Jim Bride <jim.bride@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Jim Bride <jim.bride@linux.intel.com>
Thanks, pushed patches 1, 2 and 4. Waiting review on the others.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_dp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 69cee9b0a08d..acd0c51f74d5 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
>> }
>> }
>>
>> -int intel_dp_compute_bpp(struct intel_dp *intel_dp,
>> - struct intel_crtc_state *pipe_config)
>> +static int intel_dp_compute_bpp(struct intel_dp *intel_dp,
>> + struct intel_crtc_state *pipe_config)
>> {
>> int bpp, bpc;
>>
>> --
>> 2.1.4
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-09-16 7:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 13:28 [PATCH 1/6] drm/i915: make intel_dp_compute_bpp static Jani Nikula
2016-09-15 13:28 ` [PATCH 2/6] drm/i915: do not use 'false' as a NULL pointer Jani Nikula
2016-09-15 17:13 ` Pandiyan, Dhinakaran
2016-09-15 13:28 ` [PATCH 3/6] drm/i915: keep declarations in i915_drv.h Jani Nikula
2016-09-19 16:14 ` Joonas Lahtinen
2016-09-20 8:57 ` Jani Nikula
2016-09-20 9:29 ` Chris Wilson
2016-09-20 9:58 ` Jani Nikula
2016-09-22 11:50 ` Daniel Vetter
2016-09-22 12:11 ` Jani Nikula
2016-09-26 6:32 ` Joonas Lahtinen
2016-09-15 13:28 ` [PATCH 4/6] drm/i915: use NULL for NULL pointers Jani Nikula
2016-09-15 17:09 ` Pandiyan, Dhinakaran
2016-09-15 13:28 ` [PATCH 5/6] drm/i915: workaround sparse warning on variable length arrays Jani Nikula
2016-09-15 13:28 ` [PATCH 6/6] drm/i915: silence io mapping/unmapping sparse warnings on different address spaces Jani Nikula
2016-09-15 13:49 ` ✗ Fi.CI.BAT: warning for series starting with [1/6] drm/i915: make intel_dp_compute_bpp static Patchwork
2016-09-15 14:35 ` [PATCH 1/6] " Jim Bride
2016-09-16 7:45 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m5gp9td.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jim.bride@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).