From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/3] drm/i915: Clean up hsw_audio_codec_enable() Date: Thu, 11 Aug 2016 11:04:28 +0300 Message-ID: <874m6rwx2r.fsf@intel.com> References: <20160809220857.GA29783@nuc-i3427.alporthouse.com> <1470897673-29292-1-git-send-email-dhinakaran.pandiyan@intel.com> <87a8gjwxvp.fsf@intel.com> <20160811075442.GE12148@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 6412F6E8F0 for ; Thu, 11 Aug 2016 08:04:30 +0000 (UTC) In-Reply-To: <20160811075442.GE12148@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxMSBBdWcgMjAxNiwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IE9uIFRodSwgQXVnIDExLCAyMDE2IGF0IDEwOjQ3OjA2QU0gKzAzMDAsIEph bmkgTmlrdWxhIHdyb3RlOgo+PiBPbiBUaHUsIDExIEF1ZyAyMDE2LCBEaGluYWthcmFuIFBhbmRp eWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4gd3JvdGU6Cj4+ID4gTm8gZnVuY3Rp b25hbCBjaGFuZ2UsIGNvZGUgY2xlYW4gdXAgYW5kIGltcHJvdmVkIGRlYnVnLgo+PiA+Cj4+ID4g Q2hyaXMgc3VnZ2VzdGVkIHRoaXMgY29kZSBzbmlwcGV0IHdoaWxlIHJldmlld2luZywgSSBqdXN0 IG1hZGUgdGhpcyBpbnRvIGEKPj4gPiBwYXRjaC4KPj4gPgo+PiA+IENyZWRpdHMtdG86IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiA+IENjOiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFu IFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPj4gPiAtLS0KPj4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYyB8IDI4ICsrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLS0KPj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDE2IGRl bGV0aW9ucygtKQo+PiA+Cj4+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2F1ZGlvLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jCj4+ID4gaW5k ZXggZDMyZjU4Ni4uM2VmY2UwZSAxMDA2NDQKPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9hdWRpby5jCj4+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVk aW8uYwo+PiA+IEBAIC0yODIsMTQgKzI4Miw5IEBAIHN0YXRpYyB2b2lkIGhzd19hdWRpb19jb2Rl Y19lbmFibGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gPiAgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5kZXYpOwo+PiA+ ICAJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGVuY29kZXIt PmJhc2UuY3J0Yyk7Cj4+ID4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4+ ID4gLQlzdHJ1Y3QgaTkxNV9hdWRpb19jb21wb25lbnQgKmFjb21wID0gZGV2X3ByaXYtPmF1ZGlv X2NvbXBvbmVudDsKPj4gPiAgCWNvbnN0IHVpbnQ4X3QgKmVsZCA9IGNvbm5lY3Rvci0+ZWxkOwo+ PiA+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPQo+PiA+IC0J CWVuY190b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4+ID4gLQllbnVtIHBvcnQgcG9ydCA9 IGludGVsX2RpZ19wb3J0LT5wb3J0Owo+PiA+ICAJdWludDMyX3QgdG1wOwo+PiA+ICAJaW50IGxl biwgaTsKPj4gPiAtCWludCBuLCByYXRlOwo+PiA+ICAKPj4gPiAgCURSTV9ERUJVR19LTVMoIkVu YWJsZSBhdWRpbyBjb2RlYyBvbiBwaXBlICVjLCAldSBieXRlcyBFTERcbiIsCj4+ID4gIAkJICAg ICAgcGlwZV9uYW1lKHBpcGUpLCBkcm1fZWxkX3NpemUoZWxkKSk7Cj4+ID4gQEAgLTMzNSwxOSAr MzMwLDIwIEBAIHN0YXRpYyB2b2lkIGhzd19hdWRpb19jb2RlY19lbmFibGUoc3RydWN0IGRybV9j b25uZWN0b3IgKmNvbm5lY3RvciwKPj4gPiAgCj4+ID4gIAl0bXAgJj0gfkFVRF9DT05GSUdfTl9Q Uk9HX0VOQUJMRTsKPj4gPiAgCWlmIChhdWRpb19yYXRlX25lZWRfcHJvZyhpbnRlbF9jcnRjLCBh ZGp1c3RlZF9tb2RlKSkgewo+PiA+IC0JCWlmICghYWNvbXApCj4+ID4gLQkJCXJhdGUgPSAwOwo+ PiA+IC0JCWVsc2UgaWYgKHBvcnQgPj0gUE9SVF9BICYmIHBvcnQgPD0gUE9SVF9FKQo+PiA+ICsJ CWVudW0gcG9ydCBwb3J0ID0gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKS0+cG9ydDsK Pj4gPiArCQlzdHJ1Y3QgaTkxNV9hdWRpb19jb21wb25lbnQgKmFjb21wID0gZGV2X3ByaXYtPmF1 ZGlvX2NvbXBvbmVudDsKPj4gPiArCQlpbnQgcmF0ZSwgbjsKPj4gCj4+IE1vdmluZyB0aGVzZSBo ZXJlIGlzIHByb2JhYmx5IGZpbmUsIGFsdGhvdWdoIG9yaWdpbmFsbHkgSSB3YXMgaG9waW5nIHdl Cj4+IHdvdWxkIGFsd2F5cyBwcm9ncmFtIHRoZSBOLCBhbmQgdGh1cyB3b3VsZG4ndCBoYXZlIHRo aXMgaWYKPj4gKGF1ZGlvX3JhdGVfbmVlZF9wcm9nKGludGVsX2NydGMsIGFkanVzdGVkX21vZGUp KSBibG9jayBoZXJlIGF0IGFsbC4gVGhlCj4+IGlkZWEgd2FzIHRoYXQgd2UnZCBhbHdheXMgdXNl IHRoZSBzYW1lIG1ldGhvZCBpbnN0ZWFkIG9mIGxldHRpbmcgdGhlIGh3Cj4+IHNldCBpdCBhdXRv bWF0aWNhbGx5IGZvciBzb21lIHJhdGVzLCBhbmQgbWFudWFsbHkgc2V0dGluZyBvdGhlcnMuCj4+ IAo+PiA+ICsKPj4gPiArCQlyYXRlID0gMDsKPj4gPiArCQlpZiAoYWNvbXAgJiYgcG9ydCA+PSBQ T1JUX0EgJiYgcG9ydCA8PSBQT1JUX0UpIHsKPj4gPiAgCQkJcmF0ZSA9IGFjb21wLT5hdWRfc2Ft cGxlX3JhdGVbcG9ydF07Cj4+ID4gLQkJZWxzZSB7Cj4+ID4gLQkJCURSTV9FUlJPUigiaW52YWxp ZCBwb3J0OiAlZFxuIiwgcG9ydCk7Cj4+IAo+PiBJIHRoaW5rIEkgbWF5IGhhdmUgc2VlbiB0aGVz ZSBpbiBzb21lIGRtZXNncyBpbiBvdGhlcndpc2UgdW5yZWxhdGVkCj4+IGJ1Z3MuIEknZCBsaWtl IHRvIHByZXNlcnZlIHRoaXMgYXQgbGVhc3QgYXMgYSBkZWJ1ZyBicmVhZGNydW1iLgo+PiAKPj4g PiAtCQkJcmF0ZSA9IDA7Cj4+ID4gKwo+PiA+ICsJCQluID0gYXVkaW9fY29uZmlnX2dldF9uKGFk anVzdGVkX21vZGUsIHJhdGUpOwo+PiA+ICsJCQlEUk1fREVCVUdfS01TKCJwb3J0ICVkIGF1ZGlv IHJhdGUgJWQgPT4gTj0leFxuIiwKPj4gPiArCQkJCSAgICAgIHBvcnQsIHJhdGUsIG4pOwo+PiA+ ICsJCQlpZiAobikKPj4gPiArCQkJCXRtcCA9IGF1ZGlvX2NvbmZpZ19zZXR1cF9uX3JlZyhuLCB0 bXApOwo+PiA+ICAJCX0KPj4gPiAtCQluID0gYXVkaW9fY29uZmlnX2dldF9uKGFkanVzdGVkX21v ZGUsIHJhdGUpOwo+PiA+IC0JCWlmIChuICE9IDApCj4+ID4gLQkJCXRtcCA9IGF1ZGlvX2NvbmZp Z19zZXR1cF9uX3JlZyhuLCB0bXApOwo+PiA+IC0JCWVsc2UKPj4gPiAtCQkJRFJNX0RFQlVHX0tN Uygibm8gc3VpdGFibGUgTiB2YWx1ZSBpcyBmb3VuZFxuIik7Cj4+IAo+PiBTYW1lIGhlcmUsIEkn ZCBsaWtlIHRvIHByZXNlcnZlIHRoZSBkZWJ1Zy4KPgo+IFRoZSBpbmZvcm1hdGlvbiBpcyBzdGls bCB0aGVyZSAoYm90aCBpbnZhbGlkIHBvcnQgYW5kIHVuZm91bmQgbiksIGp1c3QgYXMKPiBhIHNp bmdsZSBkZWJ1Zy4KCipzaHJ1ZyogSSB0aGluayB0aGUgc2VwYXJhdGUgbWVzc2FnZXMgb24gZXJy b3JzIHN0YW5kIG91dCBiZXR0ZXIuCgpKLgoKCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=