From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915/gen9: Fix DMC firmware initialization Date: Mon, 07 Mar 2016 14:36:41 +0200 Message-ID: <874mcih3c6.fsf@gaia.fi.intel.com> References: <1457111962-11687-1-git-send-email-imre.deak@intel.com> <1457121461-16729-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A7426E36F for ; Mon, 7 Mar 2016 12:38:53 +0000 (UTC) In-Reply-To: <1457121461-16729-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cml0ZXM6Cgo+IFsgdGV4dC9wbGFpbiBd Cj4gSW4gY29tbWl0IDFlNjU3YWQ3IHdlIG1vdmVkIHRoZSBsYXN0IHN0ZXAgb2YgZmlybXdhcmUg aW5pdGlhbGl6YXRpb24gdG8KPiBza2xfZGlzcGxheV9jb3JlX2luaXQoKSwgd2hlcmUgaXQgd2ls bCBiZSBydW4gb25seSBkdXJpbmcgc3lzdGVtIHJlc3VtZSwKPiBidXQgbm90IGR1cmluZyBkcml2 ZXIgbG9hZGluZy4gU2luY2UgdGhpcyBpbml0IHN0ZXAgbmVlZHMgdG8gYmUgZG9uZQo+IHdoZW5l dmVyIHdlIHByb2dyYW0gdGhlIGZpcm13YXJlIGZpeCB0aGlzIGJ5IG1vdmluZyB0aGUgaW5pdGlh bGl6YXRpb24KPiB0byB0aGUgZW5kIG9mIGludGVsX2Nzcl9sb2FkX3Byb2dyYW0oKS4KPgo+IFdo aWxlIGF0IGl0IHNpbXBsaWZ5IGEgYml0IGNzcl9sb2FkX3dvcmtfZm4oKS4KPgo+IFRoaXMgaXNz dWUgcHJldmVudGVkIERDNS82IHRyYW5zaXRpb25zLCB0aGlzIGNoYW5nZSB3aWxsIHJlLWVuYWJs ZSB0aG9zZS4KPgo+IHYyOgo+IC0gcmVtb3ZlIGRlYnVnZ2luZyBsZWZ0LW92ZXIgYW5kIHJlZHVu ZGFudCBjb21tZW50IGluIGNzcl9sb2FkX3dvcmtfZm4oKQo+Cj4gRml4ZXM6IDFlNjU3YWQ3YTQ4 ZiAoImRybS9pOTE1L2dlbjk6IFdyaXRlIGRjIHN0YXRlIGRlYnVnbWFzayBiaXRzIG9ubHkgb25j ZSIpCj4gQ0M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgo+IENDOiBQ YXRyaWsgSmFrb2Jzc29uIDxwYXRyaWsuamFrb2Jzc29uQGxpbnV4LmludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTog TWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYyAgICAgICAgfCA0MCArKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgICAg IHwgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIHwgMjIg KystLS0tLS0tLS0tLS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg MzUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY3NyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+IGluZGV4IDkwMjA1 NGUuLmQ0MTdkOWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3Ny LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+IEBAIC0yMTIsNiAr MjEyLDI0IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgc3RlcHBpbmdfaW5mbyAqaW50ZWxfZ2V0X3N0 ZXBwaW5nX2luZm8oc3RydWN0IGRybV9kZXZpY2UgKmRlCj4gIAlyZXR1cm4gTlVMTDsKPiAgfQo+ ICAKPiArc3RhdGljIHZvaWQgZ2VuOV9zZXRfZGNfc3RhdGVfZGVidWdtYXNrKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJdWludDMyX3QgdmFsLCBtYXNrOwo+ICsK PiArCW1hc2sgPSBEQ19TVEFURV9ERUJVR19NQVNLX01FTU9SWV9VUDsKPiArCj4gKwlpZiAoSVNf QlJPWFRPTihkZXZfcHJpdikpCj4gKwkJbWFzayB8PSBEQ19TVEFURV9ERUJVR19NQVNLX0NPUkVT Owo+ICsKPiArCS8qIFRoZSBiZWxvdyBiaXQgZG9lc24ndCBuZWVkIHRvIGJlIGNsZWFyZWQgZXZl ciBhZnRlcndhcmRzICovCj4gKwl2YWwgPSBJOTE1X1JFQUQoRENfU1RBVEVfREVCVUcpOwo+ICsJ aWYgKCh2YWwgJiBtYXNrKSAhPSBtYXNrKSB7Cj4gKwkJdmFsIHw9IG1hc2s7Cj4gKwkJSTkxNV9X UklURShEQ19TVEFURV9ERUJVRywgdmFsKTsKPiArCQlQT1NUSU5HX1JFQUQoRENfU1RBVEVfREVC VUcpOwo+ICsJfQo+ICt9Cj4gKwo+ICAvKioKPiAgICogaW50ZWxfY3NyX2xvYWRfcHJvZ3JhbSgp IC0gd3JpdGUgdGhlIGZpcm13YXJlIGZyb20gbWVtb3J5IHRvIHJlZ2lzdGVyLgo+ICAgKiBAZGV2 X3ByaXY6IGk5MTUgZHJtIGRldmljZS4KPiBAQCAtMjIwLDE5ICsyMzgsMTkgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBzdGVwcGluZ19pbmZvICppbnRlbF9nZXRfc3RlcHBpbmdfaW5mbyhzdHJ1Y3Qg ZHJtX2RldmljZSAqZGUKPiAgICogRXZlcnl0aW1lIGRpc3BsYXkgY29tZXMgYmFjayBmcm9tIGxv dyBwb3dlciBzdGF0ZSB0aGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB0bwo+ICAgKiBjb3B5IHRoZSBm aXJtd2FyZSBmcm9tIGludGVybmFsIG1lbW9yeSB0byByZWdpc3RlcnMuCj4gICAqLwo+IC1ib29s IGludGVsX2Nzcl9sb2FkX3Byb2dyYW0oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICt2b2lkIGludGVsX2Nzcl9sb2FkX3Byb2dyYW0oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICB7Cj4gIAl1MzIgKnBheWxvYWQgPSBkZXZfcHJpdi0+Y3NyLmRtY19wYXls b2FkOwo+ICAJdWludDMyX3QgaSwgZndfc2l6ZTsKPiAgCj4gIAlpZiAoIUlTX0dFTjkoZGV2X3By aXYpKSB7Cj4gIAkJRFJNX0VSUk9SKCJObyBDU1Igc3VwcG9ydCBhdmFpbGFibGUgZm9yIHRoaXMg cGxhdGZvcm1cbiIpOwo+IC0JCXJldHVybiBmYWxzZTsKPiArCQlyZXR1cm47Cj4gIAl9Cj4gIAo+ ICAJaWYgKCFkZXZfcHJpdi0+Y3NyLmRtY19wYXlsb2FkKSB7Cj4gIAkJRFJNX0VSUk9SKCJUcmll ZCB0byBwcm9ncmFtIENTUiB3aXRoIGVtcHR5IHBheWxvYWRcbiIpOwo+IC0JCXJldHVybiBmYWxz ZTsKPiArCQlyZXR1cm47Cj4gIAl9Cj4gIAo+ICAJZndfc2l6ZSA9IGRldl9wcml2LT5jc3IuZG1j X2Z3X3NpemU7Cj4gQEAgLTI0Niw3ICsyNjQsNyBAQCBib29sIGludGVsX2Nzcl9sb2FkX3Byb2dy YW0oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAKPiAgCWRldl9wcml2LT5j c3IuZGNfc3RhdGUgPSAwOwo+ICAKPiAtCXJldHVybiB0cnVlOwo+ICsJZ2VuOV9zZXRfZGNfc3Rh dGVfZGVidWdtYXNrKGRldl9wcml2KTsKPiAgfQo+ICAKPiAgc3RhdGljIHVpbnQzMl90ICpwYXJz ZV9jc3JfZncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IEBAIC0zODgsMTgg KzQwNiwxMiBAQCBzdGF0aWMgdm9pZCBjc3JfbG9hZF93b3JrX2ZuKHN0cnVjdCB3b3JrX3N0cnVj dCAqd29yaykKPiAgCj4gIAlyZXQgPSByZXF1ZXN0X2Zpcm13YXJlKCZmdywgZGV2X3ByaXYtPmNz ci5md19wYXRoLAo+ICAJCQkgICAgICAgJmRldl9wcml2LT5kZXYtPnBkZXYtPmRldik7Cj4gLQlp ZiAoIWZ3KQo+IC0JCWdvdG8gb3V0Owo+ICsJaWYgKGZ3KQo+ICsJCWRldl9wcml2LT5jc3IuZG1j X3BheWxvYWQgPSBwYXJzZV9jc3JfZncoZGV2X3ByaXYsIGZ3KTsKPiAgCj4gLQlkZXZfcHJpdi0+ Y3NyLmRtY19wYXlsb2FkID0gcGFyc2VfY3NyX2Z3KGRldl9wcml2LCBmdyk7Cj4gLQlpZiAoIWRl dl9wcml2LT5jc3IuZG1jX3BheWxvYWQpCj4gLQkJZ290byBvdXQ7Cj4gLQo+IC0JLyogbG9hZCBj c3IgcHJvZ3JhbSBkdXJpbmcgc3lzdGVtIGJvb3QsIGFzIG5lZWRlZCBmb3IgREMgc3RhdGVzICov Cj4gLQlpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKGRldl9wcml2KTsKPiAtCj4gLW91dDoKPiAgCWlm IChkZXZfcHJpdi0+Y3NyLmRtY19wYXlsb2FkKSB7Cj4gKwkJaW50ZWxfY3NyX2xvYWRfcHJvZ3Jh bShkZXZfcHJpdik7Cj4gKwo+ICAJCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBQ T1dFUl9ET01BSU5fSU5JVCk7Cj4gIAo+ICAJCURSTV9JTkZPKCJGaW5pc2hlZCBsb2FkaW5nICVz ICh2JXUuJXUpXG4iLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXggY2QwYjRlYS4u M2RhZjFlMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTEyNzksNyArMTI3 OSw3IEBAIHUzMiBza2xfcGxhbmVfY3RsX3JvdGF0aW9uKHVuc2lnbmVkIGludCByb3RhdGlvbik7 Cj4gIAo+ICAvKiBpbnRlbF9jc3IuYyAqLwo+ICB2b2lkIGludGVsX2Nzcl91Y29kZV9pbml0KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICopOwo+IC1ib29sIGludGVsX2Nzcl9sb2FkX3Byb2dyYW0o c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKik7Cj4gK3ZvaWQgaW50ZWxfY3NyX2xvYWRfcHJvZ3Jh bShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqKTsKPiAgdm9pZCBpbnRlbF9jc3JfdWNvZGVfZmlu aShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqKTsKPiAgCj4gIC8qIGludGVsX2RwLmMgKi8KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gaW5kZXggMDljNTJiMS4uNWFk ZjRiMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3Bt LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBAQCAt NDcwLDI0ICs0NzAsNiBAQCBzdGF0aWMgdm9pZCBhc3NlcnRfY2FuX2Rpc2FibGVfZGM5KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCSAgKi8KPiAgfQo+ICAKPiAtc3RhdGlj IHZvaWQgZ2VuOV9zZXRfZGNfc3RhdGVfZGVidWdtYXNrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAtewo+IC0JdWludDMyX3QgdmFsLCBtYXNrOwo+IC0KPiAtCW1hc2sgPSBE Q19TVEFURV9ERUJVR19NQVNLX01FTU9SWV9VUDsKPiAtCj4gLQlpZiAoSVNfQlJPWFRPTihkZXZf cHJpdikpCj4gLQkJbWFzayB8PSBEQ19TVEFURV9ERUJVR19NQVNLX0NPUkVTOwo+IC0KPiAtCS8q IFRoZSBiZWxvdyBiaXQgZG9lc24ndCBuZWVkIHRvIGJlIGNsZWFyZWQgZXZlciBhZnRlcndhcmRz ICovCj4gLQl2YWwgPSBJOTE1X1JFQUQoRENfU1RBVEVfREVCVUcpOwo+IC0JaWYgKCh2YWwgJiBt YXNrKSAhPSBtYXNrKSB7Cj4gLQkJdmFsIHw9IG1hc2s7Cj4gLQkJSTkxNV9XUklURShEQ19TVEFU RV9ERUJVRywgdmFsKTsKPiAtCQlQT1NUSU5HX1JFQUQoRENfU1RBVEVfREVCVUcpOwo+IC0JfQo+ IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCBnZW45X3dyaXRlX2RjX3N0YXRlKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCXUzMiBzdGF0ZSkKPiAgewo+IEBAIC0yMTQxLDgg KzIxMjMsOCBAQCBzdGF0aWMgdm9pZCBza2xfZGlzcGxheV9jb3JlX2luaXQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAKPiAgCXNrbF9pbml0X2NkY2xrKGRldl9wcml2KTsK PiAgCj4gLQlpZiAoZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCAmJiBpbnRlbF9jc3JfbG9hZF9w cm9ncmFtKGRldl9wcml2KSkKPiAtCQlnZW45X3NldF9kY19zdGF0ZV9kZWJ1Z21hc2soZGV2X3By aXYpOwo+ICsJaWYgKGRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQpCj4gKwkJaW50ZWxfY3NyX2xv YWRfcHJvZ3JhbShkZXZfcHJpdik7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIHNrbF9kaXNwbGF5 X2NvcmVfdW5pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtLSAKPiAy LjUuMAo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=