Re: [Intel-gfx] [PATCH] drm/edid: set ELD for firmware and debugfs override EDIDs

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 26 Mar 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Mar 26, 2015 at 10:42:00AM +0200, Jani Nikula wrote:
>> If the user supplies EDID through firmware or debugfs override, the
>> driver callbacks are bypassed and the connector ELD does not get
>> updated, and audio fails. Set ELD for firmware and debugfs EDIDs too.
>> 
>> There should be no harm in gratuitously doing this for non HDMI/DP
>> connectors, as it's still up to the driver to use the ELD, if any.
>> 
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82349
>> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=80691
>> Reported-by: Emil <emilsvennesson@gmail.com>
>> Reported-by: Rob Engle <grenoble@gmail.com>
>> Tested-by: Jolan Luff <jolan@gormsby.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Since it's harmless I wonder whether we shouldn't just do this in
> drm_add_edid_modes unconditionally. But this looks like the right minimal
> patch for -fixes, so Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

While I was hoping to gather review from outside of drm/i915 folks, I
picked this up and pushed to our new topic/drm-fixes branch of [1].

I intend to keep picking up (occasional, non-controversial) drm core
fixes aimed at the current development (-rc) kernels, to ensure they're
not dropped, and sending pull requests to Dave as needed. He'll have the
final call whether to pull or not, of course. This is similar to what
Daniel does with the topic/drm-misc branch for drm-next.

Please let me know if you have any feedback on this.

Thanks,
Jani.


[1] http://cgit.freedesktop.org/drm-intel

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel