From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2 05/14] drm/i915: Rewrite vlv_find_best_dpll() Date: Fri, 27 Sep 2013 14:55:32 +0300 Message-ID: <874n96cwcr.fsf@gaia.fi.intel.com> References: <1380047191-3359-1-git-send-email-ville.syrjala@linux.intel.com> <1380047191-3359-6-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 384A5E6241 for ; Fri, 27 Sep 2013 04:55:59 -0700 (PDT) In-Reply-To: <1380047191-3359-6-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JpdGVzOgoKPiBGcm9tOiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Cj4gUmV3cml0ZSB2bHZfZmlu ZF9iZXN0X2RwbGwoKSB0byB1c2UgaW50ZWxfY2xvY2tfdCByYXRoZXIgdGhhbgo+IGFuIGFybXkg b2YgbG9jYWwgdmFyaWFibGVzLgo+Cj4gQWxzbyBleHRyYWN0IHRoZSBjb2RlIHRvIGNhbGN1bGF0 ZSB0aGUgZGVyaXZlZCB2YWx1ZXMgaW50bwo+IHZsdl9jbG9jaygpLgo+Cj4gdjI6IFNwbGl0IHVw IHRoZSBlYXJsaWVyIGZpeGVzLCBleHRyYWN0IHZsdl9jbG9jaygpCj4KPiBTaWduZWQtb2ZmLWJ5 OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA3MiArKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMo KyksIDQxIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IGluZGV4IGY2NDZmZWEuLmM1ZjA3OTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gQEAgLTQzOCw2ICs0MzgsMTQgQEAgc3RhdGljIHZvaWQgaTl4eF9jbG9jayhpbnQg cmVmY2xrLCBpbnRlbF9jbG9ja190ICpjbG9jaykKPiAgCWNsb2NrLT5kb3QgPSBjbG9jay0+dmNv IC8gY2xvY2stPnA7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIHZsdl9jbG9jayhpbnQgcmVmY2xr LCBpbnRlbF9jbG9ja190ICpjbG9jaykKPiArewo+ICsJY2xvY2stPm0gPSBjbG9jay0+bTEgKiBj bG9jay0+bTI7Cj4gKwljbG9jay0+cCA9IGNsb2NrLT5wMSAqIGNsb2NrLT5wMjsKPiArCWNsb2Nr LT52Y28gPSByZWZjbGsgKiBjbG9jay0+bSAvIGNsb2NrLT5uOwo+ICsJY2xvY2stPmRvdCA9IGNs b2NrLT52Y28gLyBjbG9jay0+cDsKPiArfQo+ICsKPiAgLyoqCj4gICAqIFJldHVybnMgd2hldGhl ciBhbnkgb3V0cHV0IG9uIHRoZSBzcGVjaWZpZWQgcGlwZSBpcyBvZiB0aGUgc3BlY2lmaWVkIHR5 cGUKPiAgICovCj4gQEAgLTY3MCw2NiArNjc4LDQ4IEBAIHZsdl9maW5kX2Jlc3RfZHBsbChjb25z dCBpbnRlbF9saW1pdF90ICpsaW1pdCwgc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCSAgIGlu dCB0YXJnZXQsIGludCByZWZjbGssIGludGVsX2Nsb2NrX3QgKm1hdGNoX2Nsb2NrLAo+ICAJCSAg IGludGVsX2Nsb2NrX3QgKmJlc3RfY2xvY2spCj4gIHsKPiAtCXUzMiBwMSwgcDIsIG0xLCBtMiwg dmNvLCBiZXN0biwgYmVzdG0xLCBiZXN0bTIsIGJlc3RwMSwgYmVzdHAyOwo+IC0JdTMyIG0sIG4s IGZhc3RjbGs7Cj4gLQl1MzIgdXBkcmF0ZSwgbWludXBkYXRlLCBwOwo+ICsJaW50ZWxfY2xvY2tf dCBjbG9jazsKPiArCXUzMiBtaW51cGRhdGUgPSAxOTIwMDsKPiAgCXVuc2lnbmVkIGludCBiZXN0 cHBtID0gMTAwMDAwMDsKPiAtCWludCBkb3RjbGssIGZsYWc7Cj4gIAo+IC0JZmxhZyA9IDA7Cj4g LQlkb3RjbGsgPSB0YXJnZXQgKiAxMDAwOwo+IC0JZmFzdGNsayA9IGRvdGNsayAvICgyKjEwMCk7 Cj4gLQl1cGRyYXRlID0gMDsKPiAtCW1pbnVwZGF0ZSA9IDE5MjAwOwo+IC0JbiA9IHAgPSBwMSA9 IHAyID0gbSA9IG0xID0gbTIgPSB2Y28gPSBiZXN0biA9IDA7Cj4gLQliZXN0bTEgPSBiZXN0bTIg PSBiZXN0cDEgPSBiZXN0cDIgPSAwOwo+ICsJdGFyZ2V0ICo9IDU7IC8qIGZhc3QgY2xvY2sgKi8K PiAgCj4gIAkvKiBiYXNlZCBvbiBoYXJkd2FyZSByZXF1aXJlbWVudCwgcHJlZmVyIHNtYWxsZXIg biB0byBwcmVjaXNpb24gKi8KPiAtCWZvciAobiA9IGxpbWl0LT5uLm1pbjsgbiA8PSAoKHJlZmNs aykgLyBtaW51cGRhdGUpOyBuKyspIHsKPiAtCQl1cGRyYXRlID0gcmVmY2xrIC8gbjsKPiAtCQlm b3IgKHAxID0gbGltaXQtPnAxLm1heDsgcDEgPiBsaW1pdC0+cDEubWluOyBwMS0tKSB7Cj4gLQkJ CWZvciAocDIgPSBsaW1pdC0+cDIucDJfZmFzdCsxOyBwMiA+IDA7IHAyLS0pIHsKPiAtCQkJCWlm IChwMiA+IDEwKQo+IC0JCQkJCXAyID0gcDIgLSAxOwo+IC0JCQkJcCA9IHAxICogcDI7Cj4gKwlm b3IgKGNsb2NrLm4gPSBsaW1pdC0+bi5taW47IGNsb2NrLm4gPD0gKChyZWZjbGspIC8gbWludXBk YXRlKTsgY2xvY2subisrKSB7Cj4gKwkJZm9yIChjbG9jay5wMSA9IGxpbWl0LT5wMS5tYXg7IGNs b2NrLnAxID4gbGltaXQtPnAxLm1pbjsgY2xvY2sucDEtLSkgewo+ICsJCQlmb3IgKGNsb2NrLnAy ID0gbGltaXQtPnAyLnAyX2Zhc3QrMTsgY2xvY2sucDIgPiAwOyBjbG9jay5wMi0tKSB7Cj4gKwkJ CQlpZiAoY2xvY2sucDIgPiAxMCkKPiArCQkJCQljbG9jay5wMi0tOwo+ICsJCQkJY2xvY2sucCA9 IGNsb2NrLnAxICogY2xvY2sucDI7Cj4gIAkJCQkvKiBiYXNlZCBvbiBoYXJkd2FyZSByZXF1aXJl bWVudCwgcHJlZmVyIGJpZ2dlciBtMSxtMiB2YWx1ZXMgKi8KPiAtCQkJCWZvciAobTEgPSBsaW1p dC0+bTEubWluOyBtMSA8PSBsaW1pdC0+bTEubWF4OyBtMSsrKSB7Cj4gKwkJCQlmb3IgKGNsb2Nr Lm0xID0gbGltaXQtPm0xLm1pbjsgY2xvY2subTEgPD0gbGltaXQtPm0xLm1heDsgY2xvY2subTEr Kykgewo+ICAJCQkJCXVuc2lnbmVkIGludCBwcG0sIGRpZmY7Cj4gIAo+IC0JCQkJCW0yID0gRElW X1JPVU5EX0NMT1NFU1QoZmFzdGNsayAqIHAgKiBuLCByZWZjbGsgKiBtMSk7Cj4gLQkJCQkJbSA9 IG0xICogbTI7Cj4gLQkJCQkJdmNvID0gdXBkcmF0ZSAqIG07Cj4gKwkJCQkJY2xvY2subTIgPSBE SVZfUk9VTkRfQ0xPU0VTVCh0YXJnZXQgKiBjbG9jay5wICogY2xvY2subiwKPiArCQkJCQkJCQkg ICAgIHJlZmNsayAqIGNsb2NrLm0xKTsKPiAgCj4gLQkJCQkJaWYgKHZjbyA8IGxpbWl0LT52Y28u bWluIHx8IHZjbyA+PSBsaW1pdC0+dmNvLm1heCkKPiArCQkJCQl2bHZfY2xvY2socmVmY2xrLCAm Y2xvY2spOwo+ICsKPiArCQkJCQlpZiAoY2xvY2sudmNvIDwgbGltaXQtPnZjby5taW4gfHwKPiAr CQkJCQkgICAgY2xvY2sudmNvID49IGxpbWl0LT52Y28ubWF4KQo+ICAJCQkJCQljb250aW51ZTsK PiAgCj4gLQkJCQkJZGlmZiA9IGFicyh2Y28gLyBwIC0gZmFzdGNsayk7Cj4gLQkJCQkJcHBtID0g ZGl2X3U2NCgxMDAwMDAwVUxMICogZGlmZiwgZmFzdGNsayk7Cj4gLQkJCQkJaWYgKHBwbSA8IDEw MCAmJiAoKHAxICogcDIpID4gKGJlc3RwMSAqIGJlc3RwMikpKSB7Cj4gKwkJCQkJZGlmZiA9IGFi cyhjbG9jay5kb3QgLSB0YXJnZXQpOwo+ICsJCQkJCXBwbSA9IGRpdl91NjQoMTAwMDAwMFVMTCAq IGRpZmYsIHRhcmdldCk7Cj4gKwo+ICsJCQkJCWlmIChwcG0gPCAxMDAgJiYgY2xvY2sucCA+IGJl c3RfY2xvY2stPnApIHsKCmJlc3RfY2xvY2sgbmVlZHMgdG8gYmUgaW5pdGlhbGl6ZWQgb3IgeW91 IGVuZCB1cCBjb21wYXJpbmcgYWdhaW5zdApieXRlcyBmcm9tIHN0YWNrIG9uIGZpcnN0IGhpdHRp bmcgaGVyZS4KCj4gIAkJCQkJCWJlc3RwcG0gPSAwOwo+IC0JCQkJCQlmbGFnID0gMTsKPiArCQkJ CQkJKmJlc3RfY2xvY2sgPSBjbG9jazsKPiAgCQkJCQl9Cj4gKwo+ICAJCQkJCWlmIChiZXN0cHBt ID49IDEwICYmIHBwbSA8IGJlc3RwcG0gLSAxMCkgewo+ICAJCQkJCQliZXN0cHBtID0gcHBtOwo+ IC0JCQkJCQlmbGFnID0gMTsKPiAtCQkJCQl9Cj4gLQkJCQkJaWYgKGZsYWcpIHsKPiAtCQkJCQkJ YmVzdG4gPSBuOwo+IC0JCQkJCQliZXN0bTEgPSBtMTsKPiAtCQkJCQkJYmVzdG0yID0gbTI7Cj4g LQkJCQkJCWJlc3RwMSA9IHAxOwo+IC0JCQkJCQliZXN0cDIgPSBwMjsKPiAtCQkJCQkJZmxhZyA9 IDA7Cj4gKwkJCQkJCSpiZXN0X2Nsb2NrID0gY2xvY2s7Cj4gIAkJCQkJfQo+ICAJCQkJfQo+ICAJ CQl9Cj4gIAkJfQo+ICAJfQo+IC0JYmVzdF9jbG9jay0+biA9IGJlc3RuOwo+IC0JYmVzdF9jbG9j ay0+bTEgPSBiZXN0bTE7Cj4gLQliZXN0X2Nsb2NrLT5tMiA9IGJlc3RtMjsKPiAtCWJlc3RfY2xv Y2stPnAxID0gYmVzdHAxOwo+IC0JYmVzdF9jbG9jay0+cDIgPSBiZXN0cDI7Cj4gIAo+ICAJcmV0 dXJuIHRydWU7Cj4gIH0KPiAtLSAKPiAxLjguMS41Cj4KPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=