From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B758CD6E64 for ; Wed, 11 Oct 2023 13:05:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA8F610E7F6; Wed, 11 Oct 2023 13:05:13 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8306C10E802; Wed, 11 Oct 2023 13:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697029510; x=1728565510; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bsszA6xE3LIClaTQcB826KjOONiJLIxrIgfytHrRW84=; b=Bax8NJTvPhtWuZZtD8N/7m20KkEAnccWt+iaVeI+JBv87casUqxaavnx iQ9q/S9wuYlNABOfocsZYxgkP8KbO8SVeTXtVwf9g+uuf1CKfTeiSZbvU IRPEHFVQbApfv9LYmmyEIs1MkzoRM1a53IuRhlerzLZfiC0VuZuaEJcQM zIkki1T8kXzjF+Bg7ZNg/+t/KRR8hcwMACFWB2M4N5idTD7mUHeq+si11 bOB6mcwPC6ZKpUD5mcz3l6RWntIbg5e57kSqEUwGkrmArmU/IendsoAqz j+HmW3PeTV2/dgv92Sre64DHDtEIQ/QFYHiWq3jkBQuNwdpbcfpbtEfVt A==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="470918522" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="470918522" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 06:05:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="927562644" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="927562644" Received: from bjvanakk-mobl.ger.corp.intel.com (HELO localhost) ([10.252.42.111]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 06:05:06 -0700 From: Jani Nikula To: Hans de Goede , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Ville =?utf-8?B?U3lyasOk?= =?utf-8?B?bMOk?= In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230920195613.304091-1-hdegoede@redhat.com> Date: Wed, 11 Oct 2023 16:05:02 +0300 Message-ID: <875y3d48e9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 0/4] drm/i915/vlv_dsi: Add quirks for x86 android tablets (v3) X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, 08 Oct 2023, Hans de Goede wrote: > Hi All, > > Ping what is the status of this now? This v3 addresses all review > remarks from previous versions (specifically the request to file > + link gitlab issues). > > So AFAICT this is ready for merging ? > > But I'm waiting for an ack for this before pushing it > do drm-intel-next myself ... There are maybe one or two things I could nitpick about, such as casting away the const in there, but then I just don't have the time to look into this much deeper, it's all fairly isolated, and, let's be honest, you of all people probably have the best idea how well the vlv dsi code works out in the real world. Thanks for fixing all this stuff, and please just merge. Acked-by: Jani Nikula > > Regards, > > Hans > > > > > On 9/20/23 21:56, Hans de Goede wrote: >> Hi All, >> >> Some vlv/chv tablets ship with Android as factory OS. The factory OS >> BSP style kernel on these tablets does not use the normal x86 hw >> autodetection instead it hardcodes a whole bunch of things including >> using panel drivers instead of relying on VBT MIPI sequences to >> turn the panel/backlight on/off. >> >> The normal i915 driver (which does not use panel drivers) mostly works >> since the VBT still needs to contain valid info for the GOP, but because >> of the Android kernel relying on panel drivers with various things >> hardcoded some DMI quirks are necessary to fix some issues on these >> devices. >> >> Some of these issues also are related to which I2C bus to use for >> MIPI sequence elements which do I2C transfers. This series also >> includes a patch adding some extra debugging to mipi_exec_i2c() to >> help with debugging similar issues in the future. >> >> These patches have been posted before but back then I did not get around >> to follow up on the series: >> https://lore.kernel.org/intel-gfx/20220225214934.383168-1-hdegoede@redhat.com/ >> >> v2: >> - Drop the changes how the I2C bus number is found, instead just have >> the quirks set the right number directly where necessary. This should >> avoid any chances of causing regressions on devices where the quirks >> do not apply. >> - New quirk for backlight control issues on Lenovo Yoga Tab 3 >> - Address Jani Nikula's remark about __func__ being redundant when using >> drm_dbg_kms() >> >> v3: >> - File 3 gitlab issues with drm.debug=0xe dmesg output, VBT dump for all >> 3 affected models. Add Closes: tags with links to gitlab issues >> >> Regards, >> >> Hans >> >> >> Hans de Goede (4): >> drm/i915/vlv_dsi: Add DMI quirk for wrong panel modeline in BIOS on >> Asus TF103C (v3) >> drm/i915/vlv_dsi: Add DMI quirk for wrong I2C bus and panel size on >> Lenovo Yoga Tablet 2 series (v3) >> drm/i915/vlv_dsi: Add DMI quirk for backlight control issues on Lenovo >> Yoga Tab 3 (v2) >> drm/i915/dsi: Add some debug logging to mipi_exec_i2c (v2) >> >> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 + >> drivers/gpu/drm/i915/display/vlv_dsi.c | 124 +++++++++++++++++++ >> 2 files changed, 127 insertions(+) >> > -- Jani Nikula, Intel