From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EED0C61DA4 for ; Thu, 9 Mar 2023 15:09:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E81610E84C; Thu, 9 Mar 2023 15:09:48 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56B0F10E84C for ; Thu, 9 Mar 2023 15:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678374586; x=1709910586; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=5rWNscd0xgBXzwh1Z1K36JAcbiIGifE/QVIAGidvI1A=; b=PV/QNusOcMa9pxER8+nFmf2widl0Y6Kfse7GEesnu7GMbE9WVwDUqlrk rDT/vlDMlqJbvTz7zFtytUThyMwEKw8+vNn95UuoWTMfT50+WMXqWP7h3 r1oLACJ65FQej2k6BowxqpxxrrE3m59rHL2OG1Cd82yywYnOo6BGknpho q2rV/zFRJ86JliSWcDOga8uKbkTiFwiRMPbT/wM/Qx49doChOktZe9IYV lgr08xIcIrSsvNv8GewlpHyNEkt1dWFLgfwlYHKVOrJUm0pYKU11JZTn1 1Mzi6o8ADOTmKgvcR+BYNbE5ezUU8BpWlO/D5VVppAumsBVWdO/2LtR57 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="320312294" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="320312294" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 06:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="787592826" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="787592826" Received: from jnikula-mobl4.fi.intel.com (HELO localhost) ([10.237.66.145]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 06:51:16 -0800 From: Jani Nikula To: Dan Carpenter In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Thu, 09 Mar 2023 16:51:10 +0200 Message-ID: <875yba9dwh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [bug report] drm/i915/dmc: add i915_to_dmc() and dmc->i915 and use them X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 09 Mar 2023, Dan Carpenter wrote: > Hello Jani Nikula, > > This is a semi-automatic email about new static checker warnings. > > The patch 1b28c1c789d0: "drm/i915/dmc: add i915_to_dmc() and > dmc->i915 and use them" from Mar 1, 2023, leads to the following > Smatch complaint: > > drivers/gpu/drm/i915/display/intel_dmc.c:1162 intel_dmc_debugfs_status_show() > error: we previously assumed 'dmc' could be null (see line 1148) > > drivers/gpu/drm/i915/display/intel_dmc.c > 1142 > 1143 wakeref = intel_runtime_pm_get(&i915->runtime_pm); > 1144 > 1145 seq_printf(m, "DMC initialized: %s\n", str_yes_no(dmc));' > ^^^^^^^^^^^^^^^ > This is a check for NULL too. > > 1146 seq_printf(m, "fw loaded: %s\n", > 1147 str_yes_no(intel_dmc_has_payload(i915))); > 1148 seq_printf(m, "path: %s\n", dmc ? dmc->fw_path : "N/A"); > ^^^ > The patch adds a check for NULL. > > 1149 seq_printf(m, "Pipe A fw needed: %s\n", > 1150 str_yes_no(GRAPHICS_VER(i915) >= 12)); > 1151 seq_printf(m, "Pipe A fw loaded: %s\n", > 1152 str_yes_no(has_dmc_id_fw(i915, DMC_FW_PIPEA))); > 1153 seq_printf(m, "Pipe B fw needed: %s\n", > 1154 str_yes_no(IS_ALDERLAKE_P(i915) || > 1155 DISPLAY_VER(i915) >= 14)); > 1156 seq_printf(m, "Pipe B fw loaded: %s\n", > 1157 str_yes_no(has_dmc_id_fw(i915, DMC_FW_PIPEB))); > 1158 > 1159 if (!intel_dmc_has_payload(i915)) intel_dmc_has_payload() should always return false for dmc == NULL. BR, Jani. > 1160 goto out; > 1161 > 1162 seq_printf(m, "version: %d.%d\n", DMC_VERSION_MAJOR(dmc->version), > ^^^^^^^^^^^^ > 1163 DMC_VERSION_MINOR(dmc->version)); > ^^^^^^^^^^^^ > Unchecked dereferences. > > 1164 > > regards, > dan carpenter -- Jani Nikula, Intel Open Source Graphics Center