From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D96EC433EF for ; Mon, 27 Sep 2021 11:45:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DB3F60F4B for ; Mon, 27 Sep 2021 11:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4DB3F60F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAEC089DB4; Mon, 27 Sep 2021 11:45:09 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F69489EB4; Mon, 27 Sep 2021 11:45:08 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10119"; a="224516307" X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="224516307" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 04:45:07 -0700 X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="553159862" Received: from susuale1-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.36.178]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 04:45:02 -0700 From: Jani Nikula To: Kai Vehmanen , Kai-Heng Feng Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, David Airlie , Daniel Vetter , Ville =?utf-8?B?U3ly?= =?utf-8?B?asOkbMOk?= , Lucas De Marchi , Imre Deak , Uma Shankar , Matt Roper , Kai Vehmanen , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210906041300.508458-1-kai.heng.feng@canonical.com> Date: Mon, 27 Sep 2021 14:44:59 +0300 Message-ID: <875yums0n8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 06 Sep 2021, Kai Vehmanen wrote: > Hi, > > On Mon, 6 Sep 2021, Kai-Heng Feng wrote: > >> Commit 989634fb49ad ("drm/i915/audio: set HDA link parameters in >> driver") makes HDMI audio on Lenovo P350 disappear. >> >> So in addition to TGL, extend the logic to RKL to use BIOS provided >> value to fix the regression. > > thanks Kai-Heng! We were not aware of commercial RKL systems following the > old BIOS guidance, but given you just hit one, then this definitely is > needed: > > Reviewed-by: Kai Vehmanen This had fallen between the cracks, pushed now. Thanks for the patch and review. BR, Jani. > > Br, Kai -- Jani Nikula, Intel Open Source Graphics Center