From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 08/25] drm/i915/pmu: Always sample an active
 ringbuffer
Date: Fri, 22 Feb 2019 14:31:28 +0200
Message-ID: <875ztcvwbj.fsf@gaia.fi.intel.com>
References: <20190219122215.8941-1-chris@chris-wilson.co.uk>
 <20190219122215.8941-8-chris@chris-wilson.co.uk>
 <878sy8vxae.fsf@gaia.fi.intel.com>
 <155083785325.4937.9415724962916954190@skylake-alporthouse-com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 18AB689170
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Feb 2019 12:31:51 +0000 (UTC)
In-Reply-To: <155083785325.4937.9415724962916954190@skylake-alporthouse-com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu
ZyBNaWthIEt1b3BwYWxhICgyMDE5LTAyLTIyIDEyOjEwOjMzKQo+PiBDaHJpcyBXaWxzb24gPGNo
cmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JpdGVzOgo+PiAKPj4gPiBBcyB3ZSBubyBsb25nZXIg
aGF2ZSBhIHByZWNpc2UgaW5kaWNhdGlvbiBvZiByZXF1ZXN0cyBxdWV1ZWQgdG8gYW4KPj4gPiBl
bmdpbmUsIG1ha2Ugbm8gcHJlc3VtcHRpb25zIGFuZCBqdXN0IHNhbXBsZSB0aGUgcmluZyByZWdp
c3RlcnMgdG8gc2VlCj4+ID4gaWYgdGhlIGVuZ2luZSBpcyBidXN5Lgo+PiA+Cj4+ID4gdjI6IFJl
cG9ydCBidXN5IHdoaWxlIHRoZSByaW5nIGlzIGlkbGluZyBvbiBhIHNlbWFwaG9yZS9ldmVudC4K
Pj4gPiB2MzogR2l2ZSB0aGUgc3RydWN0IGEgbmFtZSEKPj4gPiB2NDogQWx3YXlzIDAgb3V0c2lk
ZSB0aGUgcG93ZXJ3ZWxsOyB0cnVzdGluZyB0aGUgcG93ZXJ3ZWxsIGlzCj4+ID4gYWNjdXJhdGUg
ZW5vdWdoIGZvciBvdXIgc2FtcGxpbmcgcG11Lgo+PiA+Cj4+ID4gU2lnbmVkLW9mZi1ieTogQ2hy
aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+ID4gQ2M6IFR2cnRrbyBVcnN1
bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+ID4gLS0tCj4+ID4gIGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfcG11LmMgICAgICAgICB8IDYwICsrKysrKysrKystLS0tLS0tLS0tLS0t
LS0KPj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIHwgIDIgKy0K
Pj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkK
Pj4gPgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+PiA+IGluZGV4IDEzZDcwYjkwZGQwZi4u
MjFhZGFkNzJiZDg2IDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf
cG11LmMKPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4+ID4gQEAg
LTE0OCwxNCArMTQ4LDYgQEAgdm9pZCBpOTE1X3BtdV9ndF91bnBhcmtlZChzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqaTkxNSkKPj4gPiAgICAgICBzcGluX3VubG9ja19pcnEoJmk5MTUtPnBtdS5s
b2NrKTsKPj4gPiAgfQo+PiA+ICAKPj4gPiAtc3RhdGljIGJvb2wgZ3JhYl9mb3JjZXdha2Uoc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGJvb2wgZncpCj4+ID4gLXsKPj4gPiAtICAgICBp
ZiAoIWZ3KQo+PiA+IC0gICAgICAgICAgICAgaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXQoaTkx
NSwgRk9SQ0VXQUtFX0FMTCk7Cj4+ID4gLQo+PiA+IC0gICAgIHJldHVybiB0cnVlOwo+PiA+IC19
Cj4+ID4gLQo+PiA+ICBzdGF0aWMgdm9pZAo+PiA+ICBhZGRfc2FtcGxlKHN0cnVjdCBpOTE1X3Bt
dV9zYW1wbGUgKnNhbXBsZSwgdTMyIHZhbCkKPj4gPiAgewo+PiA+IEBAIC0xNjgsNDkgKzE2MCw0
MyBAQCBlbmdpbmVzX3NhbXBsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHVu
c2lnbmVkIGludCBwZXJpb2RfbnMpCj4+ID4gICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAq
ZW5naW5lOwo+PiA+ICAgICAgIGVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+PiA+ICAgICAgIGlu
dGVsX3dha2VyZWZfdCB3YWtlcmVmOwo+PiA+IC0gICAgIGJvb2wgZncgPSBmYWxzZTsKPj4gPiAg
Cj4+ID4gICAgICAgaWYgKChkZXZfcHJpdi0+cG11LmVuYWJsZSAmIEVOR0lORV9TQU1QTEVfTUFT
SykgPT0gMCkKPj4gPiAgICAgICAgICAgICAgIHJldHVybjsKPj4gPiAgCj4+ID4gLSAgICAgaWYg
KCFkZXZfcHJpdi0+Z3QuYXdha2UpCj4+ID4gLSAgICAgICAgICAgICByZXR1cm47Cj4+ID4gLQo+
PiA+IC0gICAgIHdha2VyZWYgPSBpbnRlbF9ydW50aW1lX3BtX2dldF9pZl9pbl91c2UoZGV2X3By
aXYpOwo+PiA+ICsgICAgIHdha2VyZWYgPSAwOwo+PiA+ICsgICAgIGlmIChSRUFEX09OQ0UoZGV2
X3ByaXYtPmd0LmF3YWtlKSkKPj4gCj4+IElzIHRoaXMgZ3QuYXdha2UgY2hlY2sganVzdCB0byBi
ZSBtb3JlIGxpZ2h0d2VpZ2h0IG9uIHNhbXBsaW5nPwo+Cj4gWWVzLCB3ZSBrbm93IHRoYXQgaWYg
IWF3YWtlLCB0aGVuIHdlIGFyZSBpZGxlIGFuZCBhcmUgZG9uZSB3aXRoCj4gc2FtcGxpbmcuIEl0
IGFsc28gdGllcyBpbiBsYXRlciB3aXRoIGEgcGF0Y2ggdG8gY2hhbmdlIGhvdyB3ZSBoYW5kbGUg
cnBtCj4gc3VzcGVuZCBwZXJpb2RzICh3aGljaCBpcyB3aHkgSSB3ZW50IHdpdGggd3JpdGluZyBp
dCBpbiB0aGlzIGlkaW9tKS4KPgo+PiA+ICsgICAgICAgICAgICAgd2FrZXJlZiA9IGludGVsX3J1
bnRpbWVfcG1fZ2V0X2lmX2luX3VzZShkZXZfcHJpdik7Cj4+ID4gICAgICAgaWYgKCF3YWtlcmVm
KQo+PiA+ICAgICAgICAgICAgICAgcmV0dXJuOwo+PiA+ICAKPj4gPiAgICAgICBmb3JfZWFjaF9l
bmdpbmUoZW5naW5lLCBkZXZfcHJpdiwgaWQpIHsKPj4gPiAtICAgICAgICAgICAgIHUzMiBjdXJy
ZW50X3NlcW5vID0gaW50ZWxfZW5naW5lX2dldF9zZXFubyhlbmdpbmUpOwo+PiA+IC0gICAgICAg
ICAgICAgdTMyIGxhc3Rfc2Vxbm8gPSBpbnRlbF9lbmdpbmVfbGFzdF9zdWJtaXQoZW5naW5lKTsK
Pj4gPiArICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfcG11ICpwbXUgPSAmZW5naW5l
LT5wbXU7Cj4+ID4gKyAgICAgICAgICAgICBib29sIGJ1c3k7Cj4+ID4gICAgICAgICAgICAgICB1
MzIgdmFsOwo+PiA+ICAKPj4gPiAtICAgICAgICAgICAgIHZhbCA9ICFpOTE1X3NlcW5vX3Bhc3Nl
ZChjdXJyZW50X3NlcW5vLCBsYXN0X3NlcW5vKTsKPj4gPiAtCj4+ID4gLSAgICAgICAgICAgICBp
ZiAodmFsKQo+PiA+IC0gICAgICAgICAgICAgICAgICAgICBhZGRfc2FtcGxlKCZlbmdpbmUtPnBt
dS5zYW1wbGVbSTkxNV9TQU1QTEVfQlVTWV0sCj4+ID4gLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgcGVyaW9kX25zKTsKPj4gPiAtCj4+ID4gLSAgICAgICAgICAgICBpZiAodmFsICYm
IChlbmdpbmUtPnBtdS5lbmFibGUgJgo+PiA+IC0gICAgICAgICAgICAgICAgIChCSVQoSTkxNV9T
QU1QTEVfV0FJVCkgfCBCSVQoSTkxNV9TQU1QTEVfU0VNQSkpKSkgewo+PiA+IC0gICAgICAgICAg
ICAgICAgICAgICBmdyA9IGdyYWJfZm9yY2V3YWtlKGRldl9wcml2LCBmdyk7Cj4+ID4gLQo+PiA+
IC0gICAgICAgICAgICAgICAgICAgICB2YWwgPSBJOTE1X1JFQURfRlcoUklOR19DVEwoZW5naW5l
LT5tbWlvX2Jhc2UpKTsKPj4gPiAtICAgICAgICAgICAgIH0gZWxzZSB7Cj4+ID4gLSAgICAgICAg
ICAgICAgICAgICAgIHZhbCA9IDA7Cj4+ID4gLSAgICAgICAgICAgICB9Cj4+ID4gKyAgICAgICAg
ICAgICB2YWwgPSBJOTE1X1JFQURfRlcoUklOR19DVEwoZW5naW5lLT5tbWlvX2Jhc2UpKTsKPj4g
PiArICAgICAgICAgICAgIGlmICh2YWwgPT0gMCkgLyogcG93ZXJ3ZWxsIG9mZiA9PiBlbmdpbmUg
aWRsZSAqLwo+PiA+ICsgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPj4gPiAgCj4+ID4g
ICAgICAgICAgICAgICBpZiAodmFsICYgUklOR19XQUlUKQo+PiA+IC0gICAgICAgICAgICAgICAg
ICAgICBhZGRfc2FtcGxlKCZlbmdpbmUtPnBtdS5zYW1wbGVbSTkxNV9TQU1QTEVfV0FJVF0sCj4+
ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGVyaW9kX25zKTsKPj4gPiAtCj4+
ID4gKyAgICAgICAgICAgICAgICAgICAgIGFkZF9zYW1wbGUoJnBtdS0+c2FtcGxlW0k5MTVfU0FN
UExFX1dBSVRdLCBwZXJpb2RfbnMpOwo+PiA+ICAgICAgICAgICAgICAgaWYgKHZhbCAmIFJJTkdf
V0FJVF9TRU1BUEhPUkUpCj4+ID4gLSAgICAgICAgICAgICAgICAgICAgIGFkZF9zYW1wbGUoJmVu
Z2luZS0+cG11LnNhbXBsZVtJOTE1X1NBTVBMRV9TRU1BXSwKPj4gPiAtICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBwZXJpb2RfbnMpOwo+PiA+IC0gICAgIH0KPj4gPiArICAgICAgICAg
ICAgICAgICAgICAgYWRkX3NhbXBsZSgmcG11LT5zYW1wbGVbSTkxNV9TQU1QTEVfU0VNQV0sIHBl
cmlvZF9ucyk7Cj4+ID4gIAo+PiA+IC0gICAgIGlmIChmdykKPj4gPiAtICAgICAgICAgICAgIGlu
dGVsX3VuY29yZV9mb3JjZXdha2VfcHV0KGRldl9wcml2LCBGT1JDRVdBS0VfQUxMKTsKPj4gPiAr
ICAgICAgICAgICAgIC8qCj4+ID4gKyAgICAgICAgICAgICAgKiBNSV9NT0RFIHJlcG9ydHMgSURM
RSBpZiB0aGUgcmluZyBpcyB3YWl0aW5nLCBidXQgd2UgcmVnYXJkCj4+ID4gKyAgICAgICAgICAg
ICAgKiB0aGlzIGFzIGJlaW5nIGJ1c3kgaW5zdGVhZCwgYXMgdGhlIGVuZ2luZSBpcyBidXN5IHdp
dGggdGhlCj4+ID4gKyAgICAgICAgICAgICAgKiB1c2VyIHJlcXVlc3QuCj4+ID4gKyAgICAgICAg
ICAgICAgKi8KPj4gPiArICAgICAgICAgICAgIGJ1c3kgPSB2YWwgJiAoUklOR19XQUlUX1NFTUFQ
SE9SRSB8IFJJTkdfV0FJVCk7Cj4+ID4gKyAgICAgICAgICAgICBpZiAoIWJ1c3kpIHsKPj4gPiAr
ICAgICAgICAgICAgICAgICAgICAgdmFsID0gSTkxNV9SRUFEX0ZXKFJJTkdfTUlfTU9ERShlbmdp
bmUtPm1taW9fYmFzZSkpOwo+PiA+ICsgICAgICAgICAgICAgICAgICAgICBidXN5ID0gISh2YWwg
JiBNT0RFX0lETEUpOwo+PiAKPj4gVGhlIGNvbW1lbnQgbWFrZXMgc2Vuc2UgaWYgeW91IGRvCj4+
IGJ1c3kgPSB2YWwgJiBNT0RFX0lETEU7Cj4KPiAvKgo+ICAqIFdoaWxlIHdhaXRpbmcgb24gYSBz
ZW1hcGhvcmUgb3IgZXZlbnQsIE1JX01PREUgcmVwb3J0cyB0aGUgcmluZyBhcwo+ICAqIGlkbGUu
IEhvd2V2ZXIsIHByZXZpb3VzbHkgdXNpbmcgdGhlIHNlcW5vLCBhbmQgd2l0aCBleGVjbGlzdHMg
c2FtcGxpbmcsCj4gICogd2UgYWNjb3VudCBmb3IgdGhlIHJpbmcgd2FpdGluZyBhcyB0aGUgZW5n
aW5lIGJlaW5nIGJ1c3kuIFRoZXJlZm9yZSwKPiAgKiB3ZSByZWNvcmQgdGhlIHNhbXBsZSBhcyBi
ZWluZyBidXN5IGlmIGVpdGhlciB3YWl0aW5nIG9yICFpZGxlLgo+ICAqLwoKQWx0aG8gbm93IHRo
ZSBvcmlnaW5hbCBtYWtlcyBtb3JlIHNlbnNlIHRvbywgSSBsaWtlIHRoaXMgb25lIGJldHRlciEK
ClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNv
bT4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs
LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov
L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==