Re: [PATCH 07/25] drm/i915: Trim delays for wedging

Mika Kuoppala
2019-02-19T12:48:26Z

Chris Wilson <chris@chris-wilson.co.uk> writes:

> CI still reports the occasional multi-second delay for resets, in
> particular along the wedge+recovery paths. As the likely, and unbounded,
> delay here is from sync_rcu, use the expedited variant instead.
>
> Testcase: igt/gem_eio/unwedge-stress
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
> drivers/gpu/drm/i915/i915_reset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reset.c b/drivers/gpu/drm/i915/i915_reset.c
> index 358ab1d51570..9f6da5e4b007 100644
> --- a/drivers/gpu/drm/i915/i915_reset.c
> +++ b/drivers/gpu/drm/i915/i915_reset.c
> @@ -835,7 +835,7 @@ static void __i915_gem_set_wedged(struct drm_i915_private *i915)
> * either this call here to intel_engine_write_global_seqno, or the one
> * in nop_submit_request.
> */
> - synchronize_rcu();
> + synchronize_rcu_expedited();
>
> /* Mark all executing requests as skipped */
> for_each_engine(engine, i915, id)
> --
> 2.20.1