✗ Fi.CI.CHECKPATCH: warning for series starting with [01/25] drm/i915: Move verify_wm_state() to heap

Patchwork
2019-02-19T13:05:42Z

== Series Details ==

Series: series starting with [01/25] drm/i915: Move verify_wm_state() to heap
URL : https://patchwork.freedesktop.org/series/56895/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
297cf65379fb drm/i915: Move verify_wm_state() to heap
5d4b26b32831 drm/i915: Use time based guilty context banning
85102762750a drm/i915: Prevent user context creation while wedged
89678d92f27e drm/i915: Avoid reset lock in writing fence registers
-:23: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#23:
<4> [125.739679] 00000000a730190a (&dev_priv->gpu_error.reset_backoff_srcu){+.+.}, at: i915_reset_trylock+0x0/0x310 [i915]

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
3ea835086530 drm/i915: Reorder struct_mutex-vs-reset_lock in i915_gem_fault()
fb5e6eae6d83 drm/i915: Trim i915_do_reset() to minimum delays
-:21: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#21: FILE: drivers/gpu/drm/i915/i915_reset.c:170:
+ udelay(20);

-:27: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#27: FILE: drivers/gpu/drm/i915/i915_reset.c:175:
+ udelay(20);

total: 0 errors, 0 warnings, 2 checks, 14 lines checked
d24387682d04 drm/i915: Trim delays for wedging
ffa0c4796c50 drm/i915/pmu: Always sample an active ringbuffer
b591a28bf74f drm/i915: Replace global_seqno with a hangcheck heartbeat seqno
435800fa983d drm/i915: Remove access to global seqno in the HWSP
25c28490b7ed drm/i915: Remove i915_request.global_seqno
b3d7cdcd0ead drm/i915/selftests: Exercise resetting during non-user payloads
-:35: WARNING:LINE_SPACING: Missing a blank line after declarations
#35: FILE: drivers/gpu/drm/i915/selftests/intel_hangcheck.c:427:
+ struct drm_file *file;
+ IGT_TIMEOUT(end_time);

-:154: WARNING:LINE_SPACING: Missing a blank line after declarations
#154: FILE: drivers/gpu/drm/i915/selftests/intel_hangcheck.c:546:
+ unsigned int count;
+ IGT_TIMEOUT(end_time);

total: 0 errors, 2 warnings, 0 checks, 230 lines checked
28bacfa762ca drm/i915: Reduce the RPS shock
-:32: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> (" ")' - ie: 'commit 0d55babc8392 ("drm/i915: Drop stray clearing of rps->last_adj")'
#32:
References: 0d55babc8392 ("drm/i915: Drop stray clearing of rps->last_adj")

-:33: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> (" ")' - ie: 'commit 60548c554be2 ("drm/i915: Interactive RPS mode")'
#33:
References: 60548c554be2 ("drm/i915: Interactive RPS mode")

total: 2 errors, 0 warnings, 0 checks, 18 lines checked
daf35758baa7 drm/i915/pmu: Use GT parked for estimating RC6 while asleep
f4dd099b254f drm/i915: Skip scanning for signalers if we are already inflight
c75163d88a44 drm/i915/execlists: Suppress mere WAIT preemption
8421bba99b2f drm/i915/execlists: Suppress redundant preemption
d3469eadd959 drm/i915: Make request allocation caches global
-:162: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#162:
new file mode 100644

-:167: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#167: FILE: drivers/gpu/drm/i915/i915_globals.c:1:
+/*

-:286: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#286: FILE: drivers/gpu/drm/i915/i915_globals.h:1:
+/*

-:627: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#627: FILE: drivers/gpu/drm/i915/i915_scheduler.h:95:
+#define priolist_for_each_request(it, plist, idx) \
+ for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+ list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:627: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#627: FILE: drivers/gpu/drm/i915/i915_scheduler.h:95:
+#define priolist_for_each_request(it, plist, idx) \
+ for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+ list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:631: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#631: FILE: drivers/gpu/drm/i915/i915_scheduler.h:99:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+ for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+ list_for_each_entry_safe(it, n, \
+ &(plist)->requests[idx - 1], \
+ sched.link)

-:631: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#631: FILE: drivers/gpu/drm/i915/i915_scheduler.h:99:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+ for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+ list_for_each_entry_safe(it, n, \
+ &(plist)->requests[idx - 1], \
+ sched.link)

total: 0 errors, 3 warnings, 4 checks, 808 lines checked
4ace7a1a1640 drm/i915: Introduce i915_timeline.mutex
f9cf6b93dd12 drm/i915: Keep timeline HWSP allocated until idle across the system
5c7d5f3e9173 drm/i915: Compute the global scheduler caps
21059fb9f4ad drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+
-:334: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#334: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:109:
+#define MI_SEMAPHORE_SAD_GT_SDD (0<<12)
^

-:336: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#336: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:111:
+#define MI_SEMAPHORE_SAD_LT_SDD (2<<12)
^

-:337: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#337: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:112:
+#define MI_SEMAPHORE_SAD_LTE_SDD (3<<12)
^

-:338: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#338: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:113:
+#define MI_SEMAPHORE_SAD_EQ_SDD (4<<12)
^

-:339: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#339: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:114:
+#define MI_SEMAPHORE_SAD_NEQ_SDD (5<<12)
^

total: 0 errors, 0 warnings, 5 checks, 299 lines checked
c2fa0a72ef2f drm/i915: Prioritise non-busywait semaphore workloads
507ffad016de drm/i915/execlists: Skip direct submission if only lite-restore
ac98d5de17a0 drm/i915: Use __ffs() in for_each_priolist for more compact code