Re: [PATCH 03/25] drm/i915: Prevent user context creation while wedged

Mika Kuoppala
2019-02-19T13:31:47Z

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2019-02-19 13:07:08)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Introduce a new ABI method for detecting a wedged driver by reporting
>> > -EIO from DRM_IOCTL_I915_GEM_CONTEXT_CREATE.
>>
>> Need more on the 'why' department. What is lacking with
>> the method of submitting and noticing the wedged?
>
> This fits in with
>
> https://lists.freedesktop.org/archives/mesa-dev/2019-February/215469.html
>
> where we are recreating the contexting the context after receiving the
> -EIO from execbuf and so this allows us to actually break that loop if
> the driver is wedged.
>
>> Also detecting banned from wedged is not trivial.
>
> We are not detecting banned per-se, just saying that if the driver is
> wedged.

Yes. I was meaning that you will now get -EIO from both wedged
driver and from banned client and you can't tell em apart.
Not that you would need to :O

Add that mesa commit as a reference? (even tho I didn't notice
it setting unrecoverable as it boldy promised :)

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

-Mika