From: Jani Nikula <jani.nikula@intel.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 2/2] dim: sign pull-request tags if the GPG key is configured
Date: Mon, 02 Oct 2017 17:05:12 +0300 [thread overview]
Message-ID: <8760bx63xj.fsf@intel.com> (raw)
In-Reply-To: <87lgkt6h18.fsf@intel.com>
On Mon, 02 Oct 2017, Jani Nikula <jani.nikula@intel.com> wrote:
> On Mon, 11 Sep 2017, Sean Paul <seanpaul@chromium.org> wrote:
>> On Mon, Sep 11, 2017 at 9:16 AM, Jani Nikula <jani.nikula@intel.com> wrote:
>>> Add new environment variable $DIM_GPG_KEYID for configuring the GPG key
>>> ID of the key to use for signing tags for pull requests. The tags will
>>> be signed if the key ID is set, otherwise annotated tags will be used
>>> like before.
>>>
>>> The drm-intel-testing tags are left unsigned, at least for now.
>>>
>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Cc: Sean Paul <seanpaul@chromium.org>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>
>>> ---
>>>
>>> BEWARE OF THE LEOPARD! I didn't actually test this. I will try it when I
>>> need to tag something next.
>>>
>>
>> Just comment out git push and test this?
>
> Finally got around to trying this out, works fine:
> https://cgit.freedesktop.org/drm-intel/tag/?id=drm-intel-next-2017-09-29
>
> The only snag is that now prep_pull_mail_overview() picks up the
> signature from the tag object to the overview too.
>
> Ack on merging these two out of the way, and fixing that separately (a
> tiny bit of sed)?
I pushed these two and the sed bit to strip signatures with Daniel's
acks.
You can now add
DIM_GPG_KEYID=<your-key-id>
to ~/.dimrc to have dim sign the tags.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-02 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 13:15 [PATCH 1/2] dim: make dim tag-next generate annotated tags Jani Nikula
2017-09-11 13:16 ` [PATCH 2/2] dim: sign pull-request tags if the GPG key is configured Jani Nikula
2017-09-11 15:17 ` Sean Paul
2017-10-02 9:22 ` Jani Nikula
2017-10-02 14:05 ` Jani Nikula [this message]
2017-09-11 13:31 ` [PATCH 1/2] dim: make dim tag-next generate annotated tags Ewelina Musial
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760bx63xj.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox