From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH i-g-t v4] lib/debugfs: Support new generic
	ABI	for CRC capture
Date: Fri, 23 Dec 2016 10:31:48 +0200
Message-ID: <8760mbrqq3.fsf@intel.com>
References: <1480930218-32019-1-git-send-email-tomeu.vizoso@collabora.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 0C2426F483
 for <intel-gfx@lists.freedesktop.org>; Fri, 23 Dec 2016 08:31:56 +0000 (UTC)
In-Reply-To: <1480930218-32019-1-git-send-email-tomeu.vizoso@collabora.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Intel GFX discussion <intel-gfx@lists.freedesktop.org>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAwNSBEZWMgMjAxNiwgVG9tZXUgVml6b3NvIDx0b21ldS52aXpvc29AY29sbGFib3Jh
LmNvbT4gd3JvdGU6Cj4gVGhlIGtlcm5lbCBoYXMgbm93IGEgbmV3IGRlYnVnZnMgQUJJIHRoYXQg
Y2FuIGFsc28gYWxsb3cgY2FwdHVyaW5nIGZyYW1lCj4gQ1JDcyBmb3IgZHJpdmVycyBvdGhlciB0
aGFuIGk5MTUuCj4KPiBBZGQgYWx0ZXJuYXRpdmUgY29kZXBhdGhzIHNvIHRoZSBuZXcgQUJJIGlz
IHVzZWQgaWYgdGhlIGtlcm5lbCBpcyByZWNlbnQKPiBlbm91Z2gsIGFuZCBmYWxsIGJhY2sgdG8g
dGhlIGxlZ2FjeSBBQkkgaWYgbm90Lgo+Cj4gU2lnbmVkLW9mZi1ieTogVG9tZXUgVml6b3NvIDx0
b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4KCi4uLgoKPiAgc3RhdGljIGludCByZWFkX2NyYyhp
Z3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqb3V0KQo+ICB7Cj4gIAlzc2l6ZV90
IGJ5dGVzX3JlYWQ7Cj4gLQljaGFyIGJ1ZltwaXBlX2NyYy0+YnVmZmVyX2xlbl07Cj4gKwljaGFy
IGJ1ZltNQVhfTElORV9MRU4gKyAxXTsKPiArCXNpemVfdCByZWFkX2xlbjsKPiArCj4gKwlpZiAo
cGlwZV9jcmMtPmlzX2xlZ2FjeSkKPiArCQlyZWFkX2xlbiA9IExFR0FDWV9MSU5FX0xFTjsKPiAr
CWVsc2UKPiArCQlyZWFkX2xlbiA9IE1BWF9MSU5FX0xFTjsKPiAgCj4gIAlpZ3Rfc2V0X3RpbWVv
dXQoNSwgIkNSQyByZWFkaW5nIik7Cj4gLQlieXRlc19yZWFkID0gcmVhZChwaXBlX2NyYy0+Y3Jj
X2ZkLCAmYnVmLCBwaXBlX2NyYy0+bGluZV9sZW4pOwo+ICsJYnl0ZXNfcmVhZCA9IHJlYWQocGlw
ZV9jcmMtPmNyY19mZCwgJmJ1ZiwgcmVhZF9sZW4pOwo+ICAJaWd0X3Jlc2V0X3RpbWVvdXQoKTsK
PiAgCj4gIAlpZiAoYnl0ZXNfcmVhZCA8IDAgJiYgZXJybm8gPT0gRUFHQUlOKSB7Cj4gIAkJaWd0
X2Fzc2VydChwaXBlX2NyYy0+ZmxhZ3MgJiBPX05PTkJMT0NLKTsKPiAgCQlieXRlc19yZWFkID0g
MDsKPiAtCX0gZWxzZSB7Cj4gLQkJaWd0X2Fzc2VydF9lcShieXRlc19yZWFkLCBwaXBlX2NyYy0+
bGluZV9sZW4pOwo+ICAJfQoKTGVhdmluZyBvdXQgdGhlIGVsc2UgYnJhbmNoIGxlYWRzIHRvCgpp
Z3RfZGVidWdmcy5jOiBJbiBmdW5jdGlvbiAncmVhZF9jcmMnOgppZ3RfZGVidWdmcy5jOjYwNDo1
OiBlcnJvcjogYXJyYXkgc3Vic2NyaXB0IGlzIGJlbG93IGFycmF5IGJvdW5kcyBbLVdlcnJvcj1h
cnJheS1ib3VuZHNdCiAgYnVmW2J5dGVzX3JlYWRdID0gJ1wwJzsKICAgICBeCgphcyBieXRlc19y
ZWFkIG1heSBlbmQgdXAgYmVpbmcgPCAwLgoKQlIsCkphbmkuCgoKPiAgCWJ1ZltieXRlc19yZWFk
XSA9ICdcMCc7Cj4gIAo+IC0JaWYgKGJ5dGVzX3JlYWQgJiYgIXBpcGVfY3JjX2luaXRfZnJvbV9z
dHJpbmcob3V0LCBidWYpKQo+ICsJaWYgKGJ5dGVzX3JlYWQgJiYgIXBpcGVfY3JjX2luaXRfZnJv
bV9zdHJpbmcocGlwZV9jcmMsIG91dCwgYnVmKSkKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4g
IAlyZXR1cm4gYnl0ZXNfcmVhZDsKPiBAQCAtNTMwLDE1ICs2MTAsMTggQEAgdm9pZCBpZ3RfcGlw
ZV9jcmNfc3RhcnQoaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjKQo+ICAKPiAgCWlndF9hc3NlcnQo
aWd0X3BpcGVfY3JjX2RvX3N0YXJ0KHBpcGVfY3JjKSk7Cj4gIAo+IC0JLyoKPiAtCSAqIEZvciBz
b21lIG5vIHlldCBpZGVudGlmaWVkIHJlYXNvbiwgdGhlIGZpcnN0IENSQyBpcyBib25rZXJzLiBT
bwo+IC0JICogbGV0J3MganVzdCB3YWl0IGZvciB0aGUgbmV4dCB2YmxhbmsgYW5kIHJlYWQgb3V0
IHRoZSBidWdneSByZXN1bHQuCj4gLQkgKgo+IC0JICogT24gQ0hWIHNvbWV0aW1lcyB0aGUgc2Vj
b25kIENSQyBpcyBib25rZXJzIGFzIHdlbGwsIHNvIGRvbid0IHRydXN0Cj4gLQkgKiB0aGF0IG9u
ZSBlaXRoZXIuCj4gLQkgKi8KPiAtCXJlYWRfb25lX2NyYyhwaXBlX2NyYywgJmNyYyk7Cj4gLQly
ZWFkX29uZV9jcmMocGlwZV9jcmMsICZjcmMpOwo+ICsJaWYgKHBpcGVfY3JjLT5pc19sZWdhY3kp
IHsKPiArCQkvKgo+ICsJCSAqIEZvciBzb21lIG5vIHlldCBpZGVudGlmaWVkIHJlYXNvbiwgdGhl
IGZpcnN0IENSQyBpcwo+ICsJCSAqIGJvbmtlcnMuIFNvIGxldCdzIGp1c3Qgd2FpdCBmb3IgdGhl
IG5leHQgdmJsYW5rIGFuZCByZWFkCj4gKwkJICogb3V0IHRoZSBidWdneSByZXN1bHQuCj4gKwkJ
ICoKPiArCQkgKiBPbiBDSFYgc29tZXRpbWVzIHRoZSBzZWNvbmQgQ1JDIGlzIGJvbmtlcnMgYXMg
d2VsbCwgc28KPiArCQkgKiBkb24ndCB0cnVzdCB0aGF0IG9uZSBlaXRoZXIuCj4gKwkJICovCj4g
KwkJcmVhZF9vbmVfY3JjKHBpcGVfY3JjLCAmY3JjKTsKPiArCQlyZWFkX29uZV9jcmMocGlwZV9j
cmMsICZjcmMpOwo+ICsJfQo+ICB9Cj4gIAo+ICAvKioKPiBAQCAtNTUxLDggKzYzNCwxNSBAQCB2
b2lkIGlndF9waXBlX2NyY19zdG9wKGlndF9waXBlX2NyY190ICpwaXBlX2NyYykKPiAgewo+ICAJ
Y2hhciBidWZbMzJdOwo+ICAKPiAtCXNwcmludGYoYnVmLCAicGlwZSAlcyBub25lIiwga21zdGVz
dF9waXBlX25hbWUocGlwZV9jcmMtPnBpcGUpKTsKPiAtCWlndF9hc3NlcnRfZXEod3JpdGUocGlw
ZV9jcmMtPmN0bF9mZCwgYnVmLCBzdHJsZW4oYnVmKSksIHN0cmxlbihidWYpKTsKPiArCWlmIChw
aXBlX2NyYy0+aXNfbGVnYWN5KSB7Cj4gKwkJc3ByaW50ZihidWYsICJwaXBlICVzIG5vbmUiLAo+
ICsJCQlrbXN0ZXN0X3BpcGVfbmFtZShwaXBlX2NyYy0+cGlwZSkpOwo+ICsJCWlndF9hc3NlcnRf
ZXEod3JpdGUocGlwZV9jcmMtPmN0bF9mZCwgYnVmLCBzdHJsZW4oYnVmKSksCj4gKwkJCSAgICAg
IHN0cmxlbihidWYpKTsKPiArCX0gZWxzZSB7Cj4gKwkJY2xvc2UocGlwZV9jcmMtPmNyY19mZCk7
Cj4gKwkJcGlwZV9jcmMtPmNyY19mZCA9IC0xOwo+ICsJfQo+ICB9Cj4gIAo+ICAvKioKPiBkaWZm
IC0tZ2l0IGEvbGliL2lndF9kZWJ1Z2ZzLmggYi9saWIvaWd0X2RlYnVnZnMuaAo+IGluZGV4IGZi
MTg5MzIyNjMzZi4uNGM2NTcyY2QyNDRjIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZGVidWdmcy5o
Cj4gKysrIGIvbGliL2lndF9kZWJ1Z2ZzLmgKPiBAQCAtNjIsNiArNjIsNyBAQCBib29sIGlndF9k
ZWJ1Z2ZzX3NlYXJjaChjb25zdCBjaGFyICpmaWxlbmFtZSwgY29uc3QgY2hhciAqc3Vic3RyaW5n
KTsKPiAgICovCj4gIHR5cGVkZWYgc3RydWN0IF9pZ3RfcGlwZV9jcmMgaWd0X3BpcGVfY3JjX3Q7
Cj4gIAo+ICsjZGVmaW5lIERSTV9NQVhfQ1JDX05SIDEwCj4gIC8qKgo+ICAgKiBpZ3RfY3JjX3Q6
Cj4gICAqIEBmcmFtZTogZnJhbWUgbnVtYmVyIG9mIHRoZSBjYXB0dXJlIENSQwo+IEBAIC03Myw4
ICs3NCw5IEBAIHR5cGVkZWYgc3RydWN0IF9pZ3RfcGlwZV9jcmMgaWd0X3BpcGVfY3JjX3Q7Cj4g
ICAqLwo+ICB0eXBlZGVmIHN0cnVjdCB7Cj4gIAl1aW50MzJfdCBmcmFtZTsKPiArCWJvb2wgaGFz
X3ZhbGlkX2ZyYW1lOwo+ICAJaW50IG5fd29yZHM7Cj4gLQl1aW50MzJfdCBjcmNbNV07Cj4gKwl1
aW50MzJfdCBjcmNbRFJNX01BWF9DUkNfTlJdOwo+ICB9IGlndF9jcmNfdDsKPiAgCj4gIC8qKgo+
IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfcGlwZV9jcmNfYmFzaWMuYyBiL3Rlc3RzL2ttc19waXBl
X2NyY19iYXNpYy5jCj4gaW5kZXggMDRkNWExMzQ1NzYwLi5iMTA2ZjliZDA1ZWUgMTAwNjQ0Cj4g
LS0tIGEvdGVzdHMva21zX3BpcGVfY3JjX2Jhc2ljLmMKPiArKysgYi90ZXN0cy9rbXNfcGlwZV9j
cmNfYmFzaWMuYwo+IEBAIC00OSw2ICs0OSw4IEBAIHN0YXRpYyB2b2lkIHRlc3RfYmFkX2NvbW1h
bmQoZGF0YV90ICpkYXRhLCBjb25zdCBjaGFyICpjbWQpCj4gIAlzaXplX3Qgd3JpdHRlbjsKPiAg
Cj4gIAljdGwgPSBpZ3RfZGVidWdmc19mb3BlbigiaTkxNV9kaXNwbGF5X2NyY19jdGwiLCAicisi
KTsKPiArCWlndF9yZXF1aXJlKGN0bCk7Cj4gKwo+ICAJd3JpdHRlbiA9IGZ3cml0ZShjbWQsIDEs
IHN0cmxlbihjbWQpLCBjdGwpOwo+ICAJZmZsdXNoKGN0bCk7Cj4gIAlpZ3RfYXNzZXJ0X2VxKHdy
aXR0ZW4sIHN0cmxlbihjbWQpKTsKPiBAQCAtNTgsNiArNjAsMzAgQEAgc3RhdGljIHZvaWQgdGVz
dF9iYWRfY29tbWFuZChkYXRhX3QgKmRhdGEsIGNvbnN0IGNoYXIgKmNtZCkKPiAgCWZjbG9zZShj
dGwpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCB0ZXN0X2JhZF9zb3VyY2UoZGF0YV90ICpkYXRh
KQo+ICt7Cj4gKwlGSUxFICpmOwo+ICsJc2l6ZV90IHdyaXR0ZW47Cj4gKwljb25zdCBjaGFyICpz
b3VyY2UgPSAiZm9vIjsKPiArCj4gKwlmID0gaWd0X2RlYnVnZnNfZm9wZW4oImNydGMtMC9jcmMv
Y29udHJvbCIsICJ3Iik7Cj4gKwlpZiAoIWYpIHsKPiArCQl0ZXN0X2JhZF9jb21tYW5kKGRhdGEs
ICJwaXBlIEEgZm9vIik7Cj4gKwkJcmV0dXJuOwo+ICsJfQo+ICsKPiArCXdyaXR0ZW4gPSBmd3Jp
dGUoc291cmNlLCAxLCBzdHJsZW4oc291cmNlKSwgZik7Cj4gKwlmZmx1c2goZik7Cj4gKwlpZ3Rf
YXNzZXJ0X2VxKHdyaXR0ZW4sIHN0cmxlbihzb3VyY2UpKTsKPiArCWlndF9hc3NlcnQoIWZlcnJv
cihmKSk7Cj4gKwlpZ3RfYXNzZXJ0KCFlcnJubyk7Cj4gKwlmY2xvc2UoZik7Cj4gKwo+ICsJZiA9
IGlndF9kZWJ1Z2ZzX2ZvcGVuKCJjcnRjLTAvY3JjL2RhdGEiLCAidyIpOwo+ICsJaWd0X2Fzc2Vy
dCghZik7Cj4gKwlpZ3RfYXNzZXJ0X2VxKGVycm5vLCBFSU5WQUwpOwo+ICt9Cj4gKwo+ICAjZGVm
aW5lIE5fQ1JDUwkzCj4gIAo+ICAjZGVmaW5lIFRFU1RfU0VRVUVOQ0UgKDE8PDApCj4gQEAgLTE4
NSw3ICsyMTEsNyBAQCBpZ3RfbWFpbgo+ICAJaWd0X3NraXBfb25fc2ltdWxhdGlvbigpOwo+ICAK
PiAgCWlndF9maXh0dXJlIHsKPiAtCQlkYXRhLmRybV9mZCA9IGRybV9vcGVuX2RyaXZlcl9tYXN0
ZXIoRFJJVkVSX0lOVEVMKTsKPiArCQlkYXRhLmRybV9mZCA9IGRybV9vcGVuX2RyaXZlcl9tYXN0
ZXIoRFJJVkVSX0FOWSk7Cj4gIAo+ICAJCWlndF9lbmFibGVfY29ubmVjdG9ycygpOwo+ICAKPiBA
QCAtMjAwLDcgKzIyNiw3IEBAIGlndF9tYWluCj4gIAkJdGVzdF9iYWRfY29tbWFuZCgmZGF0YSwg
InBpcGUgRCBub25lIik7Cj4gIAo+ICAJaWd0X3N1YnRlc3QoImJhZC1zb3VyY2UiKQo+IC0JCXRl
c3RfYmFkX2NvbW1hbmQoJmRhdGEsICJwaXBlIEEgZm9vIik7Cj4gKwkJdGVzdF9iYWRfc291cmNl
KCZkYXRhKTsKPiAgCj4gIAlpZ3Rfc3VidGVzdCgiYmFkLW5iLXdvcmRzLTEiKQo+ICAJCXRlc3Rf
YmFkX2NvbW1hbmQoJmRhdGEsICJwaXBlIGZvbyIpOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBP
cGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK