From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3] drm/i915: Consider HW CSB write pointer before resetting the sw read pointer Date: Mon, 28 Sep 2015 17:30:41 +0300 Message-ID: <87612uk44u.fsf@intel.com> References: <1443019430-20792-1-git-send-email-michel.thierry@intel.com> <1443446247-13837-1-git-send-email-michel.thierry@intel.com> <878u7qabkj.fsf@gaia.fi.intel.com> <20150928141202.GX3383@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 032466E4C2 for ; Mon, 28 Sep 2015 07:27:22 -0700 (PDT) In-Reply-To: <20150928141202.GX3383@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyOCBTZXAgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBNb24sIFNlcCAyOCwgMjAxNSBhdCAwNTowMDoxMlBNICswMzAwLCBNaWthIEt1b3Bw YWxhIHdyb3RlOgo+PiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPiB3 cml0ZXM6Cj4+IAo+PiA+IEEgcHJldmlvdXMgY29tbWl0IHJlc2V0cyB0aGUgQ29udGV4dCBTdGF0 dXMgQnVmZmVyIChDU0IpIHJlYWQgcG9pbnRlciBpbgo+PiA+IHJpbmcgaW5pdAo+PiA+ICAgICBj b21taXQgYzBhMDNhMmU0YzRlICgiZHJtL2k5MTU6IFJlc2V0IENTQiByZWFkIHBvaW50ZXIgaW4g cmluZyBpbml0IikKPgo+IFRoaXMgaXMgaW4gNC4wLCBzbyBDYzogc3RhYmxlQHZnZXIua2VybmVs Lm9yZyBhbmQgb25lIGZvciBKYW5pLgo+IC1EYW5pZWwKPgo+PiA+Cj4+ID4gVGhpcyBpcyBnZW5l cmFsbHkgY29ycmVjdCwgYnV0IHRoaXMgcG9pbnRlciBpcyBub3QgcmVzZXQgYWZ0ZXIKPj4gPiBz dXNwZW5kL3Jlc3VtZSBpbiBzb21lIHBsYXRmb3JtcyAoY2h0KS4gSW4gdGhpcyBjYXNlLCB0aGUg ZHJpdmVyIHNob3VsZAo+PiA+IHJlYWQgdGhlIHJlZ2lzdGVyIHZhbHVlIGluc3RlYWQgb2YgcmVz ZXR0aW5nIHRoZSBzdyByZWFkIGNvdW50ZXIgdG8gMC4KPj4gPiBPdGhlcndpc2Ugd2UgcHJvY2Vz cyBvbGQgZXZlbnRzLCBsZWFkaW5nIHRvIHVud2FudGVkIHByZS1lbXB0aW9ucyBvcgo+PiA+IHNv bWV0aGluZyB3b3JzZS4KPj4gPgo+PiA+IEJ1dCBpbiBvdGhlciBwbGF0Zm9ybXMgKGJkdykgYW5k IGFsc28gZHVyaW5nIEdQVSByZXNldCBvciBwb3dlciB1cCwgdGhlCj4+ID4gQ1NCV1AgaXMgcmVz ZXQgdG8gMHg3IChhbiBpbnZhbGlkIG51bWJlciksIGFuZCBpbiB0aGlzIGNhc2UgdGhlIHJlYWQK Pj4gPiBwb2ludGVyIHNob3VsZCBiZSBzZXQgdG8gNSAodGhlIGludGVycnVwdCBjb2RlIHdpbGwg aW5jcmVtZW50IHRoaXMKPj4gPiBjb3VudGVyIG9uZSBtb3JlIHRpbWUsIGFuZCB3aWxsIHN0YXJ0 IHJlYWRpbmcgZnJvbSBDU0JbMF0pLgo+PiA+Cj4+ID4gdjI6IFdoZW4gdGhlIENTQiByZWdpc3Rl cnMgYXJlIHJlc2V0LCB0aGUgcmVhZCBwb2ludGVyIG5lZWRzIHRvIGJlIHNldAo+PiA+IHRvIDUs IG90aGVyd2lzZSB0aGUgZmlyc3Qgd3JpdGUgKENTQlswXSkgd29uJ3QgYmUgcmVhZCAoTWlrYSku Cj4+ID4gUmVwbGFjZSBtYWdpYyBudW1iZXJzIHdpdGggR0VOOF9DU0JfRU5UUklFUyAoNikgYW5k IEdFTjhfQ1NCX1BUUl9NQVNLCj4+ID4gKDB4MDcpLgo+PiA+IHYzOiBSZWJhc2VkIG9uIHRvcCBv ZiAiUGFyYW1ldHJpemUgTFJDIHJlZ2lzdGVycyIgcGF0Y2guCgpQdXNoZWQgdjIgdG8gZHJtLWlu dGVsLWZpeGVzLCBhcyB0aGF0IGJyYW5jaCBkb2Vzbid0IGhhdmUgdGhlCiJQYXJhbWV0cml6ZSBM UkMgcmVnaXN0ZXJzIiBwYXRjaCwgdGhhbmtzIGZvciB0aGUgcGF0Y2ggYW5kIHJldmlldy4KCkJS LApKYW5pLgoKCj4+ID4KPj4gPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51 eC5pbnRlbC5jb20+Cj4+ID4gU2lnbmVkLW9mZi1ieTogTGVpIFNoZW4gPGxlaS5zaGVuQGludGVs LmNvbT4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBEZWVwYWsgUyA8ZGVlcGFrLnNAaW50ZWwuY29tPgo+ PiA+IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5j b20+Cj4+ID4gLS0tCj4+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMzkg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5oIHwgIDIgKysKPj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAzNCBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+PiA+Cj4+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMKPj4gPiBpbmRleCAyNTYxNjdiLi44MjVmYTdhIDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMKPj4gPiBAQCAtNTExLDE2ICs1MTEsMTYgQEAgdm9pZCBpbnRlbF9scmNf aXJxX2hhbmRsZXIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPj4gPiAgCXN0YXR1c19w b2ludGVyID0gSTkxNV9SRUFEKFJJTkdfQ09OVEVYVF9TVEFUVVNfUFRSKHJpbmcpKTsKPj4gPiAg Cj4+ID4gIAlyZWFkX3BvaW50ZXIgPSByaW5nLT5uZXh0X2NvbnRleHRfc3RhdHVzX2J1ZmZlcjsK Pj4gPiAtCXdyaXRlX3BvaW50ZXIgPSBzdGF0dXNfcG9pbnRlciAmIDB4MDc7Cj4+ID4gKwl3cml0 ZV9wb2ludGVyID0gc3RhdHVzX3BvaW50ZXIgJiBHRU44X0NTQl9QVFJfTUFTSzsKPj4gPiAgCWlm IChyZWFkX3BvaW50ZXIgPiB3cml0ZV9wb2ludGVyKQo+PiA+IC0JCXdyaXRlX3BvaW50ZXIgKz0g NjsKPj4gPiArCQl3cml0ZV9wb2ludGVyICs9IEdFTjhfQ1NCX0VOVFJJRVM7Cj4+ID4gIAo+PiA+ ICAJc3Bpbl9sb2NrKCZyaW5nLT5leGVjbGlzdF9sb2NrKTsKPj4gPiAgCj4+ID4gIAl3aGlsZSAo cmVhZF9wb2ludGVyIDwgd3JpdGVfcG9pbnRlcikgewo+PiA+ICAJCXJlYWRfcG9pbnRlcisrOwo+ PiA+IC0JCXN0YXR1cyA9IEk5MTVfUkVBRChSSU5HX0NPTlRFWFRfU1RBVFVTX0JVRl9MTyhyaW5n LCByZWFkX3BvaW50ZXIgJSA2KSk7Cj4+ID4gLQkJc3RhdHVzX2lkID0gSTkxNV9SRUFEKFJJTkdf Q09OVEVYVF9TVEFUVVNfQlVGX0hJKHJpbmcsIHJlYWRfcG9pbnRlciAlIDYpKTsKPj4gPiArCQlz dGF0dXMgPSBJOTE1X1JFQUQoUklOR19DT05URVhUX1NUQVRVU19CVUZfTE8ocmluZywgcmVhZF9w b2ludGVyICUgR0VOOF9DU0JfRU5UUklFUykpOwo+PiA+ICsJCXN0YXR1c19pZCA9IEk5MTVfUkVB RChSSU5HX0NPTlRFWFRfU1RBVFVTX0JVRl9ISShyaW5nLCByZWFkX3BvaW50ZXIgJSBHRU44X0NT Ql9FTlRSSUVTKSk7Cj4+ID4gIAo+PiA+ICAJCWlmIChzdGF0dXMgJiBHRU44X0NUWF9TVEFUVVNf SURMRV9BQ1RJVkUpCj4+ID4gIAkJCWNvbnRpbnVlOwo+PiA+IEBAIC01NTIsMTAgKzU1MiwxMiBA QCB2b2lkIGludGVsX2xyY19pcnFfaGFuZGxlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5n KQo+PiA+ICAJc3Bpbl91bmxvY2soJnJpbmctPmV4ZWNsaXN0X2xvY2spOwo+PiA+ICAKPj4gPiAg CVdBUk4oc3VibWl0X2NvbnRleHRzID4gMiwgIk1vcmUgdGhhbiB0d28gY29udGV4dCBjb21wbGV0 ZSBldmVudHM/XG4iKTsKPj4gPiAtCXJpbmctPm5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyID0g d3JpdGVfcG9pbnRlciAlIDY7Cj4+ID4gKwlyaW5nLT5uZXh0X2NvbnRleHRfc3RhdHVzX2J1ZmZl ciA9IHdyaXRlX3BvaW50ZXIgJSBHRU44X0NTQl9FTlRSSUVTOwo+PiA+ICAKPj4gPiAgCUk5MTVf V1JJVEUoUklOR19DT05URVhUX1NUQVRVU19QVFIocmluZyksCj4+ID4gLQkJICAgX01BU0tFRF9G SUVMRCgweDA3IDw8IDgsICgodTMyKXJpbmctPm5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyICYg MHgwNykgPDwgOCkpOwo+PiA+ICsJCSAgIF9NQVNLRURfRklFTEQoR0VOOF9DU0JfUFRSX01BU0sg PDwgOCwKPj4gPiArCQkJCSAoKHUzMilyaW5nLT5uZXh0X2NvbnRleHRfc3RhdHVzX2J1ZmZlciAm Cj4+ID4gKwkJCQkgIEdFTjhfQ1NCX1BUUl9NQVNLKSA8PCA4KSk7Cj4+ID4gIH0KPj4gPiAgCj4+ ID4gIHN0YXRpYyBpbnQgZXhlY2xpc3RzX2NvbnRleHRfcXVldWUoc3RydWN0IGRybV9pOTE1X2dl bV9yZXF1ZXN0ICpyZXF1ZXN0KQo+PiA+IEBAIC0xNDc3LDYgKzE0NzksNyBAQCBzdGF0aWMgaW50 IGdlbjhfaW5pdF9jb21tb25fcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+PiA+ ICB7Cj4+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcmluZy0+ZGV2Owo+PiA+ICAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4gPiAr CXU4IG5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyX2h3Owo+PiA+ICAKPj4gPiAgCWxyY19zZXR1 cF9oYXJkd2FyZV9zdGF0dXNfcGFnZShyaW5nLAo+PiA+ICAJCQkJcmluZy0+ZGVmYXVsdF9jb250 ZXh0LT5lbmdpbmVbcmluZy0+aWRdLnN0YXRlKTsKPj4gPiBAQCAtMTQ5NCw3ICsxNDk3LDI5IEBA IHN0YXRpYyBpbnQgZ2VuOF9pbml0X2NvbW1vbl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KnJpbmcpCj4+ID4gIAkJICAgX01BU0tFRF9CSVRfRElTQUJMRShHRlhfUkVQTEFZX01PREUpIHwK Pj4gPiAgCQkgICBfTUFTS0VEX0JJVF9FTkFCTEUoR0ZYX1JVTl9MSVNUX0VOQUJMRSkpOwo+PiA+ ICAJUE9TVElOR19SRUFEKFJJTkdfTU9ERV9HRU43KHJpbmcpKTsKPj4gPiAtCXJpbmctPm5leHRf Y29udGV4dF9zdGF0dXNfYnVmZmVyID0gMDsKPj4gPiArCj4+ID4gKwkvKgo+PiA+ICsJICogSW5z dGVhZCBvZiByZXNldHRpbmcgdGhlIENvbnRleHQgU3RhdHVzIEJ1ZmZlciAoQ1NCKSByZWFkIHBv aW50ZXIgdG8KPj4gPiArCSAqIHplcm8sIHdlIG5lZWQgdG8gcmVhZCB0aGUgd3JpdGUgcG9pbnRl ciBmcm9tIGhhcmR3YXJlIGFuZCB1c2UgaXRzCj4+ID4gKwkgKiB2YWx1ZSBiZWNhdXNlICJ0aGlz IHJlZ2lzdGVyIGlzIHBvd2VyIGNvbnRleHQgc2F2ZSByZXN0b3JlZCIuCj4+ID4gKwkgKiBFZmZl Y3RpdmVseSwgdGhlc2Ugc3RhdGVzIGhhdmUgYmVlbiBvYnNlcnZlZDoKPj4gPiArCSAqCj4+ID4g KwkgKiAgICAgIHwgU3VzcGVuZC10by1pZGxlIChmcmVlemUpIHwgU3VzcGVuZC10by1SQU0gKG1l bSkgfAo+PiA+ICsJICogQkRXICB8IENTQiByZWdzIG5vdCByZXNldCAgICAgICB8IENTQiByZWdz IHJlc2V0ICAgICAgIHwKPj4gPiArCSAqIENIVCAgfCBDU0IgcmVncyBub3QgcmVzZXQgICAgICAg fCBDU0IgcmVncyBub3QgcmVzZXQgICB8Cj4+ID4gKwkgKi8KPj4gCj4+IFNLTCBhY3RzIHNpbWls YXIgdG8gQkRXLgo+PiAKPj4gPiArCW5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyX2h3ID0gKEk5 MTVfUkVBRChSSU5HX0NPTlRFWFRfU1RBVFVTX1BUUihyaW5nKSkKPj4gPiArCQkJCQkJICAgJiBH RU44X0NTQl9QVFJfTUFTSyk7Cj4+ID4gKwo+PiA+ICsJLyoKPj4gPiArCSAqIFdoZW4gdGhlIENT QiByZWdpc3RlcnMgYXJlIHJlc2V0IChhbHNvIGFmdGVyIHBvd2VyLXVwIC8gZ3B1IHJlc2V0KSwK Pj4gPiArCSAqIENTQiB3cml0ZSBwb2ludGVyIGlzIHNldCB0byBhbGwgMSdzLCB3aGljaCBpcyBu b3QgdmFsaWQsIHVzZSAnNScgaW4KPj4gPiArCSAqIHRoaXMgc3BlY2lhbCBjYXNlLCBzbyB0aGUg Zmlyc3QgZWxlbWVudCByZWFkIGlzIENTQlswXS4KPj4gPiArCSAqLwo+PiA+ICsJaWYgKG5leHRf Y29udGV4dF9zdGF0dXNfYnVmZmVyX2h3ID09IEdFTjhfQ1NCX1BUUl9NQVNLKQo+PiA+ICsJCW5l eHRfY29udGV4dF9zdGF0dXNfYnVmZmVyX2h3ID0gKEdFTjhfQ1NCX0VOVFJJRVMgLSAxKTsKPj4g PiArCj4+IAo+PiBOb3cgdGhhdCB0aGlzIGhhcyBiZWVuIHVucmF2ZWxsZWQsIEkgaG9wZSB3ZSBj YW4gbW92ZSB0b3dhcmRzCj4+IG9mIHJlbW92aW5nIHRoZSBkcml2ZXIgc3RhdGUgb2YgbmV4dCBj b250ZXh0IGJ1ZmZlciBjb21wbGV0ZWx5Ogo+PiAKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9hcmNoaXZlcy9pbnRlbC1nZngvMjAxNS1NYXkvMDY3MzEzLmh0bWwKPj4gCj4+IFJldmll d2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPj4gCj4+ID4g KwlyaW5nLT5uZXh0X2NvbnRleHRfc3RhdHVzX2J1ZmZlciA9IG5leHRfY29udGV4dF9zdGF0dXNf YnVmZmVyX2h3Owo+PiA+ICAJRFJNX0RFQlVHX0RSSVZFUigiRXhlY2xpc3RzIGVuYWJsZWQgZm9y ICVzXG4iLCByaW5nLT5uYW1lKTsKPj4gPiAgCj4+ID4gIAltZW1zZXQoJnJpbmctPmhhbmdjaGVj aywgMCwgc2l6ZW9mKHJpbmctPmhhbmdjaGVjaykpOwo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xy Yy5oCj4+ID4gaW5kZXggOGEwOGEyNy4uNGU2MGQ1NCAxMDA2NDQKPj4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaAo+PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5oCj4+ID4gQEAgLTI1LDYgKzI1LDggQEAKPj4gPiAgI2RlZmluZSBfSU5URUxf TFJDX0hfCj4+ID4gIAo+PiA+ICAjZGVmaW5lIEdFTjhfTFJfQ09OVEVYVF9BTElHTiA0MDk2Cj4+ ID4gKyNkZWZpbmUgR0VOOF9DU0JfRU5UUklFUyA2Cj4+ID4gKyNkZWZpbmUgR0VOOF9DU0JfUFRS X01BU0sgMHgwNwo+PiA+ICAKPj4gPiAgLyogRXhlY2xpc3RzIHJlZ3MgKi8KPj4gPiAgI2RlZmlu ZSBSSU5HX0VMU1AocmluZykJCQkoKHJpbmcpLT5tbWlvX2Jhc2UrMHgyMzApCj4+ID4gLS0gCj4+ ID4gMi41LjMKPj4gCj4+IAo+PiAKPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKPgo+IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=