Re: [PATCH 01/43] drm/i915: Don't pass sdvo_reg to intel_sdvo_select_{ddc, i2c}_bus()

Jani Nikula
2015-09-21T07:34:41Z

On Fri, 18 Sep 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_sdvo_select_ddc_bus() and intel_sdvo_select_i2c_bus() have no used
> for the passed in 'reg', so just drop it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/intel_sdvo.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index ca3dd7c..05521b5 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -2222,7 +2222,7 @@ intel_sdvo_guess_ddc_bus(struct intel_sdvo *sdvo)
> */
> static void
> intel_sdvo_select_ddc_bus(struct drm_i915_private *dev_priv,
> - struct intel_sdvo *sdvo, u32 reg)
> + struct intel_sdvo *sdvo)
> {
> struct sdvo_device_mapping *mapping;
>
> @@ -2239,7 +2239,7 @@ intel_sdvo_select_ddc_bus(struct drm_i915_private *dev_priv,
>
> static void
> intel_sdvo_select_i2c_bus(struct drm_i915_private *dev_priv,
> - struct intel_sdvo *sdvo, u32 reg)
> + struct intel_sdvo *sdvo)
> {
> struct sdvo_device_mapping *mapping;
> u8 pin;
> @@ -2925,7 +2925,7 @@ bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob)
> intel_sdvo->sdvo_reg = sdvo_reg;
> intel_sdvo->is_sdvob = is_sdvob;
> intel_sdvo->slave_addr = intel_sdvo_get_slave_addr(dev, intel_sdvo) >> 1;
> - intel_sdvo_select_i2c_bus(dev_priv, intel_sdvo, sdvo_reg);
> + intel_sdvo_select_i2c_bus(dev_priv, intel_sdvo);
> if (!intel_sdvo_init_ddc_proxy(intel_sdvo, dev))
> goto err_i2c_bus;
>
> @@ -2987,7 +2987,7 @@ bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob)
> */
> intel_sdvo->base.cloneable = 0;
>
> - intel_sdvo_select_ddc_bus(dev_priv, intel_sdvo, sdvo_reg);
> + intel_sdvo_select_ddc_bus(dev_priv, intel_sdvo);
>
> /* Set the input timing to the screen. Assume always input 0. */
> if (!intel_sdvo_set_target_input(intel_sdvo))
> --
> 2.4.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center