From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: Send out the full AUX address
Date: Thu, 19 Mar 2015 12:20:57 +0200 [thread overview]
Message-ID: <87619xwanq.fsf@intel.com> (raw)
In-Reply-To: <1426758247-20308-2-git-send-email-ville.syrjala@linux.intel.com>
On Thu, 19 Mar 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> AUX addresses are 20 bits long. Send out the entire address instead of
> just the low 16 bits.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 3967af1..637dd53 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -942,8 +942,9 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
> size_t txsize, rxsize;
> int ret;
>
> - txbuf[0] = msg->request << 4;
> - txbuf[1] = msg->address >> 8;
> + txbuf[0] = (msg->request << 4) |
> + ((msg->address >> 16) & 0xf);
> + txbuf[1] = (msg->address >> 8) & 0xff;
> txbuf[2] = msg->address & 0xff;
> txbuf[3] = msg->size - 1;
>
> --
> 2.0.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-19 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 9:44 [PATCH 1/3] drm/dp: Print the number of bytes processed for aux nacks ville.syrjala
2015-03-19 9:44 ` [PATCH 2/3] drm/i915: Send out the full AUX address ville.syrjala
2015-03-19 10:20 ` Jani Nikula [this message]
2015-03-19 14:52 ` [Intel-gfx] " Daniel Vetter
2015-03-19 9:44 ` [PATCH 3/3] drm/radeon: " ville.syrjala
2015-03-19 17:42 ` shuang.he
2015-03-19 10:21 ` [PATCH 1/3] drm/dp: Print the number of bytes processed for aux nacks Jani Nikula
2015-03-19 11:38 ` [PATCH v2 " ville.syrjala
2015-03-19 11:48 ` Jani Nikula
2015-03-19 14:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87619xwanq.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox