From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Fix SRC_COPY width on 830/845g Date: Fri, 12 Sep 2014 18:06:31 +0300 Message-ID: <8761gsdgjs.fsf@intel.com> References: <1410503862-29589-1-git-send-email-chris@chris-wilson.co.uk> <87egvhcmlv.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 23D5089DC0 for ; Fri, 12 Sep 2014 08:07:00 -0700 (PDT) In-Reply-To: <87egvhcmlv.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 12 Sep 2014, Jani Nikula wrote: > On Fri, 12 Sep 2014, Chris Wilson wrote: >> One small change I forgot to make in >> >> commit c4d69da167fa967749aeb70bc0e94a457e5d00c1 >> Author: Chris Wilson >> Date: Mon Sep 8 14:25:41 2014 +0100 >> >> drm/i915: Evict CS TLBs between batches >> >> was to update the copy width for the compact BLT copy instruction. >> >> Reported-by: Thomas Richter >> Signed-off-by: Chris Wilson >> Cc: Thomas Richter >> Cc: Jani Nikula >> Cc: stable@vger.kernel.org > > http://mid.gmane.org/54129ED3.8060105@math.tu-berlin.de says > > Tested-by: Thomas Richter > > (Thomas, your mails have broken in-reply-to/references more often than > not, breaking threading. Please check your setup.) Pushed to drm-intel-fixes with Daniel's irc ack, thanks for the patch and testing. BR, Jani. > > >> --- >> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c >> index d0156d6..45d70fd 100644 >> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c >> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c >> @@ -1386,7 +1386,7 @@ i830_emit_batchbuffer(struct i915_gem_request *rq, >> */ >> intel_ring_emit(ring, SRC_COPY_BLT_CMD | BLT_WRITE_RGBA); >> intel_ring_emit(ring, BLT_DEPTH_32 | BLT_ROP_SRC_COPY | 4096); >> - intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 1024); >> + intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 4096); >> intel_ring_emit(ring, cs_offset); >> intel_ring_emit(ring, 4096); >> intel_ring_emit(ring, offset); >> -- >> 1.9.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center