From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: Reorder the AUX_CTL bits in descending order
Date: Tue, 21 Jan 2014 12:09:18 +0200 [thread overview]
Message-ID: <8761pd7ik1.fsf@intel.com> (raw)
In-Reply-To: <1390233152-2913-4-git-send-email-damien.lespiau@intel.com>
On Mon, 20 Jan 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> So it's easier to compare what we program with the documentation, not
> having to jump at all.
This could be squashed into the previous patch just as well, but either
way,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index a9a05d2..ae9902a 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -433,14 +433,14 @@ static uint32_t i9xx_get_aux_send_ctl(struct intel_dp *intel_dp,
> timeout = DP_AUX_CH_CTL_TIME_OUT_400us;
>
> return DP_AUX_CH_CTL_SEND_BUSY |
> + DP_AUX_CH_CTL_DONE |
> (has_aux_irq ? DP_AUX_CH_CTL_INTERRUPT : 0) |
> + DP_AUX_CH_CTL_TIME_OUT_ERROR |
> timeout |
> + DP_AUX_CH_CTL_RECEIVE_ERROR |
> (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> (precharge << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> - (aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT) |
> - DP_AUX_CH_CTL_DONE |
> - DP_AUX_CH_CTL_TIME_OUT_ERROR |
> - DP_AUX_CH_CTL_RECEIVE_ERROR;
> + (aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
> }
>
> static int
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-01-21 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 15:52 New DP vfuncs get_aux{clock_divider,send_ctl} Damien Lespiau
2014-01-20 15:52 ` [PATCH 1/4] drm/i915: Turn get_aux_clock_divider() into per-product vfuncs Damien Lespiau
2014-01-21 9:49 ` Jani Nikula
2014-01-21 13:35 ` [PATCH 1/4 v2] drm/i915: Turn get_aux_clock_divider() into per-platform vfuncs Damien Lespiau
2014-01-21 15:52 ` Jani Nikula
2014-01-20 15:52 ` [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send Damien Lespiau
2014-01-21 10:07 ` Jani Nikula
2014-01-21 11:59 ` Damien Lespiau
2014-01-21 12:12 ` Jani Nikula
2014-01-20 15:52 ` [PATCH 3/4] drm/i915: Reorder the AUX_CTL bits in descending order Damien Lespiau
2014-01-21 10:09 ` Jani Nikula [this message]
2014-01-21 11:17 ` Damien Lespiau
2014-01-20 15:52 ` [PATCH 4/4] drm/i915: Introduce a get_aux_send_ctl() vfunc Damien Lespiau
2014-01-21 10:12 ` Jani Nikula
2014-01-21 13:37 ` [PATCH 4/4 v2] " Damien Lespiau
2014-01-21 16:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761pd7ik1.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox