From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Richard Weinberger" <richard@nod.at>,
"Alexander Usyskin" <alexander.usyskin@intel.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Karthik Poosa" <karthik.poosa@intel.com>,
"Reuven Abliyev" <reuven.abliyev@intel.com>,
"Oren Weil" <oren.jer.weil@intel.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
"DRI mailing list" <dri-devel@lists.freedesktop.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 01/11] mtd: core: always create master device
Date: Wed, 11 Jun 2025 11:34:25 +0200 [thread overview]
Message-ID: <877c1ivcym.fsf@bootlin.com> (raw)
In-Reply-To: <c90c8bad-9c7a-4bf7-8282-ebefebba90a3@roeck-us.net> (Guenter Roeck's message of "Tue, 10 Jun 2025 09:15:25 -0700")
On 10/06/2025 at 09:15:25 -07, Guenter Roeck <linux@roeck-us.net> wrote:
> On 6/10/25 05:54, Richard Weinberger wrote:
>> ----- Ursprüngliche Mail -----
>>> Von: "Alexander Usyskin" <alexander.usyskin@intel.com>
>>> Richard, I've reproduced your setup (modulo that I must load mtdram manually)
>>> and patch provided in this thread helps to fix the issue.
>>> Can you apply and confirm?
>> Yes, it fixes the issue here! :-)
>>
>
> It doesn't seem to fix the issue if the partition data is in
> devicetree.
I had a look at the patch again. The whole mtd core makes assumptions on
parenting, which is totally changed with this patch. There are so many
creative ways this can break, I don't believe we are going to continue
this route. I propose to revert the patch entirely for now. We need to
find another approach, I'm sorry.
Alexander, can you please remind me what was your initial problem? I
believe you needed to anchor runtime PM on the master device. Can you
please elaborate again? Why taking the controller as source (the
default, before your change) did not work? Also why was selecting
MTD_PARTITIONED_MASTER not an option for you? I'm trying to get to the
root of this change again, so we can find a solution fixing "the world"
(fast) and in a second time a way to address your problem.
Thanks,
Miquèl
next prev parent reply other threads:[~2025-06-11 9:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 14:09 [PATCH v6 00/11] mtd: add driver for Intel discrete graphics Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 01/11] mtd: core: always create master device Alexander Usyskin
2025-06-08 1:37 ` Guenter Roeck
2025-06-08 7:00 ` Usyskin, Alexander
2025-06-08 19:37 ` Miquel Raynal
2025-06-09 0:59 ` Guenter Roeck
2025-06-09 9:43 ` Miquel Raynal
2025-06-09 12:23 ` Usyskin, Alexander
2025-06-09 13:08 ` Guenter Roeck
2025-06-09 15:16 ` Usyskin, Alexander
2025-06-09 15:53 ` Guenter Roeck
2025-06-09 21:27 ` Richard Weinberger
2025-06-10 11:02 ` Usyskin, Alexander
2025-06-10 12:54 ` Richard Weinberger
2025-06-10 16:15 ` Guenter Roeck
2025-06-11 9:34 ` Miquel Raynal [this message]
2025-06-11 10:26 ` Richard Weinberger
2025-06-11 10:52 ` Usyskin, Alexander
2025-06-11 14:53 ` Miquel Raynal
2025-06-12 10:01 ` Usyskin, Alexander
2025-06-12 10:25 ` Richard Weinberger
2025-06-12 12:37 ` Usyskin, Alexander
2025-03-02 14:09 ` [PATCH v6 02/11] mtd: add driver for intel graphics non-volatile memory device Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 03/11] mtd: intel-dg: implement region enumeration Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 04/11] mtd: intel-dg: implement access functions Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 05/11] mtd: intel-dg: register with mtd Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 06/11] mtd: intel-dg: align 64bit read and write Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 07/11] mtd: intel-dg: wake card on operations Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 08/11] drm/i915/nvm: add nvm device for discrete graphics Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 09/11] drm/i915/nvm: add support for access mode Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 10/11] drm/xe/nvm: add on-die non-volatile memory device Alexander Usyskin
2025-03-02 14:09 ` [PATCH v6 11/11] drm/xe/nvm: add support for access mode Alexander Usyskin
2025-03-02 15:02 ` ✗ Fi.CI.CHECKPATCH: warning for mtd: add driver for Intel discrete graphics (rev6) Patchwork
2025-03-02 15:02 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-03-02 15:22 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-02 17:04 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-18 16:02 ` [PATCH v6 00/11] mtd: add driver for Intel discrete graphics Miquel Raynal
2025-03-26 15:22 ` Usyskin, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c1ivcym.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=airlied@gmail.com \
--cc=alexander.usyskin@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=karthik.poosa@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=oren.jer.weil@intel.com \
--cc=reuven.abliyev@intel.com \
--cc=richard@nod.at \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).