From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Murthy, Arun R" <arun.r.murthy@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Srikanth V, NagaVenkata" <nagavenkata.srikanth.v@intel.com>
Subject: RE: [PATCHv2 2/3] drm/i915/dp: read Aux RD interval just before reading the FFE preset
Date: Wed, 25 Sep 2024 11:25:33 +0300 [thread overview]
Message-ID: <877cb03zsy.fsf@intel.com> (raw)
In-Reply-To: <IA0PR11MB730764C8A2E8453527F25CFABA692@IA0PR11MB7307.namprd11.prod.outlook.com>
On Wed, 25 Sep 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> > + /*
>> > + * During LT, Tx shall read DPCD 02216h before DPCD 00202h
>> to 00207h and
>> > + * 0200Ch through 0200Fh.
>> > + */
>>
>> I really like comments that are actual helpful sentences. Why do I I need to look
>> up what 02216h and 00202h-00207h are? What's wrong with the original
>> comment?
>>
> Original comment was wrong "read delay before reading link status"
> In the updated comment will replace the registers with meaningful name.
If you replace the registers with meaningful names, won't you end up
with "DPCD 02216h" -> "delay" and "DPCD 00202h to 00207h" -> "link
status"?
BR,
Jani.
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-25 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 6:13 [PATCHv2 0/3] Some correction in the DP Link Training sequence Arun R Murthy
2024-09-24 6:13 ` [PATCHv2 1/3] drm/i915/dp: use fsleep instead of usleep_range for LT Arun R Murthy
2024-09-24 6:13 ` [PATCHv2 2/3] drm/i915/dp: read Aux RD interval just before reading the FFE preset Arun R Murthy
2024-09-24 6:33 ` Kandpal, Suraj
2024-09-24 7:48 ` Jani Nikula
2024-09-25 3:51 ` Murthy, Arun R
2024-09-25 8:25 ` Jani Nikula [this message]
2024-09-24 6:13 ` [PATCHv2 3/3] drm/i915/dp: Include the time taken by AUX Tx for timeout Arun R Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cb03zsy.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=nagavenkata.srikanth.v@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).