From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8056DC4345F for ; Thu, 11 Apr 2024 15:25:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB59D10F185; Thu, 11 Apr 2024 15:25:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Ag2IJrVq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4900B10F189; Thu, 11 Apr 2024 15:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712849138; x=1744385138; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=a81Df6w9Zvh1CHKFLbu5a03nMo/xzhwiat+oKvGw7P0=; b=Ag2IJrVqR6ntfERXBjK75IW4ujXwDh5hju/CjOJE4u/f68/btVWxr47j JlcMMshmOpEp7krDF47vpZd5g0cPDIoSw40Pd0Gd6IY9QHdle7/kgC7tZ ZsnAyB8qPKPvU9JZcmUtrqezrtJFn7P5QWHREs5WO8DnY/xT9rYZIVJUE 76XgvtjnB7K5PaflRfQmOkbydQaPNnQGJmOAbeEbkiO36ehv6vAuuMWRH FE4B1GFTUu7i22XVF8nvq5DuoJLDy42XKgndmi5Grd5hzmXGy3hUYq5UD hLdTzYU94ssU1lx84vxlLxgf4jT497JY/FGxXNhBqXzBcxEX2jbYK0Ssq g==; X-CSE-ConnectionGUID: eEiIGbZ9T1CesR3Hj5NkUg== X-CSE-MsgGUID: GmX/l4yRTl+J48ahdw0cFg== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="8141796" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8141796" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 08:25:31 -0700 X-CSE-ConnectionGUID: GKc4nwOKSXuMhAWqHzBUnQ== X-CSE-MsgGUID: gBerfbMmSJKGnOb5Fwes5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="25582616" Received: from unknown (HELO localhost) ([10.237.66.160]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 08:25:27 -0700 From: Jani Nikula To: Andi Shyti Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Dave Airlie , Lucas De Marchi , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH 05/10] drm: move intel_lpe_audio.h under include/drm/intel In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Thu, 11 Apr 2024 18:25:23 +0300 Message-ID: <877ch36hwc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 11 Apr 2024, Andi Shyti wrote: > Hi Jani, > > On Wed, Apr 10, 2024 at 01:05:12PM +0300, Jani Nikula wrote: >> Clean up the top level include/drm directory by grouping all the Intel >> specific files under a common subdirectory. >> >> Cc: Daniel Vetter >> Cc: Dave Airlie >> Cc: Lucas De Marchi >> Cc: Jaroslav Kysela >> Cc: Takashi Iwai >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- >> drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +- >> include/drm/{ => intel}/intel_lpe_audio.h | 0 > > strange thing here is that we have two different > intel_lpe_audio.h. Can't they be merged? Not so strange. The one in i915 is internal to i915, and the one in include/drm is shared with sound/x86/intel_hdmi_audio.c. > And, perhaps, we could also think of dropping the intel_ prefix > for the files inside drm/intel/. This series was scripted, so I didn't go into manual stuff like that (yet). :) BR, Jani. > > In any case, > > Reviewed-by: Andi Shyti > > Thanks, > Andi -- Jani Nikula, Intel