From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1360C76196 for ; Sat, 1 Apr 2023 03:11:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B4C210E0DF; Sat, 1 Apr 2023 03:11:32 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDFD010E012; Sat, 1 Apr 2023 03:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680318689; x=1711854689; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=/Qyf7UcIKKPZ3sFVfd65PVJVZXwu8Y0Fv/gjtuu2FkA=; b=hDj6QgliL4xxIOmmYeAZoiEjXOD1sxHWr1CDOf65I7MXrshCqwVlv8hf tMYa3Sqkbg9CGcD0tfLmupOR/v+EIoyY2szqp9Z8ARpq88wn11b8qx6RN A1HQu7Nfqq37H1p9x1r1reLeUFrn7j8j/n+Y5qRqsNFCGUcx5TkW8MVlf yiM7wjFM1zlg7CdXRUJG2jvIzfbMoq7s7TdcHSqnhAME2WVlOxlhsrTTk v9Li2rmMvQs0d/2Pq0hoxjq1N8qy4GCgfd5GPQI8d67ekQoIDkWJs0RzP aW18JatPK4MNg18TH7sDeUUSD4ZJsktcrzFc7DWbegdu69m5CTZ4tCEtf g==; X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="406640644" X-IronPort-AV: E=Sophos;i="5.98,308,1673942400"; d="scan'208";a="406640644" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 20:11:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="717921433" X-IronPort-AV: E=Sophos;i="5.98,308,1673942400"; d="scan'208";a="717921433" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.61.228]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 20:11:29 -0700 Date: Fri, 31 Mar 2023 20:11:29 -0700 Message-ID: <877cuwguu6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20230401020049.3843873-1-vinay.belgaumkar@intel.com> References: <20230401020049.3843873-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > @@ -478,20 +507,15 @@ int intel_guc_slpc_set_min_freq(struct intel_guc_slpc *slpc, u32 val) > val > slpc->max_freq_softlimit) > return -EINVAL; > > + /* Ignore efficient freq if lower min freq is requested */ > + ret = intel_guc_slpc_set_ignore_eff_freq(slpc, val < slpc->rp1_freq); > + if (ret) > + goto out; > + I don't agree with this. If we are now providing an interface explicitly to ignore RPe, that should be /only/ way to ignore RPe. There should be no other "under the hood" ignoring of RPe. In other words, ignoring RPe should be minimized unless explicitly requested. I don't clearly understand why this was done previously but it makes even less sense to me now after this patch. Thanks. -- Ashutosh > /* Need a lock now since waitboost can be modifying min as well */ > mutex_lock(&slpc->lock); > wakeref = intel_runtime_pm_get(&i915->runtime_pm); > > - /* Ignore efficient freq if lower min freq is requested */ > - ret = slpc_set_param(slpc, > - SLPC_PARAM_IGNORE_EFFICIENT_FREQUENCY, > - val < slpc->rp1_freq); > - if (ret) { > - guc_probe_error(slpc_to_guc(slpc), "Failed to toggle efficient freq: %pe\n", > - ERR_PTR(ret)); > - goto out; > - } > - > ret = slpc_set_param(slpc, > SLPC_PARAM_GLOBAL_MIN_GT_UNSLICE_FREQ_MHZ, > val);